Review Request 53736: fix GEODE-2088 Incorrect TransactionDataNotColocatedException is thrown after bucket has been moved due to rebalance

/diff/ Testing --- precheckin. Thanks, Eric Shu

Review Request 53657: GEODE-2091: Do not return false when containsValueForKey call failed in transaction due to BucketNotFoundException

/apache/geode/disttx/PRDistTXWithVersionsDUnitTest.java 8ff1d94 geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java 2122960 Diff: https://reviews.apache.org/r/53657/diff/ Testing --- precheckin. Thanks, Eric Shu

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/#review155512 --- Ship it! Ship It! - Eric Shu On Nov. 9, 2016, 11:11 p.m

Re: Review Request 53503: GEODE-2077: throw appropriate exceptions when get call in transactions failed with certain exceptions.

bedb1d4 geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java 37ea4e5 Diff: https://reviews.apache.org/r/53503/diff/ Testing --- Thanks, Eric Shu

Re: Review Request 53503: GEODE-2077: throw appropriate exceptions when get call in transactions failed with certain exceptions.

geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java bedb1d4 geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java 37ea4e5 Diff: https://reviews.apache.org/r/53503/diff/ Testing --- Thanks, Eric Shu

Re: Review Request 53268: GEODE-2043: change makeTombstone to handle exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53268/#review154140 --- Ship it! Ship It! - Eric Shu On Oct. 28, 2016, 5:24 p.m

Re: Review Request 53071: GEODE-2021: Get on non colocated keys in a transaction does not throw TransactionDataNotColocatedException

://reviews.apache.org/r/53071/diff/ Testing --- precheckin. Thanks, Eric Shu

Review Request 53071: GEODE-2021: Get on non colocated keys in a transaction does not throw TransactionDataNotColocatedException

: https://reviews.apache.org/r/53071/diff/ Testing --- precheckin. Thanks, Eric Shu

Re: Review Request 53071: GEODE-2021: Get on non colocated keys in a transaction does not throw TransactionDataNotColocatedException

/PRTransactionDUnitTest.java 516c240 Diff: https://reviews.apache.org/r/53071/diff/ Testing --- precheckin. Thanks, Eric Shu

Review Request 52812: GEODE-1999: Fix offheap memory leak when exception is thrown during basicDestroy call to remove GatewaySenderEventImpl from the sender queue

/SerialGatewaySenderQueue.java 79b9d86 Diff: https://reviews.apache.org/r/52812/diff/ Testing --- prechecking Thanks, Eric Shu

Re: Review Request 51831: change EntryEventImpl code that does instanceof StoredObject checks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51831/#review149095 --- Ship it! Ship It! - Eric Shu On Sept. 14, 2016, 10:34 p.m

Re: Review Request 51302: GEODE-1768: CI failure: ResourceManagerDUnitTest.testRemoveDuringKeySet

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51302/#review146456 --- Ship it! Ship It! - Eric Shu On Aug. 22, 2016, 9:11 p.m

Re: Review Request 50680: fix replace on overflowed entry

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50680/#review144407 --- Ship it! Ship It! - Eric Shu On Aug. 1, 2016, 11:17 p.m

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

ps://reviews.apache.org/r/50242/#review143269 ------- On July 28, 2016, 8:44 p.m., Eric Shu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

> and only null out gatewayQueueEvent if put returns true. It has been handled. - Eric --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/#review143266 ------- On July 28, 2016, 8:44 p.m., Eric Shu wrote: > >

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

/wan/serial/SerialGatewaySenderQueue.java efa7870 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/TestBlockingHARegionQueue.java d57290a Diff: https://reviews.apache.org/r/50242/diff/ Testing --- precheckin. Thanks, Eric Shu

Review Request 50399: GEODE-1692: fix IllegalStateException in Transaction when the node is disconnecting from the ds

, Eric Shu

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

: https://reviews.apache.org/r/50242/diff/ Testing --- precheckin. Thanks, Eric Shu

Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

offheap as necessary. Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueue.java 57d6e34 Diff: https://reviews.apache.org/r/50242/diff/ Testing --- precheckin. Thanks, Eric Shu

Re: TXManagerImplTest is failing

Yes, I am working on a fix and is running precheckin right now. On Mon, Jul 11, 2016 at 1:40 PM, Kirk Lund wrote: > Is anyone working on this failing test? > > :geode-core:test > > com.gemstone.gemfire.internal.cache.TXManagerImplTest > > getLockAfterTXStateCommitted FAILED >

Re: Review Request 49712: GEODE-1621 Fix resources not being released during cleanup when an IllegalArgumentException is thrown

onized metnods just to prevend the non normal cache close case? The above fix would avoid that. - Eric --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49712/#review141042

Review Request 49712: GEODE-1621 Fix resources not being released during cleanup when an IllegalArgumentException is thrown

/cache/TXLockRequest.java 06c7572 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXState.java d64426b Diff: https://reviews.apache.org/r/49712/diff/ Testing --- precheckin Thanks, Eric Shu

Re: Review Request 49329: GEODE-1607: ConcurrentModificationException could occur when iterating through hostedTXStates HashMap during closing cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49329/#review139868 ------- On June 29, 2016, 8 p.m., Eric Shu wrote: > > --

Re: Review Request 49329: GEODE-1607: ConcurrentModificationException could occur when iterating through hostedTXStates HashMap during closing cache

1512234 Diff: https://reviews.apache.org/r/49329/diff/ Testing --- precheckin Thanks, Eric Shu

Review Request 49329: GEODE-1607: ConcurrentModificationException could occur when iterating through hostedTXStates HashMap during closing cache

/49329/diff/ Testing --- precheckin Thanks, Eric Shu

Review Request 49101: GEODE-1546: Proxy server may not be able to send message to other servers to clean up transactions initiated by a shutdown client

/AcceptorImplJUnitTest.java 7c52a89 Diff: https://reviews.apache.org/r/49101/diff/ Testing --- precheckin Thanks, Eric Shu

Review Request 48652: GEODE-1517: Transaction could still proceed after TXManagerImpl is closing during cache close

/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java ce24947 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java bbbf714 Diff: https://reviews.apache.org/r/48652/diff/ Testing --- precheckin Thanks, Eric Shu

Re: Review Request 48189: remove sqlf, sql fabric, gemfirexd from geode-core

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48189/#review136373 --- Ship it! - Eric Shu On June 2, 2016, 10:20 p.m., Darrel

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

che.org/r/48187/#review136004 --- On June 3, 2016, 12:05 a.m., Eric Shu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/RollbackCommand.java ed7c706 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java a4b8127 Diff: https://reviews.apache.org/r/48187/diff/ Testing --- precheckin. Thanks, Eric Shu

Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java a4b8127 Diff: https://reviews.apache.org/r/48187/diff/ Testing --- precheckin. Thanks, Eric Shu

Re: Review Request 48187: GEODE-1491 A rollback command could fail with IllegalStateException if the client failed over and the transaction has been rolled back

/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/RollbackCommand.java ed7c706 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java a4b8127 Diff: https://reviews.apache.org/r/48187/diff/ Testing --- precheckin. Thanks, Eric Shu

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

PRE-CREATION Diff: https://reviews.apache.org/r/47543/diff/ Testing --- precheckin Thanks, Eric Shu

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47543/diff/ Testing --- precheckin Thanks, Eric Shu

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

/PartitionMessageTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47543/diff/ Testing --- precheckin Thanks, Eric Shu

Re: Review Request 47543: GEODE-1400, Handle inflight p2p msg late arrival

://reviews.apache.org/r/47543/diff/ Testing --- precheckin Thanks, Eric Shu

Re: Review Request 47745: remove sqlf code in GemFireCacheImpl

/GemFireCacheImpl.java (line 920) <https://reviews.apache.org/r/47745/#comment199456> This comment can be removed. - Eric Shu On May 23, 2016, 10:41 p.m., Darrel Schneider wrote: > > --- > This is an automatically g

Re: Review Request 47435: GEODE-1392: add tests for BlobHelper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47435/#review133837 --- Ship it! Ship It! - Eric Shu On May 17, 2016, 6:43 p.m

Re: Review Request 47128: add release call when GatewaySenderEventImpl removed from tempQueue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47128/#review132556 --- Ship it! Ship It! - Eric Shu On May 9, 2016, 5:32 p.m

Re: Review Request 47191: removed DataAsAddress references

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47191/#review132550 --- Ship it! Ship It! - Eric Shu On May 10, 2016, 9:41 p.m

Re: Review Request 46275: GEODE-1234: Provide a test hook to track transactions scheduled to be removed

of waiting for default 180 seconds. Diffs (updated) - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientHealthMonitor.java 93e543d Diff: https://reviews.apache.org/r/46275/diff/ Testing --- Thanks, Eric Shu

Review Request 46275: GEODE-1234: Provide a test hook to track transactions scheduled to be removed

/ClientHealthMonitor.java 93e543d Diff: https://reviews.apache.org/r/46275/diff/ Testing --- Thanks, Eric Shu

Re: Review Request 46151: possible fix for intermittent failure of testTombstones

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46151/#review129019 --- Ship it! Ship It! - Eric Shu On April 13, 2016, 4:27 p.m

Review Request 46124: GEODE-1221 Move implemented functions to test tree

/cache/RollbackFunction.java PRE-CREATION Diff: https://reviews.apache.org/r/46124/diff/ Testing --- Thanks, Eric Shu

Review Request 45764: fix GEODE-1169

/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionBase.java 02673a2 Diff: https://reviews.apache.org/r/45764/diff/ Testing --- precheckin Thanks, Eric Shu

Re: Review Request 45716: fix GEODE-1167

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45716/#review126988 --- Ship it! Ship It! - Eric Shu On April 4, 2016, 11:51 p.m

Re: Review Request 40518: cleanup of SimpleMemoryAllocatorImpl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40518/#review107629 --- Ship it! Ship It! - Eric Shu On Nov. 20, 2015, 1:19 a.m

Re: Review Request 40493: GEODE-438: fix race in off-heap resource manager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40493/#review107237 --- Ship it! Ship It! - Eric Shu On Nov. 19, 2015, 6:03 p.m

Review Request 36948: GEODE-176: fixes RegionDestroyedException when accessing bucket regions.

/r/36948/diff/ Testing --- Thanks, Eric Shu