Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/285#discussion_r88081170
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java
---
@@ -0,0 +1,75 @@
+package
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/285#discussion_r88080988
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java
---
@@ -0,0 +1,75 @@
+package
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/285
GEODE-1617: Regions can be created with a variety of characters that â¦
â¦are unsupported
Added comprehensive test to validate region names
You can merge this pull request
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/276
Precheckin successful
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/281
GEODE-2084 - When executing a rest api in a browser, the login page pâ¦
â¦resented in the browser is not setting the username/password correctly
Changed
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/276
1. I am using Autowire, the annotation is on the base class's constructor.
But as for the injection via the constructor, please review
https://spring.io/blog/2015/11/29/how-not-to-hate
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86900866
--- Diff:
geode-core/src/main/java/org/apache/geode/security/PostProcessor.java ---
@@ -44,6 +47,9 @@ default void init(Properties securityProps
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86900814
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java
---
@@ -409,6 +435,34 @@ public Object
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86900842
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
---
@@ -87,6 +89,12 @@
Object postProcess(Object
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86900849
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java
---
@@ -87,6 +89,12 @@
Object postProcess(Object
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/276
precheckin successful
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86852018
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86852092
--- Diff:
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
---
@@ -50,6 +52,11
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86848834
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/276#discussion_r86847492
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java
---
@@ -0,0 +1,185
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/276
Precheckin successful except for one flaky test,
QueueCommandsDUnitTest.testCreateUpdatesSharedConfig which doesn't appear to be
related to this change.
---
If your project is set up
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/276
precheckin running
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/276
Don't accept this PR yet. This is just a checkin to preserve work.
Addressed all of the issues listed above. Added test for adhoc queries.
Still need a test for named queries
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/276
GEODE-1993: postprocess region/key
Add post processing to the GET {region}/{key..key} endpoint
precheckin running
You can merge this pull request into a Git repository by running
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/273
Travis is happy now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/273
I didn't modify those classes. I merged in from develop, which means this
code is not formatted correctly in develop.
---
If your project is set up for it, you can reply to this email
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/273
Updated to use SimpleSecurityManager.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/273
Feature/geode 1983
Updated the spring security configuration to support the Swagger2 resources.
Precheckin successful.
You can merge this pull request into a Git repository by running
Github user kjduling closed the pull request at:
https://github.com/apache/incubator-geode/pull/272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/272
precheckin successful
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/272
GEODE-1983: Swagger is broken with integrated security
Updated the spring security configuration to support the Swagger2 resources.
You can merge this pull request into a Git repository
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/271
Feature/geode 2014
Updates to the LICENSE file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjduling/incubator-geode feature/GEODE
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/270
GEODE-2014: Upgrade Swagger libraries
Updated expected jars list after swagger update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/265#discussion_r84528366
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java
---
@@ -0,0 +1,57
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/265
Added a test to see if Swagger is up and the splash page has the right
Geode headers.
Upgraded to the Swagger2 specification
Removed the accidental checkin of the sleep
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/265
GEODE-2014: Upgrade Swagger libraries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2014
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/263
GEODE-1983: Swagger is broken with integrated security
This required a simple configuration change. The swagger endpoints needed
to be marked as permitAll so that the resources could
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/262
GEODE-2004: Create/update/delete query through rest api should requirâ¦
â¦e DATA:READ instead of DATA:WRITE
You can merge this pull request into a Git repository by running:
$ git
Github user kjduling closed the pull request at:
https://github.com/apache/incubator-geode/pull/251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/253
GEODE-136: Fix possible NullPointerException in GetRegionsFunction
Addresses an unlikely but possible NPE.
Removes use of a deprecated interface.
Introduces a missing unit test
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/252
GEODE-136: Fix possible NullPointerException in GetRegionsFunction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjduling/incubator
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/250
Restarting this task, closing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kjduling closed the pull request at:
https://github.com/apache/incubator-geode/pull/250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/250#discussion_r81654416
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -156,7 +166,14 @@ protected static Properties
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/247
Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/251
Feature/geode 1570
precheckin running
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1570
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/250
Feature/geode 1948
If the provided properties file is not found, before failing,
geode.properties will be tried. If geode.properties is not found,
gemfire.properties will be tried
Github user kjduling closed the pull request at:
https://github.com/apache/incubator-geode/pull/236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/236
Closing as this was only a temp.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/201
Good catch.
@davebarnes97 @karensmolermiller Can either of you follow up on this?
Looks like we've a page out of date.
---
If your project is set up for it, you can reply
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/230
No existing test exposed this. This is in reaction to a code analysis.
Case by case, the code may or may not be doing what the developer intended
because of the nature of == vs .equals
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/230#discussion_r74340943
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/AbstractCliAroundInterceptor.java
---
@@ -88,7 +88,7 @@ protected
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/230#discussion_r74340020
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/230#discussion_r74338007
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/227
Rename servlet URLs from gemfire to geode
Renamed gemfire-api/v1 to geode/v1
Renamed gemfire/v1 to geode-mgmt/v1
Verified old context paths still work, so both can be used
Github user kjduling commented on the pull request:
https://github.com/apache/incubator-geode/commit/f0d36eea5da1102d7293fd2fd573c7ad3ae01d66#commitcomment-18387220
+1 - oversight on my part.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/214
GEODE-1680: Change "list regions" to DATA:READ permissions
Edited the annotations for listRegions in RegionCommands and updated unit
tests.
precheckin done
You
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/201
GEODE-1617: Regions can be created with a variety of characters that are
unsupported
Updated the pull request for this ticket after several unit tests failed.
You can merge this pull
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/196
Closing this one until I can get the precheckin tests to pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kjduling closed the pull request at:
https://github.com/apache/incubator-geode/pull/196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/196
Ok, good. The errors are "correct" because regions are being created with
invalid names. I'll update the tests and determine which are internal regions.
---
If your project
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/186
gfsh unable to destroy region that has an hyphen in its name
Added check for a hyphen in region name. This has to be wrapped in quotes
before searching.
Added test to verify creation
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/183
Closing this. The test worked the first time, but subsequent runs
consistently fail. I'll start a fresh pull request once I resolve it.
---
If your project is set up for it, you can
Github user kjduling closed the pull request at:
https://github.com/apache/incubator-geode/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/183
I'm doing the test in a separate checkin once I have a final decision on
what characters are valid. Right now, it appears only alphanumeric, an
underscore, and a hyphen are the only valid
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/183
GEODE-1615: gfsh unable to destroy region that has an hyphen in its name
Added a test for whether or not the region contains a hyphen in the name.
If it does, it is necessary to wrap
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/170
GEODE-1575 - Unhandled NoClassDefFound Exception when creating regions
Added exception clause for NoClassDefFoundError
You can merge this pull request into a Git repository by running
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/166
GEODE-117 - gfsh put ignores --skip-if-exists flag
Fixed test, which erroneously reported that the --skip-if-exists flag is
honored.
Implemented check for flag within the put
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/157
GFSH SYS_HOST_NAME variable should report hostname
Resubmitting this due to Travis failure
You can merge this pull request into a Git repository by running:
$ git pull https
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/152
Resubmitting due to Travis failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kjduling closed the pull request at:
https://github.com/apache/incubator-geode/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/154
Updated to 2.6.1 and fixed the failing unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/155
GEODE-1521 - APP_FETCH_SIZE in GFSH should not be applied to COUNT quâ¦
â¦eries
Change to search for " count(" instead of "count(*)" because 'count' can
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/154
GEODE-1470: Upgrade log4j to 2.6
Simply changes the version for the log4j dependency to 2.6 from 2.5.
You can merge this pull request into a Git repository by running:
$ git pull
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/152#discussion_r66156949
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java
---
@@ -279,7 +281,12 @@ protected Gfsh(boolean
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/151
GEODE-744: Incorrect use of APP_FETCH_SIZE in GFSH
Changed the test to be case-insensitive.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/149#discussion_r65782155
--- Diff: geode-assembly/src/main/dist/bin/gfsh.bat ---
@@ -74,14 +70,14 @@ REM )
REM Consider java is from JDK
@set TOOLS_JAR=%JAVA_HOME
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/150
Feature/geode 308
Partially addresses GEODE-308, removing several Hydra classes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/149
GEODE-1331: gfsh.bat on Windows is incorrect
* Renamed internal variable from CLASSPATH to DEPENDENCIES.
* Verified @setlocal was not altering the System environment variables
74 matches
Mail list logo
