Github user sbawaska commented on the issue:
https://github.com/apache/incubator-geode/pull/259
Hi @joeymcallister The CI failed because the new files are missing the
Apache License header. Can you please fix this and re-submit the pull request?
```
71 Unknown Licenses
Github user sbawaska commented on the issue:
https://github.com/apache/incubator-geode/pull/218
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/122#issuecomment-206641336
Yes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/122#issuecomment-205461981
+1
A minor nitpick, could you please make the support email user@?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/113#issuecomment-197623817
+1
I will merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sbawaska commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/114#discussion_r56560742
--- Diff: README.md ---
@@ -36,19 +37,18 @@ Apache Geode includes the following features:
* Cluster-wide configurations that can be persisted
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/115#issuecomment-197601802
+1
I will merge this in.
CI failed because .travis.yml file does not exist on the asf-site branch.
---
If your project is set up for it, you can reply
GitHub user sbawaska reopened a pull request:
https://github.com/apache/incubator-geode/pull/107
Updating README
- Added Anchors and links to all sections
- Added links to wiki and documentation
- Added CI status
- Headings are now h2 rather than h1
You can merge
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/93#issuecomment-189016067
+1
I will merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/93#issuecomment-186461335
I think it will be valuable to put a link to the geode website in the
README.
---
If your project is set up for it, you can reply to this email and have your
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/100#issuecomment-186387751
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/77#issuecomment-175137609
Hi Ken,
This pull request has a lot of other commits. Can you please close this and
open another pull request by following the instructions here
https
Github user sbawaska commented on the pull request:
https://github.com/apache/incubator-geode/pull/19#issuecomment-139338155
Looks good!
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sbawaska commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/13#discussion_r36257113
--- Diff:
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/ExecutionHandlerContext.java
---
@@ -179,31 +203,21 @@ public void
Github user sbawaska commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/13#discussion_r36256817
--- Diff:
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/Command.java ---
@@ -116,7 +106,8 @@ public String getStringKey
Github user sbawaska commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/13#discussion_r36256895
--- Diff:
gemfire-core/src/main/java/com/gemstone/gemfire/internal/redis/DoubleWrapper.java
---
@@ -37,12 +43,19 @@ public int compareTo(Object
16 matches
Mail list logo
