[GitHub] incubator-geode issue #171: feature/geode 33

2016-07-07 Thread markito
Github user markito commented on the issue: https://github.com/apache/incubator-geode/pull/171 @jhuynh1, @gesterzhou , @nabarunnag just included the feedback items. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] incubator-geode issue #171: feature/geode 33

2016-07-07 Thread markito
Github user markito commented on the issue: https://github.com/apache/incubator-geode/pull/171 @gesterzhou Not yet. We can definitely add to the list for 1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-geode issue #171: feature/geode 33

2016-07-07 Thread gesterzhou
Github user gesterzhou commented on the issue: https://github.com/apache/incubator-geode/pull/171 There's no lucene in example list? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] incubator-geode issue #171: feature/geode 33

2016-07-07 Thread jhuynh1
Github user jhuynh1 commented on the issue: https://github.com/apache/incubator-geode/pull/171 Some minor improvements/corrections: 1.) remove @author tag from Consumer.java 2.) The test checkIfScriptsAreExecutable runs the same line twice. I think the second line was

[GitHub] incubator-geode issue #171: feature/geode 33

2016-06-21 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/171 Hi William, Thanks for doing all of this work! This looks like a good start for examples. I have a few comments below. 1. Did you look into using the gradle