[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed

2016-08-12 Thread gracemeilen
Github user gracemeilen commented on the issue: https://github.com/apache/incubator-geode/pull/230 Checked in a fix due to a unit test failing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed

2016-08-12 Thread gracemeilen
Github user gracemeilen commented on the issue: https://github.com/apache/incubator-geode/pull/230 Updated this to use StringUtils, added unit tests to verify --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed

2016-08-11 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/230 No existing test exposed this. This is in reaction to a code analysis. Case by case, the code may or may not be doing what the developer intended because of the nature of == vs

[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed

2016-08-10 Thread metatype
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/230 Is there a test that exposes the probable bug and verifies that the issue is fixed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub