[GitHub] incubator-geode pull request #286: GEODE-2104: Fix parsing of options follow...

2016-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #286: GEODE-2104: Fix parsing of options follow...

2016-11-15 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/286 GEODE-2104: Fix parsing of options following --J You can merge this pull request into a Git repository by running: $ git pull https://github.com/jaredjstewart/incubator-geode

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

2016-11-15 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/285#discussion_r88081170 --- Diff: geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java --- @@ -0,0 +1,75 @@ +package

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

2016-11-15 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/285#discussion_r88080988 --- Diff: geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java --- @@ -0,0 +1,75 @@ +package

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

2016-11-15 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/285#discussion_r88075502 --- Diff: geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java --- @@ -0,0 +1,75 @@ +package

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

2016-11-15 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/285#discussion_r88075036 --- Diff: geode-core/src/test/java/org/apache/geode/cache/RegionNameValidationJUnitTest.java --- @@ -0,0 +1,75 @@ +package

[GitHub] incubator-geode pull request #284: Improved cleanup for UITests

2016-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/284 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #285: GEODE-1617: Regions can be created with a...

2016-11-15 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/285 GEODE-1617: Regions can be created with a variety of characters that … …are unsupported Added comprehensive test to validate region names You can merge this pull request into

[GitHub] incubator-geode pull request #284: Improved cleanup for UITests

2016-11-15 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/284 Improved cleanup for UITests UITests were failing when more than one was run because they all share a base class that was not properly cleaned up. You can merge this pull request

[GitHub] incubator-geode pull request #283: GEODE-2098: Moved gfsh history file locat...

2016-11-14 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/283 GEODE-2098: Moved gfsh history file location from .gemfire to .geode Made the code changes and added a test for the same. Following Test is failing with precheckin, but works fine

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #282: GEODE-1740: Inconsistencies with concurre...

2016-11-11 Thread gemzdude
GitHub user gemzdude opened a pull request: https://github.com/apache/incubator-geode/pull/282 GEODE-1740: Inconsistencies with concurrent clear and commit There is a possible region inconsistency if region operations such as CLEAR are performed during transaction commit

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #281: GEODE-2084 - When executing a rest api in...

2016-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #281: GEODE-2084 - When executing a rest api in...

2016-11-10 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/281 GEODE-2084 - When executing a rest api in a browser, the login page p… …resented in the browser is not setting the username/password correctly Changed

[GitHub] incubator-geode pull request #280: GEODE-1740: Potential region inconsistenc...

2016-11-08 Thread gemzdude
Github user gemzdude closed the pull request at: https://github.com/apache/incubator-geode/pull/280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #:

2016-11-07 Thread vectorijk
Github user vectorijk commented on the pull request: https://github.com/apache/incubator-geode/commit/c1216eb1817df3c6b20afbaff49ba30e76d34b44#commitcomment-19733561 @upthewaterspout I think so. Maybe `1.1.0-incubating-SNAPSHOT` makes more sense. --- If your project is set up for

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86920722 --- Diff: geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java --- @@ -50,6 +52,11 @@

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86920671 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* +

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86900866 --- Diff: geode-core/src/main/java/org/apache/geode/security/PostProcessor.java --- @@ -44,6 +47,9 @@ default void init(Properties securityProps)

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86900814 --- Diff: geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java --- @@ -409,6 +435,34 @@ public Object

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86900842 --- Diff: geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java --- @@ -87,6 +89,12 @@ Object postProcess(Object

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86900849 --- Diff: geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java --- @@ -87,6 +89,12 @@ Object postProcess(Object

[GitHub] incubator-geode pull request #280: GEODE-1740: Potential region inconsistenc...

2016-11-07 Thread gemzdude
GitHub user gemzdude opened a pull request: https://github.com/apache/incubator-geode/pull/280 GEODE-1740: Potential region inconsistency with concurrent clear during commit processing It was observed that region operations performed within a transaction were not * acquiring

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86852018 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* + *

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86852092 --- Diff: geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java --- @@ -50,6 +52,11 @@

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86848834 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* + *

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86847492 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* + *

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86836374 --- Diff: geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java --- @@ -409,6 +435,34 @@ public Object

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86819415 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* +

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86836201 --- Diff: geode-core/src/main/java/org/apache/geode/security/PostProcessor.java --- @@ -44,6 +47,9 @@ default void init(Properties securityProps)

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86836263 --- Diff: geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java --- @@ -87,6 +89,12 @@ Object

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86821510 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* +

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86836714 --- Diff: geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java --- @@ -50,6 +52,11 @@

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86820194 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* +

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86822046 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* +

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86836287 --- Diff: geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java --- @@ -87,6 +89,12 @@ Object

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86822375 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityPostProcessorTest.java --- @@ -0,0 +1,185 @@ +/* +

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-07 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/276#discussion_r86836336 --- Diff: geode-core/src/main/java/org/apache/geode/internal/security/IntegratedSecurityService.java --- @@ -409,6 +435,34 @@ public Object

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-06 Thread davinash
Github user davinash commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86684707 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-06 Thread davinash
Github user davinash commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86684704 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-06 Thread davinash
Github user davinash commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86684713 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-06 Thread davinash
Github user davinash commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86684743 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java --- @@ -1091,6

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-06 Thread davinash
Github user davinash commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86684717 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/RegionCreateFunction.java --- @@ -405,9 +408,48 @@ private

[GitHub] incubator-geode pull request #279: GEODE-1821: Adjust timing to wait for asy...

2016-11-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #279: GEODE-1821: Adjust timing to wait for asy...

2016-11-03 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/279 GEODE-1821: Adjust timing to wait for async thread Increased timeout for waiting on aysnc thread termination. The wait timeout in DUnit test did not allow sufficient margin over the time

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86040503 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java --- @@ -1091,6

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86041266 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java --- @@ -1091,6

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86039620 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/RegionCreateFunction.java --- @@ -405,9 +408,48 @@ private

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86039193 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #:

2016-11-01 Thread upthewaterspout
Github user upthewaterspout commented on the pull request: https://github.com/apache/incubator-geode/commit/c1216eb1817df3c6b20afbaff49ba30e76d34b44#commitcomment-1965 @vectorijk Shoot, I just updated the version to 1.0.0-incubating (no SNAPSHOT) to get the build to pass before I

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86038578 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86033727 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86033253 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -907,6 +903,31

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-11-01 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/278#discussion_r86031904 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java --- @@ -31,19 +31,13 @@

[GitHub] incubator-geode pull request #277: GEODE-1098: Fix gfsh.bat error with defau...

2016-10-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #:

2016-10-31 Thread vectorijk
Github user vectorijk commented on the pull request: https://github.com/apache/incubator-geode/commit/c1216eb1817df3c6b20afbaff49ba30e76d34b44#commitcomment-19630739 @upthewaterspout Should we update version number to `1.1.0-incubating-SNAPSHOT`? Also, I have a question about

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

2016-10-29 Thread davinash
GitHub user davinash opened a pull request: https://github.com/apache/incubator-geode/pull/278 Feature/geode 1896 unable to specify a PartitionResolver in gfsh GEODE-1896: Added a argument in Create Region to specify Partition Resolver. You can merge this pull request into a

[GitHub] incubator-geode pull request #261: Added pulse UI tests to the combined test...

2016-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #274: Add a timeout to webdriver so that UITest...

2016-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #275: [GEODE-1871] - Updating and cleaning up D...

2016-10-28 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/275#discussion_r85631878 --- Diff: docker/Dockerfile --- @@ -14,25 +14,34 @@ # See the License for the specific language governing permissions and # limitations

[GitHub] incubator-geode pull request #277: GEODE-1098: Fix gfsh.bat error with defau...

2016-10-28 Thread mmurdoch
GitHub user mmurdoch opened a pull request: https://github.com/apache/incubator-geode/pull/277 GEODE-1098: Fix gfsh.bat error with default Java installation Paths to JAR dependencies quoted to prevent spaces from causing error You can merge this pull request into a Git repository

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-10-28 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/276 GEODE-1993: postprocess region/key Add post processing to the GET {region}/{key..key} endpoint precheckin running You can merge this pull request into a Git repository by running:

[GitHub] incubator-geode pull request #273: Feature/geode 1983

2016-10-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #275: [GEODE-1871] - Updating and cleaning up D...

2016-10-28 Thread markito
GitHub user markito opened a pull request: https://github.com/apache/incubator-geode/pull/275 [GEODE-1871] - Updating and cleaning up Dockerfile for Geode 1.0.0 Removed unused files. Updated JDK version and Docker tag for 1.0.0. You can merge this pull request into a Git

[GitHub] incubator-geode pull request #274: Add a timeout to webdriver so that UITest...

2016-10-27 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/274 Add a timeout to webdriver so that UITest doesn't hang for hours if i… …t can't load the page. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-geode pull request #273: Feature/geode 1983

2016-10-27 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/273#discussion_r85375614 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java --- @@ -42,6 +44,7 @@ static

[GitHub] incubator-geode pull request #273: Feature/geode 1983

2016-10-27 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/273 Feature/geode 1983 Updated the spring security configuration to support the Swagger2 resources. Precheckin successful. You can merge this pull request into a Git repository by

[GitHub] incubator-geode pull request #272: GEODE-1983: Swagger is broken with integr...

2016-10-27 Thread kjduling
Github user kjduling closed the pull request at: https://github.com/apache/incubator-geode/pull/272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #272: GEODE-1983: Swagger is broken with integr...

2016-10-27 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/272 GEODE-1983: Swagger is broken with integrated security Updated the spring security configuration to support the Swagger2 resources. You can merge this pull request into a Git repository

[GitHub] incubator-geode pull request #271: Feature/geode 2014

2016-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #271: Feature/geode 2014

2016-10-25 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/271#discussion_r84983163 --- Diff: LICENSE --- @@ -329,8 +302,6 @@ Apache Geode bundles the following files under the MIT license: Copyright (c) 2011 Sencha Inc.

[GitHub] incubator-geode pull request #271: Feature/geode 2014

2016-10-25 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/271#discussion_r84983273 --- Diff: geode-assembly/src/test/resources/expected_jars.txt --- @@ -37,10 +37,6 @@ jline jna --- End diff -- Why is this file

[GitHub] incubator-geode pull request #271: Feature/geode 2014

2016-10-25 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/271 Feature/geode 2014 Updates to the LICENSE file You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/incubator-geode

Re: [GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-25 Thread Anthony Baker
Looks like the only common (previous) dependency is the core jquery library which is used by pulse and the geode-site. > On Oct 25, 2016, at 11:27 AM, Kevin Duling wrote: > > None of these are related to pulse, that lives > in geode-web, not geode-web-api.

Re: [GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-25 Thread Kevin Duling
All of those files are the old Swagger-UI, replaced by the following gradle entry in geode-web-api. There is no reason we should be bundling the swagger ui github project in to Geode. I'm not even sure this old UI would work with the Swagger2 API. None of these are related to pulse, that lives

Re: [GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-25 Thread Anthony Baker
I missed these changes in the original pull request: delete mode 100644 geode-web-api/src/main/webapp/docs/css/reset.css delete mode 100644 geode-web-api/src/main/webapp/docs/css/screen.css delete mode 100755 geode-web-api/src/main/webapp/docs/images/explorer_icons.png delete mode 100755

[GitHub] incubator-geode pull request #270: GEODE-2014: Upgrade Swagger libraries

2016-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #245: native-client-software-grant - ClientMeta...

2016-10-25 Thread fdaniel7
Github user fdaniel7 commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/245#discussion_r84839367 --- Diff: geode-client-native/src/cppcache/impl/ClientMetadataService.cpp --- @@ -1,925 +1 @@

[GitHub] incubator-geode pull request #267: Feature/geode 2015

2016-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #270: GEODE-2014: Upgrade Swagger libraries

2016-10-24 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/270 GEODE-2014: Upgrade Swagger libraries Updated expected jars list after swagger update You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-geode pull request #269: GEODE-2015: Fix docs paths

2016-10-24 Thread joeymcallister
Github user joeymcallister closed the pull request at: https://github.com/apache/incubator-geode/pull/269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-21 Thread kjduling
Github user kjduling commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/265#discussion_r84528366 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java --- @@ -0,0 +1,57 @@ +/* + *

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-21 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/265#discussion_r84500905 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java --- @@ -0,0 +1,57 @@ +/* + *

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-21 Thread jinmeiliao
Github user jinmeiliao commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/265#discussion_r84501406 --- Diff: geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/FunctionAccessController.java --- @@ -93,8 +93,7 @@

[GitHub] incubator-geode pull request #266: Add user guide doc to website

2016-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #267: Feature/geode 2015

2016-10-20 Thread joeymcallister
GitHub user joeymcallister opened a pull request: https://github.com/apache/incubator-geode/pull/267 Feature/geode 2015 Changes to docs and site directories for adding the documentation/user guide to the Geode website. You can merge this pull request into a Git repository by

[GitHub] incubator-geode pull request #268: Spotless plugin with google style

2016-10-20 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/268 Spotless plugin with google style - Enabled spotless plugin to enforce code formatting - Switched provided templates for Eclipse and Intellij formatters to those form the

Re: [GitHub] incubator-geode pull request #266: Add user guide doc to website

2016-10-20 Thread Swapnil Bawaskar
Hi Joey, Travis is not configured to work on the asf-site branch, so you can ignore the failure. Thanks! Swapnil. On Thu, Oct 20, 2016 at 1:44 PM, Joey McAllister wrote: > Hi, > > The pull request below is to push the contributed docs content to the > website. I

[GitHub] incubator-geode pull request #266: Add user guide doc to website

2016-10-20 Thread joeymcallister
GitHub user joeymcallister opened a pull request: https://github.com/apache/incubator-geode/pull/266 Add user guide doc to website Added the user guide built using `geode-docs` and `geode-book` to `geode-site/content/`. Built and reviewed the site locally. Related docs/website

[GitHub] incubator-geode pull request #245: native-client-software-grant - ClientMeta...

2016-10-20 Thread pivotal-jbarrett
Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/245#discussion_r84287364 --- Diff: geode-client-native/src/cppcache/impl/ClientMetadataService.cpp --- @@ -1,925 +1 @@

[GitHub] incubator-geode pull request #264: Feature/geode 538

2016-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/264 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #263: GEODE-1983: Swagger is broken with integr...

2016-10-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-19 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/265#discussion_r84112416 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java --- @@ -94,7 +94,7 @@ public static

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-19 Thread metatype
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/265#discussion_r84111969 --- Diff: gradle/dependency-versions.properties --- @@ -100,8 +100,8 @@ spring-tx.version = 4.3.2.RELEASE springframework.version =

[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-19 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/265 GEODE-2014: Upgrade Swagger libraries You can merge this pull request into a Git repository by running: $ git pull https://github.com/kjduling/incubator-geode feature/GEODE-2014

[GitHub] incubator-geode pull request #264: Feature/geode 538

2016-10-19 Thread pdxrunner
GitHub user pdxrunner opened a pull request: https://github.com/apache/incubator-geode/pull/264 Feature/geode 538 Changes have been reviewed at https://reviews.apache.org/r/52891/ You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-geode pull request #263: GEODE-1983: Swagger is broken with integr...

2016-10-18 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/263 GEODE-1983: Swagger is broken with integrated security This required a simple configuration change. The swagger endpoints needed to be marked as permitAll so that the resources could be

[GitHub] incubator-geode pull request #262: GEODE-2004: Create/update/delete query th...

2016-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

  1   2   3   4   5   6   7   8   >