Re: Javadoc warnings

2016-07-22 Thread Jinmei Liao
Cleared these javadoc warnings on develope. thanks! On Thu, Jul 21, 2016 at 4:38 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: > Hmmm... > > Can you please get your team in check I get the following since > updating :P :D :D :D > > > /Users/ukohlmeyer/

Re: Javadoc warnings

2016-07-21 Thread Udo Kohlmeyer
/GeodeSecurityUtil.java:412: warning - @return tag has no arguments. --Udo On 20/07/2016 3:37 PM, Kirk Lund wrote: Reminder: please watch for javadoc warnings in your code before committing. :geode-core:javadoc /Users/klund/dev/gemfire/open/geode-core/src/main/java/com/gemstone/gemfire/distributed/internal

Re: Javadoc warnings

2016-07-20 Thread Bruce Schuchardt
The @guarded.By in GMSMembershipManager came from the old JGroupsMembershipManager and has been there for a very long time. Do we need to do a search and scrub out all of these tags? Le 7/20/2016 à 3:37 PM, Kirk Lund a écrit : Reminder: please watch for javadoc warnings in your code before

New javadoc warnings

2016-02-08 Thread Kirk Lund
Someone introduced new javadoc warnings. I'm not sure which commit caused this. :pivotalgf-assembly:docsC:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\FailedSynchronizationException.java:33: warning - Tag @see: reference not found

Review Request 43259: GEODE-922: Fix javadoc warnings in RetryRule

2016-02-05 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43259/ --- Review request for geode, Anthony Baker and Jinmei Liao. Bugs: GEODE-922

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-02-01 Thread Kirk Lund
> On Jan. 30, 2016, 6:43 p.m., Anthony Baker wrote: > > gemfire-joptsimple/src/main/java/joptsimple/internal/AbbreviationMap.java, > > line 57 > > > > > > Any reason to remove this link? http://www.perldoc.com/ and

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-01-29 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42991/#review117073 --- Apparently the warning about javax.transaction-api can be

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-01-29 Thread Kirk Lund
Please review this (I didn't specify any specific reviewers). I'd like to get this merged to develop sooner than later since it touches so many files and I'd like to avoid merge conflicts if possible. You can also checkout feature/GEODE-805 if you want to build or edit the changes.

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-01-29 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42991/ --- (Updated Jan. 30, 2016, 12:58 a.m.) Review request for geode. Changes

Re: Review Request 42991: GEODE-805: Fix javadoc warnings

2016-01-29 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42991/ --- (Updated Jan. 30, 2016, 12:44 a.m.) Review request for geode. Changes