Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-28 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/#review144013 --- Ship it! Ship It! - Darrel Schneider On July 28, 2016, 1:44

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-28 Thread Eric Shu
> On July 22, 2016, 8:33 p.m., Swapnil Bawaskar wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java, > > line 619 > > > > > > As implemented this method always returns

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-28 Thread Eric Shu
> On July 22, 2016, 8:31 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RegionQueue.java, > > line 50 > > > > > > Can you check all the callers of this and make sure

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-28 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/ --- (Updated July 28, 2016, 8:44 p.m.) Review request for geode, Darrel Schneider

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-22 Thread Swapnil Bawaskar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/#review143269 ---

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-22 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/#review143266 ---

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-22 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/ --- (Updated July 22, 2016, 6:26 p.m.) Review request for geode, Darrel Schneider

Re: Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-20 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/#review142966 ---

Review Request 50242: GEODE-1678: Fix offheap memory leak in serial wan gateway

2016-07-20 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50242/ --- Review request for geode, Darrel Schneider and Swapnil Bawaskar. Bugs: