Re: Review Request 51385: GEODE-900 test endup uding old cache

2016-08-24 Thread Bruce Schuchardt
> On Aug. 24, 2016, 8:27 p.m., Bruce Schuchardt wrote: > > While it's okay to synchronize like that in checkExistingCache() I think it > > might be more appropriate to synchronize on CacheFactory.class in > > basicCreate() and fold the checkExistingClass() method into that method > > since

Re: Review Request 51385: GEODE-900 test endup uding old cache

2016-08-24 Thread Hitesh Khamesra
> On Aug. 24, 2016, 8:27 p.m., Bruce Schuchardt wrote: > > While it's okay to synchronize like that in checkExistingCache() I think it > > might be more appropriate to synchronize on CacheFactory.class in > > basicCreate() and fold the checkExistingClass() method into that method > > since

Re: Review Request 51385: GEODE-900 test endup uding old cache

2016-08-24 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51385/#review146705 --- While it's okay to synchronize like that in checkExistingCache()

Re: Review Request 51385: GEODE-900 test endup uding old cache

2016-08-24 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51385/#review146696 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 24, 2016, 6:30

Review Request 51385: GEODE-900 test endup uding old cache

2016-08-24 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51385/ --- Review request for geode, Bruce Schuchardt and Darrel Schneider. Repository: