Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-10 Thread Darrel Schneider
> On Nov. 9, 2016, 3:40 p.m., Anthony Baker wrote: > > Do we want to check in generated code? Should we hook this into the build > > script? I filed GEODE-2093 for this issue - Darrel --- This is an automatically generated e-mail. To

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-10 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/#review155611 --- Ship it! Ship It! - Ken Howe On Nov. 10, 2016, 1:01 a.m., Da

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-09 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/ --- (Updated Nov. 9, 2016, 5:01 p.m.) Review request for geode, Eric Shu and Ken Ho

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-09 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/#review155520 --- +0 to Anthony's sugestion. Not checking in generated codesounds li

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-09 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/#review155516 --- Do we want to check in generated code? Should we hook this into t

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-09 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/#review155512 --- Ship it! Ship It! - Eric Shu On Nov. 9, 2016, 11:11 p.m., Da

Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-09 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/ --- Review request for geode, Eric Shu and Ken Howe. Bugs: GEODE-1785 https://i