Is there a way to make the build break if we have broken javadocs? I tried
to enable this within gradle but gradle then enforces javadocs correctness
on all 3rd party libraries as well as our source code. Maybe some sort of
3rd party mechanism (like spotless) might be able to limit itself to just
Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/274
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
DiskSpaceLimitIntegrationTest is an IntegrationTest, not a DistributedTest:
@Category(IntegrationTest.class)
public class DiskSpaceLimitIntegrationTest {
...which means that it runs in a forked JVM in which only one testcase is
executed, so there are no previously run tests.
How did you found
Anyone know why the job output didn't include the test failures like it
usually does?
-Kirk
-- Forwarded message --
From: Apache Jenkins Server
Date: Fri, Oct 28, 2016 at 8:54 AM
Subject: Build failed in Jenkins: Geode-nightly #636
To:
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53268/#review154140
---
Ship it!
Ship It!
- Eric Shu
On Oct. 28, 2016, 5:24 p.m.,
Someone should look into this test and the previously run Auth tests to
see what caused this OOME
org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.sameKeepsOneFile
Github user jaredjstewart commented on the issue:
https://github.com/apache/incubator-geode/pull/274
precheckin passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
I'm going to revert GEODE-2012 because these tests seem to be
intermittently running out of memory. Unfortunately I'm not comfortable
leaving the bug fix in without any tests confirming the bug and fix, so the
entire commit will be reverted.
Thanks,
Kirk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53268/#review154141
---
Ship it!
Ship It!
- Ken Howe
On Oct. 28, 2016, 5:24 p.m.,
GitHub user kjduling opened a pull request:
https://github.com/apache/incubator-geode/pull/276
GEODE-1993: postprocess region/key
Add post processing to the GET {region}/{key..key} endpoint
precheckin running
You can merge this pull request into a Git repository by running:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53274/
---
Review request for geode, Kevin Duling and Kirk Lund.
Repository: geode
GitHub user mmurdoch opened a pull request:
https://github.com/apache/incubator-geode/pull/277
GEODE-1098: Fix gfsh.bat error with default Java installation
Paths to JAR dependencies quoted to prevent spaces from causing error
You can merge this pull request into a Git repository
GitHub user markito opened a pull request:
https://github.com/apache/incubator-geode/pull/275
[GEODE-1871] - Updating and cleaning up Dockerfile for Geode 1.0.0
Removed unused files. Updated JDK version and Docker tag for 1.0.0.
You can merge this pull request into a Git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53268/
---
Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53243/#review154186
---
Ship it!
Ship It!
- Dan Smith
On Oct. 27, 2016, 10:38 p.m.,
Github user upthewaterspout commented on the issue:
https://github.com/apache/incubator-geode/pull/277
+1 Looks good to me. I'll merge this. Thanks!
The travis failure appears to be code checked in on develop with formatting
changes. I'm looking into that, but it's not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53274/#review154187
---
Ship it!
Ship It!
- Kevin Duling
On Oct. 28, 2016, 2:49
Github user jinmeiliao commented on the issue:
https://github.com/apache/incubator-geode/pull/276
A few things:
1. In your RestSecurityPostProcessorTest, in the before method, you can get
ahold of the region you created and pre populate the regions with a few keys
and values,
I am seeing build failures with:
***
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':geode-core:spotlessJavaCheck'.
> Format violations were found. Run 'gradlew spotlessApply' to fix them.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53243/#review154191
---
Ship it!
Ship It!
- William Markito
On Oct. 27, 2016, 10:38
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-geode/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user metatype commented on the issue:
https://github.com/apache/incubator-geode/pull/277
Thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/275#discussion_r85631878
--- Diff: docker/Dockerfile ---
@@ -14,25 +14,34 @@
# See the License for the specific language governing permissions and
# limitations
25 matches
Mail list logo