Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/ --- Review request for geode, Darrel Schneider, Hitesh Khamesra, and Udo Kohlmeyer.

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-10 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53632/#review155611 --- Ship it! Ship It! - Ken Howe On Nov. 10, 2016, 1:01 a.m., Da

Spring Data Geode 1.0.0-INCUBATING-RELEASE available!

2016-11-10 Thread John Blum
I am happy to announce the release of *Spring Data* for *Apache Geode* 1.0.0-incubating, which marks the first, official GA release of *Apache Geode* as well as the first GA release of SDG to match. One of the key themes of this release is *security*. Currently, *Apache Geode* builds on *Apache S

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-10 Thread Darrel Schneider
> On Nov. 9, 2016, 3:40 p.m., Anthony Baker wrote: > > Do we want to check in generated code? Should we hook this into the build > > script? I filed GEODE-2093 for this issue - Darrel --- This is an automatically generated e-mail. To

[GitHub] incubator-geode pull request #281: GEODE-2084 - When executing a rest api in...

2016-11-10 Thread kjduling
GitHub user kjduling opened a pull request: https://github.com/apache/incubator-geode/pull/281 GEODE-2084 - When executing a rest api in a browser, the login page p… …resented in the browser is not setting the username/password correctly Changed RestSecurityConfiguration

[GitHub] incubator-geode issue #281: GEODE-2084 - When executing a rest api in a brow...

2016-11-10 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/281 Precheckin is running --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Where should geode example code live

2016-11-10 Thread Kirk Lund
We have some example code that's not in geode-examples. geode-core-1.0.0-incubating.jar currently contains this package with examples: org.geode.gemfire.security.templates Given that template means something a bit different from example, I'd like to rename this package to examples. Is this accept

Re: Spring Data Geode 1.0.0-INCUBATING-RELEASE available!

2016-11-10 Thread Kirk Lund
Great news and awesome job John! I look forward to buying you a beer to celebrate. -Kirk On Thu, Nov 10, 2016 at 10:15 AM, John Blum wrote: > I am happy to announce the release of *Spring Data* for *Apache Geode* > 1.0.0-incubating, which marks the first, official GA release of *Apache > Geode

Re: Where should geode example code live

2016-11-10 Thread Jinmei Liao
+1 for both renaming it now and moving it to a separate module going forward. On Thu, Nov 10, 2016 at 10:58 AM, Kirk Lund wrote: > We have some example code that's not in geode-examples. > geode-core-1.0.0-incubating.jar currently contains this package with > examples: > > org.geode.gemfire.secu

Re: Where should geode example code live

2016-11-10 Thread Kevin Duling
+1 Shouldn't that be org.apache.geode.security.examples? On Thu, Nov 10, 2016 at 11:03 AM, Jinmei Liao wrote: > +1 for both renaming it now and moving it to a separate module going > forward. > > On Thu, Nov 10, 2016 at 10:58 AM, Kirk Lund wrote: > > > We have some example code that's not in g

Re: Where should geode example code live

2016-11-10 Thread Kirk Lund
Yep! Replace "gemfire" with "geode" On Thu, Nov 10, 2016 at 11:07 AM, Kevin Duling wrote: > +1 > > Shouldn't that be org.apache.geode.security.examples? > > On Thu, Nov 10, 2016 at 11:03 AM, Jinmei Liao wrote: > > > +1 for both renaming it now and moving it to a separate module going > > forwar

Re: Where should geode example code live

2016-11-10 Thread Swapnil Bawaskar
+1 On Thu, Nov 10, 2016 at 11:12 AM, Kirk Lund wrote: > Yep! Replace "gemfire" with "geode" > > On Thu, Nov 10, 2016 at 11:07 AM, Kevin Duling wrote: > > > +1 > > > > Shouldn't that be org.apache.geode.security.examples? > > > > On Thu, Nov 10, 2016 at 11:03 AM, Jinmei Liao wrote: > > > > > +1

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/#review155633 --- Ship it! Ship It! - Darrel Schneider On Nov. 10, 2016, 8:47

Re: Spring Data Geode 1.0.0-INCUBATING-RELEASE available!

2016-11-10 Thread Udo Kohlmeyer
Nice one John!! I look forward to seeing the Spring Security integration as well. --Udo On 11/11/16 5:15 am, John Blum wrote: I am happy to announce the release of /Spring Data/ for /Apache Geode/1.0.0-incubating, which marks the first, official GA release of /Apache Geode/ as well as the fi

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/#review155638 --- geode-core/src/main/java/org/apache/geode/internal/cache/Abstract

Review Request 53657: GEODE-2091: Do not return false when containsValueForKey call failed in transaction due to BucketNotFoundException

2016-11-10 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53657/ --- Review request for geode, anilkumar gingade, Darrel Schneider, and Swapnil Bawas

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Bruce Schuchardt
> On Nov. 10, 2016, 8:21 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionEntry.java, > > lines 170-172 > > > > > > I think this overloaded method is a little con

Re: Review Request 53657: GEODE-2091: Do not return false when containsValueForKey call failed in transaction due to BucketNotFoundException

2016-11-10 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53657/#review155649 --- Ship it! Ship It! - Darrel Schneider On Nov. 10, 2016, 12:59

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/ --- (Updated Nov. 10, 2016, 9:47 p.m.) Review request for geode, Darrel Schneider,

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/#review155653 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 10, 2016, 9:47 p.m

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

2016-11-10 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53557/#review155654 --- Ship it! Ship It! - Udo Kohlmeyer On Nov. 7, 2016, 10:13 p.m

Re: Where should geode example code live

2016-11-10 Thread Jacob Barrett
+1 On Thu, Nov 10, 2016 at 11:22 AM Swapnil Bawaskar wrote: > +1 > > On Thu, Nov 10, 2016 at 11:12 AM, Kirk Lund wrote: > > > Yep! Replace "gemfire" with "geode" > > > > On Thu, Nov 10, 2016 at 11:07 AM, Kevin Duling > wrote: > > > > > +1 > > > > > > Shouldn't that be org.apache.geode.security

Re: Where should geode example code live

2016-11-10 Thread Udo Kohlmeyer
+1 On 11/11/16 9:13 am, Jacob Barrett wrote: +1 On Thu, Nov 10, 2016 at 11:22 AM Swapnil Bawaskar wrote: +1 On Thu, Nov 10, 2016 at 11:12 AM, Kirk Lund wrote: Yep! Replace "gemfire" with "geode" On Thu, Nov 10, 2016 at 11:07 AM, Kevin Duling wrote: +1 Shouldn't that be org.apache.g

[GitHub] incubator-geode issue #276: GEODE-1993: postprocess region/key

2016-11-10 Thread kjduling
Github user kjduling commented on the issue: https://github.com/apache/incubator-geode/pull/276 Precheckin successful --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] incubator-geode pull request #281: GEODE-2084 - When executing a rest api in...

2016-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Review Request 53661: GEODE-2094 Update admin/dev REST API documentation

2016-11-10 Thread Karen Miller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53661/ --- Review request for geode, Dave Barnes, Jinmei Liao, Joey McAllister, and Kevin D

[GitHub] incubator-geode pull request #276: GEODE-1993: postprocess region/key

2016-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-geode/pull/276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: Review Request 53661: GEODE-2094 Update admin/dev REST API documentation

2016-11-10 Thread Dave Barnes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53661/#review155668 --- I noticed one variation to the pattern: In geode-docs/rest_apps/s

Re: Review Request 53661: GEODE-2094 Update admin/dev REST API documentation

2016-11-10 Thread Karen Miller
> On Nov. 10, 2016, 11:48 p.m., Dave Barnes wrote: > > I noticed one variation to the pattern: In > > geode-docs/rest_apps/setup_config.html.md.erb at line 100, did you miss one > > conversion of start-dev-rest-api to start-rest-api, or was this intentional? Good catch. I'll append a fix for

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #438 has FAILED (2 tests failed). Change made by John Blum.

2016-11-10 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #438 failed. --- This was manually triggered by John Blum. 2/1570 tests failed. https://build.spring.io/browse/SG