Re: GMSJoinLeaveJUnitTest format is broken?

Sent that too soon! I think everyone should always run ./gradlew build before pushing changes to avoid breaking the build. I'm not sure what the solution is for spotless, but we should be checking things before pushing them. One thing to consider is adding a pre-push hook to force a build to run

GMSJoinLeaveJUnitTest format is broken?

* What went wrong: Execution failed for task ':geode-core:spotlessJavaCheck'. > Format violations were found. Run 'gradlew spotlessApply' to fix them. ../../geode/geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java * Try: Run with

Re: GMSJoinLeaveJUnitTest format is broken?

Everyone should always run ./gradlew On Mon, Nov 14, 2016 at 10:35 AM, Bruce Schuchardt wrote: > This is fixed now. I will not apologize for breaking the build though. I > formatted the code that I checked in with the provided formatter > configuration for Idea and

Re: GMSJoinLeaveJUnitTest format is broken?

This is fixed now. I will not apologize for breaking the build though. I formatted the code that I checked in with the provided formatter configuration for Idea and that should pass the spotlessCheck task. We should turn off spotlessCheck until the IDE formatters conform to the