Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44924/#review123915 --- Ship it! Ship It! - Dan Smith On March 16, 2016, 7:53 p.m.,

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread anilkumar gingade
> On March 16, 2016, 9:51 p.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java, > > line 2583 > > > > > > Just quick question..I see

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44924/#review124041 ---

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread anilkumar gingade
> On March 17, 2016, 4:23 p.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientProxy.java, > > line 2583 > > > > > > This function is in

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44924/#review124046 --- Ship it! Interesting that we clear out the ack list when

Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44924/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh,

Re: Review Request 44924: GEODE-934: CI failure: DurableClientSimpleDUnitTest.testReadyForEventsNotCalledImplicitlyWithCacheXML.

2016-03-19 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44924/#review123938 ---