Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-21 Thread Jianxia Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/#review129919 --- Ship it! Ship It! - Jianxia Chen On April 21, 2016, 1:58

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-21 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/#review129912 --- Ship it! Ship It! - Bruce Schuchardt On April 21, 2016,

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-20 Thread Udo Kohlmeyer
> On April 20, 2016, 10:45 p.m., Bruce Schuchardt wrote: > > Looks okay but using keepers would be safer. When a locator starts, for > > instance, it consumes more than 1 tcp/ip port so it might use one of the > > others that you got from getRandomAvailableTcpPorts(). Using Keepers is a

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-20 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/ --- (Updated April 21, 2016, 1:58 a.m.) Review request for geode, Bruce

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-20 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/#review129834 --- Ship it! Ship It! - Hitesh Khamesra On April 20, 2016,

Re: Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-20 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/#review129833 --- Looks okay but using keepers would be safer. When a locator

Review Request 46457: GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort invocations

2016-04-20 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/ --- Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen.