[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_37198 ]
Vadim Pesochinskiy commented on AMQ-855:
I think you are right.
Add support for prefetchSize = 0
Key:
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36926 ]
Vadim Pesochinskiy commented on AMQ-855:
Oh! there are too many attachments now. Latest addition is:
PrefetchSubscription.java.patch3
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36898 ]
Hiram Chirino commented on AMQ-855:
---
Thanks Vadim,
patch applied in trunk rev 439804.
Test case passes without error.
Add support for prefetchSize = 0
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36892 ]
Hiram Chirino commented on AMQ-855:
---
'm going to start looking into it today. I may not use the
DataResponse to return the message right away. I think I would
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36894 ]
Vadim Pesochinskiy commented on AMQ-855:
OK. I will take a look at it and the unit tests. Thanks.
Add support for prefetchSize = 0
Hi!
Is there any chance someone can give me a rough estimate of when this issue
can be looked at. I would really appreciate if someone reviewed the patch
and told me if there are issues with it. Right now I have time to resolve
them. Thanks.
- Vadim.
--
View this message in context:
Hello!
Is there anything I can do to move forward with this patch? Thanks.
--
View this message in context:
http://www.nabble.com/-jira--Created%3A-%28AMQ-855%29-Add-support-for-prefetchSize-%3D-0-tf2035055.html#a5835695
Sent from the ActiveMQ - Dev forum at Nabble.com.
I submitted a patch yesterday and now the issue is resolved. Is that the
feedback for my patch :-) ? Thanks.
--
View this message in context:
http://www.nabble.com/-jira--Created%3A-%28AMQ-855%29-Add-support-for-prefetchSize-%3D-0-tf2035055.html#a5817788
Sent from the ActiveMQ - Dev forum at
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36782 ]
Vadim Pesochinskiy commented on AMQ-855:
James,
I added implementation of pulling consumer whereby pullMessage() returns a
response. Could you please
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36716 ]
james strachan commented on AMQ-855:
Andrew I just commented on this thread on why a prefetch of 1 is the lowest
possible value to have while still fully
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36718 ]
james strachan commented on AMQ-855:
BTW just to be absolutely clear - here's how I think we should fix Vadim's use
case.
If we had full support for priority
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36730 ]
Vadim Pesochinskiy commented on AMQ-855:
James Hiram,
I understand that you are trying to keep the scope of AMQ in check and I
appreciate this as I
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36736 ]
Vadim Pesochinskiy commented on AMQ-855:
e.g. if we did implement prefetch of zero - which means don't deliver a
message to a consumer at all -
unless
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36737 ]
Maxim Fateev commented on AMQ-855:
--
I think the failure scenario (slow consumer) is very common one and should be
supported by ActiveMQ. The root cause of the
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36738 ]
Vadim Pesochinskiy commented on AMQ-855:
#1. I thought that pending holds references, not messages. When message is
actually dispatched it will become
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36739 ]
Maxim Fateev commented on AMQ-855:
--
#1. I wasn't presize. Yes it holds references. But it doesn't really matter as
these references are locked to the particular
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36711 ]
Hiram Chirino commented on AMQ-855:
---
I don't think this is a valid need.
If each server/worker thread only creates 1 consumer with a prefetch of 1 then
the jobs
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36713 ]
Andrew Lusk commented on AMQ-855:
-
Hiram, I don't really understand your comments here. There is a huge need for
this. A push model just isn't appropriate for
[
https://issues.apache.org/activemq/browse/AMQ-855?page=comments#action_36714 ]
Vadim Pesochinskiy commented on AMQ-855:
I agree this functionality is essential for slow consumers. I do not see the
hacking part in it. If prefetchSize
19 matches
Mail list logo