The patch to me looks like a safe enough fix and its assuring that
tck didn't blow up. So +0 from me. I would have to react to this
change as well, but the impact for me should be minimal. For the
other subtasks you created (1990, 1991), what are the plan for those?
- sachin
On May 5,
On May 5, 2006, at 5:10 AM, Sachin Patel wrote:
The patch to me looks like a safe enough fix and its assuring that
tck didn't blow up. So +0 from me. I would have to react to this
change as well, but the impact for me should be minimal. For the
other subtasks you created (1990, 1991),
Change configId to moduleId in xml
--
Key: GERONIMO-1988
URL: http://issues.apache.org/jira/browse/GERONIMO-1988
Project: Geronimo
Type: Sub-task
Security: public (Regular issues)
Versions: 1.0
Reporter: Dain
Dain,
I know we've talked about this on Irc but there didn't seem to be consensus (I think djencks had
some concerns). Could you summarize the change in a note? I know that you don't want to end up in
an embroiled debate on the issue but I'm concerned that this will set us back.
The grumpy
I am going to create a patch. If it works (and is small), we can
discuss committing it.
-dain
On May 4, 2006, at 2:00 PM, Matt Hogstrom wrote:
Dain,
I know we've talked about this on Irc but there didn't seem to be
consensus (I think djencks had some concerns). Could you summarize
Thanks bubba (that's Southern for Dain...don't ask me how they came up with
that)
Dain Sundstrom wrote:
I am going to create a patch. If it works (and is small), we can
discuss committing it.
-dain
On May 4, 2006, at 2:00 PM, Matt Hogstrom wrote:
Dain,
I know we've talked about this on
The patch is done. It was very easy since we transfer the
environment data from xmlbeans into our own pojo representation.
This means I only needed to update the marshaling code. For that, I
just used intellij to rename the elements in xmlbean generated code.
After that is was a matter
