MdbBuilder sets the Listener Type incorrectly causing NPEs at initialization
----------------------------------------------------------------------------

         Key: GERONIMO-824
         URL: http://issues.apache.org/jira/browse/GERONIMO-824
     Project: Geronimo
        Type: Bug
  Components: OpenEJB  
    Versions: 1.0-M4, 1.0-M5, 1.0, 1.1    
    Reporter: Matt Hogstrom


org.openejb.deployment.MdbBuilder.java assigns null to the ListenerType if the 
type cannot be determined.  This causes runtime errors that are manifested in 
the MdbContainerBuilder as Null Pointer Exceptions.  

This fix assigns a type of javax.jms.MessageListener to the interface type as a 
default.

Index: MdbBuilder.java
===================================================================
RCS file: 
/home/projects/openejb/scm/openejb/modules/openejb-builder/src/java/org/openejb/deployment/MdbBuilder.java,v
retrieving revision 1.21
diff -r1.21 MdbBuilder.java
173c173,179
<         
builder.setEndpointInterfaceName(OpenEJBModuleBuilder.getJ2eeStringValue(messageDrivenBean.getMessagingType()));
---
>         String messageInterfaceType = null;
>         if (messageDrivenBean.isSetMessagingType()) {
>             messageInterfaceType = 
> messageDrivenBean.getMessagingType().getStringValue().trim();
>         } else {
>             messageInterfaceType = "javax.jms.MessageListener";
>         }
>         builder.setEndpointInterfaceName(messageInterfaceType);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to