Guillaume,
Just a few questions/remarks about the CheckStyle rules:
- a lot of the code seems to be written with a line length of 132 in
mind, why change it to 120?
- the rules don't allow using this way of creating setters
public void setMBeanServer(MBeanServer mbeanServer) {
Gert,
I checked in the change of the line length to 140.
Thomas
Gert Vanthienen wrote:
Guillaume,
Just a few questions/remarks about the CheckStyle rules:
- a lot of the code seems to be written with a line length of 132 in
mind, why change it to 120?
- the rules don't allow using this
Guillaume,
You're right what the setter syntax is concerned. The error message is
a bit confusing (local variable 'mbeanServer' hides a field or something
like that), but once the correct case is used to match the property to
the setter, CheckStyle does allow this syntax...
Gert
Guillaume
Cool, glad you confirm that. This is something that I have
crossed while working on the SEs, but had not took the time
to detail.
On 4/12/07, Gert Vanthienen [EMAIL PROTECTED] wrote:
Guillaume,
You're right what the setter syntax is concerned. The error message is
a bit confusing (local
Thomas,
Thank you for the quick response! This makes a serious difference in
the effort to make the binding components CheckStyle-compliant
Gert
Thomas TERMIN wrote:
Gert,
I checked in the change of the line length to 140.
Thomas
Gert Vanthienen wrote:
Guillaume,
Just a few
Hi everybody !
I have recently checked in lots of changes. These are mostly
code conventions fixes. Let me explain.
I've started to add checkstyle and pmd checks at build time.
For those who do not know these tools, checkstyle
(http://checkstyle.sourceforge.net/) enforces
code conventions
