Re: Pluggable Stomp/AMQ translation

2006-10-08 Thread Dejan Bosanac
Hi Brian, that's great. After seeing your patch I realized that we definitely should support the current way of dealing with byte messages. I've planed to do it next week, so it's great to see it done. What do you (and others) think about providing a mapper implementation for map messages using

Re: Pluggable Stomp/AMQ translation

2006-10-07 Thread Brian McCallister
I've applied Dejan's patch locally, but it needs some changes to preserve the current behavior. I'll make them and check it in within a couple days. -Brian On Oct 6, 2006, at 7:56 AM, Brian McCallister wrote: D'oh, I did miss it, and it is a better solution :-) I'll roll back my change

Re: Pluggable Stomp/AMQ translation

2006-10-06 Thread Dejan Bosanac
Hi Brian, did you check my patch with similar functionality ( https://issues.apache.org/activemq/browse/AMQ-943). I've implemented Hiram's idea: Translator (Mapper in that patch's terminology) is selected when the client sends a CONNECT message, according to the value of the protocol-mapping

Re: Pluggable Stomp/AMQ translation

2006-10-06 Thread Brian McCallister
D'oh, I did miss it, and it is a better solution :-) I'll roll back my change later this morning and apply yours. Apparently, we think alike, we have the exact same interfaces, you have a much better way of selecting mappings though! -Brian On Oct 6, 2006, at 12:22 AM, Dejan Bosanac

Pluggable Stomp/AMQ translation

2006-10-05 Thread Brian McCallister
Just checked in a first take on pluggable stomp to amq translation. Right now there is one interface defined for doing both message conversions and destination name conversions. The behavior for the legacy conversion scheme is identical, I just moved the code around so that those four