Re: Questions on yoko Util class in yoko-rmi-spec should use the interface class as the key?

2011-01-12 Thread Forrest Xia
I try making a patch for this problem, pls review. thanks! Forrest On Tue, Jan 11, 2011 at 10:39 PM, Rick McGuire rick...@gmail.com wrote: On 1/11/2011 9:20 AM, Ivan wrote: Hmm, I have to say that I know little about corba, just from the codes of UtilLoader.loadClass, the first part of

Re: Questions on yoko Util class in yoko-rmi-spec should use the interface class as the key?

2011-01-11 Thread Rick McGuire
On 1/11/2011 4:46 AM, Forrest Xia wrote: Hi, When I debug a corba related application, I managed to trace into a piece of yoko code like this: public class Util { private static UtilDelegate delegate = null; private static final String defaultDelegate =

Re: Questions on yoko Util class in yoko-rmi-spec should use the interface class as the key?

2011-01-11 Thread Ivan
I agree with Forrest that those code logic might need to be updated. From the codes fragment below of UtilLoader In the loadClass method, it will first try the ProviderLocator.loadClass, but what ProviderLocation.loadClass expect is an interface class name, like javax.rmi.CORBA.Util. So those

Re: Questions on yoko Util class in yoko-rmi-spec should use the interface class as the key?

2011-01-11 Thread Rick McGuire
On 1/11/2011 7:35 AM, Ivan wrote: I agree with Forrest that those code logic might need to be updated. From the codes fragment below of UtilLoader In the loadClass method, it will first try the ProviderLocator.loadClass, but what ProviderLocation.loadClass expect is an interface class name,

Re: Questions on yoko Util class in yoko-rmi-spec should use the interface class as the key?

2011-01-11 Thread Ivan
That makes sense, also it is better to remove the codes ProviderLocator.loadClass from the UtilLoader.loadClass method, or that makes the function of loadClass method ambigurous. 2011/1/11 Rick McGuire rick...@gmail.com On 1/11/2011 7:35 AM, Ivan wrote: I agree with Forrest that those code

Re: Questions on yoko Util class in yoko-rmi-spec should use the interface class as the key?

2011-01-11 Thread Rick McGuire
On 1/11/2011 8:45 AM, Ivan wrote: That makes sense, also it is better to remove the codes ProviderLocator.loadClass from the UtilLoader.loadClass method, or that makes the function of loadClass method ambigurous. For other reasons, I believe it is still necessary to have

Re: Questions on yoko Util class in yoko-rmi-spec should use the interface class as the key?

2011-01-11 Thread Ivan
Hmm, I have to say that I know little about corba, just from the codes of UtilLoader.loadClass, the first part of that method is trying to load an implementation of the SPI, but the left part is just to load the SPI itself, is it the expected behavior ? If we need to look up a specific provider

Re: Questions on yoko Util class in yoko-rmi-spec should use the interface class as the key?

2011-01-11 Thread Rick McGuire
On 1/11/2011 9:20 AM, Ivan wrote: Hmm, I have to say that I know little about corba, just from the codes of UtilLoader.loadClass, the first part of that method is trying to load an implementation of the SPI, but the left part is just to load the SPI itself, is it the expected behavior ?