Re: TOMEE-2289

2019-01-04 Thread Romain Manni-Bucau
>> regarding >>> > the >>> > > > > spec which I've asked on the github thread, can you please >>> clarify >>> > > these? >>> > > > > >>> > > > > On Wed 2 Jan, 2019, 6:09 PM Ivan Junckes Filho < >>>

Re: TOMEE-2289

2019-01-04 Thread Ivan Junckes Filho
@gmail.com >> > > > > wrote: >> > > > > >> > > > > > Puneeth, I did some comments here >> > > > > > >> > https://github.com/apache/tomee/pull/340#pullrequestreview-188661807 >> > > , >> > > > > > please take a look. >> > > > > > >> > > > > > On Wed, Jan 2, 2019 at 9:51 AM Ivan Junckes Filho < >> > > > ivanjunc...@gmail.com >> > > > > > >> > > > > > wrote: >> > > > > > >> > > > > > > Hi Puneeth, I will review it for you. >> > > > > > > >> > > > > > > On Wed, Jan 2, 2019 at 8:39 AM Puneeth PS < >> puneeth...@gmail.com> >> > > > > wrote: >> > > > > > > >> > > > > > >> Hi, >> > > > > > >> >> > > > > > >> I have created a PR ( >> https://github.com/apache/tomee/pull/340 >> > ) >> > > > for >> > > > > > >> TOMEE-2289. Can someone take a look and help me improve it? >> > > > > > >> >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> >> >> -- >> Atentamente: >> César Hernández Mendoza. >> >