Re: enabled RAT checks during build

2013-05-30 Thread Alan Cabrera
On May 29, 2013, at 2:01 AM, Mark Struberg strub...@yahoo.de wrote: hi folks! I've enabled apache-rat in the whole xbean build. Which means the build is now defunct due to a few missing licenses. Hope we gonna fix those soon… Great idea! Regards, Alan

Re: enabled RAT checks during build

2013-05-30 Thread Alan Cabrera
My 2 cents, I prefer to have this turned on and feel that littering the source tree with patch files and the like is a poor practice; I've seen too many debug files accidentally checked in during my lifetime. Just my 2 cents. Regards, Alan On May 29, 2013, at 8:17 AM, Jarek Gawor

Re: enabled RAT checks during build

2013-05-30 Thread Jarek Gawor
Running findbugs for example on each build makes sense to me at dev time. Running rat doesn't because most of the time one is changing an existing file and not adding new ones. Running rat at release time (as the name of the tool suggests) or deploy time make sense to me as that's when we want to

Re: enabled RAT checks during build

2013-05-30 Thread Romain Manni-Bucau
Rat is fast compared to other mvn phases so not sure you see it in dev time and if it bother you just add skip system prop to maven opts no? Le 30 mai 2013 23:25, Jarek Gawor jga...@gmail.com a écrit : Running findbugs for example on each build makes sense to me at dev time. Running rat doesn't

enabled RAT checks during build

2013-05-29 Thread Mark Struberg
hi folks! I've enabled apache-rat in the whole xbean build. Which means the build is now defunct due to a few missing licenses. Hope we gonna fix those soon... LieGrue, strub

Re: enabled RAT checks during build

2013-05-29 Thread Forrest Xia
Love to see it there, thanks! On Wed, May 29, 2013 at 5:01 PM, Mark Struberg strub...@yahoo.de wrote: hi folks! I've enabled apache-rat in the whole xbean build. Which means the build is now defunct due to a few missing licenses. Hope we gonna fix those soon... LieGrue, strub --

Re: enabled RAT checks during build

2013-05-29 Thread Jarek Gawor
I don't know about others but my source tree is usually polluted with patch files and other files that I create during development/testing/debugging. With Rat enabled by default my build will fail (as it does currently after doing svn up on xbean). So I would prefer to either delay RAT until the

Re: enabled RAT checks during build

2013-05-29 Thread Romain Manni-Bucau
Hi i like to get it by default, @Jarek: rat can be skipped with a system property, isn't it enough for dev time? *Romain Manni-Bucau* *Twitter: @rmannibucau https://twitter.com/rmannibucau* *Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/ *LinkedIn:

Re: enabled RAT checks during build

2013-05-29 Thread Mark Struberg
Cc: Mark Struberg strub...@yahoo.de Sent: Wednesday, 29 May 2013, 17:19 Subject: Re: enabled RAT checks during build Hi i like to get it by default, @Jarek: rat can be skipped with a system property, isn't it enough for dev time? Romain Manni-Bucau Twitter: @rmannibucau Blog: http