Re: svn commit: r1127388 - in /geronimo/server/trunk/plugins: jasper/geronimo-jasper/src/main/java/org/apache/geronimo/jasper/internal/ myfaces/geronimo-myfaces/src/main/java/org/apache/geronimo/myfac

2011-05-25 Thread Jarek Gawor
Since we are tracking 2 states now (ACTIVE or STARTING) and if a bundle does not have any faces configuration, returning null in addingBundle() would cause addingBundle() to be called twice for the same bundle. So the bundle could be scanned twice needlessly... which probably would happen in most

Re: svn commit: r1127388 - in /geronimo/server/trunk/plugins: jasper/geronimo-jasper/src/main/java/org/apache/geronimo/jasper/internal/ myfaces/geronimo-myfaces/src/main/java/org/apache/geronimo/myfac

2011-05-25 Thread Ivan
Thanks for the explanation, Jarek. 2011/5/25 Jarek Gawor jga...@gmail.com: Since we are tracking 2 states now (ACTIVE or STARTING) and if a bundle does not have any faces configuration, returning null in addingBundle() would cause addingBundle() to be called twice for the same bundle. So the

Re: svn commit: r1127388 - in /geronimo/server/trunk/plugins: jasper/geronimo-jasper/src/main/java/org/apache/geronimo/jasper/internal/ myfaces/geronimo-myfaces/src/main/java/org/apache/geronimo/myfac

2011-05-24 Thread Ivan
Do we need to always return a non null value in the addingBundle method ? It looks to me that if no related files found in the target bundle, it is better to return null to tell the tracker to ignore it. Thanks. 2011/5/25 ga...@apache.org: Author: gawor Date: Wed May 25 05:25:34 2011 New