[jira] [Created] (GERONIMO-6726) Create jakarta.* spec APIs

2019-05-03 Thread Mark Struberg (JIRA)
Mark Struberg created GERONIMO-6726: --- Summary: Create jakarta.* spec APIs Key: GERONIMO-6726 URL: https://issues.apache.org/jira/browse/GERONIMO-6726 Project: Geronimo Issue Type: Task

Re: [DISCUSS] implement jakarta spec apis

2019-05-03 Thread Romain Manni-Bucau
Hi Idnt it the exact same as for microprofile? So we dont do? Le ven. 3 mai 2019 à 16:21, Mark Struberg a écrit : > I've started tinkering something under specs/branches/jakarta. > It's wip but have to rush out for a few hours now. > Will continue later today. > > LieGrue, > strub > > > > Am

Re: [DISCUSS] implement jakarta spec apis

2019-05-03 Thread Mark Struberg
No, it is not the same. microprofile specs are licensed under ALv2 and we know all the legal details. For the EE specs this is by far not the same. We don't even know exactly what parts did yet get donated by Oracle to the EF. LieGrue, strub > Am 03.05.2019 um 18:12 schrieb Romain

Re: Jira update for Open Tracing

2019-05-03 Thread Romain Manni-Bucau
Hi Can do in a week Can we ensure we have 2 converters before releasing? We should have a single path per converter IMO - the extension vetoing other IIRC. Le ven. 3 mai 2019 à 16:19, Jean-Louis MONTEIRO a écrit : > Hi team, > > Can someone mark OpenTracing_1.0.2 has being released in JIRA. >

[GitHub] [geronimo-opentracing] jeanouii commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
jeanouii commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280789841 ## File path:

[jira] [Updated] (GERONIMO-6727) Unable to post to Zipkin V2 endpoint from Geronimo OpenTracing

2019-05-03 Thread Jean-Louis MONTEIRO (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Louis MONTEIRO updated GERONIMO-6727: -- Fix Version/s: OpenTracing_1.0.3 > Unable to post to Zipkin V2 endpoint

Re: Jira update for Open Tracing

2019-05-03 Thread Romain Manni-Bucau
Yep Worse case i can do it but not before a week. Idea is to have each event chains handling a single case. Versions are 2 cases so should be two chains. As mentionned in the review it means moving the toggle to the extension probably and drop instanceof from the observer to add typed observes

[DISCUSS] implement jakarta spec apis

2019-05-03 Thread Mark Struberg
hi folks! You might have read todays post from Mike Milinkovich. https://eclipse-foundation.blog/2019/05/03/jakarta-ee-java-trademarks/ It basically says that Jakarta will not be able to change a single bit in the current spec apis under the javax.* package. Any change has to be done in a

[GitHub] [geronimo-opentracing] jgallimore opened a new pull request #1: Zipkin v2 changes

2019-05-03 Thread GitBox
jgallimore opened a new pull request #1: Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1 This PR introduces some simple changes to enable Geronimo Opentracing to POST data to Zipkin's V2 endpoint successfully. Using the latest Zipkin server, there appear

[jira] [Created] (GERONIMO-6727) Unable to post to Zipkin V2 endpoint from Geronimo OpenTracing

2019-05-03 Thread Jonathan Gallimore (JIRA)
Jonathan Gallimore created GERONIMO-6727: Summary: Unable to post to Zipkin V2 endpoint from Geronimo OpenTracing Key: GERONIMO-6727 URL: https://issues.apache.org/jira/browse/GERONIMO-6727

[jira] [Updated] (GERONIMO-6727) Unable to post to Zipkin V2 endpoint from Geronimo OpenTracing

2019-05-03 Thread Jean-Louis MONTEIRO (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Louis MONTEIRO updated GERONIMO-6727: -- Affects Version/s: OpenTracing_1.0.2 > Unable to post to Zipkin V2 endpoint

Jira update for Open Tracing

2019-05-03 Thread Jean-Louis MONTEIRO
Hi team, Can someone mark OpenTracing_1.0.2 has being released in JIRA. I'd like to merge Jon's PR and create a release with the Zipkin fix. OpenTracing_1.0.3 already exists. I would need someone to mark it as released when vote passes, and someone to create a OpenTracing_1.0.4 in case we have

GERONIMO-6727 - Issues posting to Zipkin V2 endpoint

2019-05-03 Thread Jonathan Gallimore
Hi Folks I opened https://issues.apache.org/jira/browse/GERONIMO-6727 and have created a PR: https://github.com/apache/geronimo-opentracing/pull/1 that I hope can be considered. The issue here boils down to 3 things: 1. Using the V1 endpoint works, but data isn't visible in the UI 2. Posting

[GitHub] [geronimo-opentracing] jgallimore commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
jgallimore commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280790540 ## File path:

Re: [DISCUSS] implement jakarta spec apis

2019-05-03 Thread Mark Struberg
I've started tinkering something under specs/branches/jakarta. It's wip but have to rush out for a few hours now. Will continue later today. LieGrue, strub > Am 03.05.2019 um 15:50 schrieb Mark Struberg : > > hi folks! > > You might have read todays post from Mike Milinkovich. > >

[jira] [Resolved] (GERONIMO-6727) Unable to post to Zipkin V2 endpoint from Geronimo OpenTracing

2019-05-03 Thread Jean-Louis MONTEIRO (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Louis MONTEIRO resolved GERONIMO-6727. --- Resolution: Fixed Thanks Jonathan for the fix > Unable to post to Zipkin

[GitHub] [geronimo-opentracing] jeanouii merged pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
jeanouii merged pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [geronimo-opentracing] rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280866748 ## File path:

[GitHub] [geronimo-opentracing] rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280866988 ## File path: geronimo-opentracing/pom.xml ## @@ -122,6 +122,12 @@ 1.2 test +

[GitHub] [geronimo-opentracing] rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280868170 ## File path:

[GitHub] [geronimo-opentracing] rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280867257 ## File path:

[GitHub] [geronimo-opentracing] rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280867358 ## File path:

[GitHub] [geronimo-opentracing] rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280866557 ## File path:

[GitHub] [geronimo-opentracing] rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes

2019-05-03 Thread GitBox
rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2 changes URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280867880 ## File path:

Re: [VOTE] Release Apache Geronimo OpenAPI 1.0.8

2019-05-03 Thread Romain Manni-Bucau
Forgot my own +1 Side note: if no urgence i will close the vote next thursday since i dont have a computer before - otherwise feel free to do it for me. Le lun. 29 avr. 2019 à 20:16, Mark Struberg a écrit : > +1 > > LieGrue, > strub > > > Am 29.04.19 um 09:41 schrieb Romain Manni-Bucau: > > Hi

Re: Jira update for Open Tracing

2019-05-03 Thread Jean-Louis MONTEIRO
Can you elaborate? Not sure I understand. But happy to work on it. Le ven. 3 mai 2019 à 18:17, Romain Manni-Bucau a écrit : > Hi > > Can do in a week > > Can we ensure we have 2 converters before releasing? We should have a > single path per converter IMO - the extension vetoing other IIRC. > >

Re: [VOTE] Release Apache Geronimo OpenAPI 1.0.8

2019-05-03 Thread Jean-Louis MONTEIRO
+1 Le ven. 3 mai 2019 à 20:23, Romain Manni-Bucau a écrit : > Forgot my own +1 > > Side note: if no urgence i will close the vote next thursday since i dont > have a computer before - otherwise feel free to do it for me. > > Le lun. 29 avr. 2019 à 20:16, Mark Struberg a écrit : > >> +1 >> >>

Re: [DISCUSS] implement jakarta spec apis

2019-05-03 Thread Romain Manni-Bucau
Hmm My understanding was it was getting under eclipse license as well and was fully donated but can have missed some details. If we cant reuse them let's just create new ones and fix module name for others. specs/ is fine since it is the same for us IMHO Le ven. 3 mai 2019 à 18:24, Mark

Re: GERONIMO-6727 - Issues posting to Zipkin V2 endpoint

2019-05-03 Thread Romain Manni-Bucau
Hi Jon Commented the PR, hope it makes sense. Feel free to shout there if anything is unclear. And a big thanks to cleaning that up! Ps/tip if it helps: we can also "just" test our models using zipkin serializers directly, no container needed ;). Le ven. 3 mai 2019 à 16:23, Jonathan Gallimore