Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java

2010-07-29 Thread Ivan
Hi, Jarek: What is the difference between the old one and the new one ? While I did it in the past, I just feel that there is no need to create an extra HashSet. 2010/7/29 ga...@apache.org Author: gawor Date: Thu Jul 29 05:54:33 2010 New Revision: 980317 URL:

[jira] Created: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.

2010-07-29 Thread Guang Zhe Wang (JIRA)
Add test cases for jsp 2.2 new features into the testsuite. --- Key: GERONIMO-5481 URL: https://issues.apache.org/jira/browse/GERONIMO-5481 Project: Geronimo Issue Type: Task

[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5481: - Attachment: jsp2.2-testsuite.patch Add test cases for jsp 2.2 new features into the

[jira] Updated: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5482: - Component/s: testsuite Add test cases for el 2.2 new features into the testsuite.

[jira] Created: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.

2010-07-29 Thread Guang Zhe Wang (JIRA)
Add test cases for el 2.2 new features into the testsuite. -- Key: GERONIMO-5482 URL: https://issues.apache.org/jira/browse/GERONIMO-5482 Project: Geronimo Issue Type: Task

[jira] Updated: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5482: - Attachment: el2.2-testsuite.patch Add test cases for el 2.2 new features into the

[jira] Commented: (GERONIMO-5453) Add testing about Servlet-3.0's new secuirty features into Testsuite

2010-07-29 Thread Forrest Xia (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893534#action_12893534 ] Forrest Xia commented on GERONIMO-5453: --- Committed revision 980331 to trunk.

[jira] Created: (GERONIMO-5483) jetty needs to give jasper the merged metadata complete web.xml

2010-07-29 Thread David Jencks (JIRA)
jetty needs to give jasper the merged metadata complete web.xml --- Key: GERONIMO-5483 URL: https://issues.apache.org/jira/browse/GERONIMO-5483 Project: Geronimo Issue Type: Bug

[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5481: - Description: The new feature tested in this patch includes: configuration element

Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java

2010-07-29 Thread David Jencks
I'm not sure it would make a difference to the effect of the permission you end up with, but the code with the hashset eliminates duplicates. I think you can have duplicates in the everything leftover permission (IIRC /:path1:path2:path3:) if some paths have different permissions for

[jira] Assigned: (GERONIMO-5480) Web security does not work on Equinox

2010-07-29 Thread David Jencks (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jencks reassigned GERONIMO-5480: -- Assignee: David Jencks Web security does not work on Equinox

Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java

2010-07-29 Thread Ivan
Yes, I have considered this while I did the changes, the URLPattern overrides the equal and hashCode methods, so the result of them are totally depending on the String field pattern in the class, also each getQualifiedPattern invocation, a HashSet is passed in. So I am thinking that the initial

Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java

2010-07-29 Thread David Jencks
On Jul 29, 2010, at 12:06 AM, Ivan wrote: Yes, I have considered this while I did the changes, the URLPattern overrides the equal and hashCode methods, so the result of them are totally depending on the String field pattern in the class, also each getQualifiedPattern invocation, a HashSet

[jira] Created: (GERONIMO-5484) Create a document for JavaEE 6 sample application - EJBTimer

2010-07-29 Thread Chi Runhua (JIRA)
Create a document for JavaEE 6 sample application - EJBTimer - Key: GERONIMO-5484 URL: https://issues.apache.org/jira/browse/GERONIMO-5484 Project: Geronimo Issue Type: Wish

[jira] Created: (GERONIMO-5485) Create a document for JavaEE 6 sample application - singletonejb

2010-07-29 Thread Chi Runhua (JIRA)
Create a document for JavaEE 6 sample application - singletonejb Key: GERONIMO-5485 URL: https://issues.apache.org/jira/browse/GERONIMO-5485 Project: Geronimo Issue Type: Task

[jira] Assigned: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.

2010-07-29 Thread Forrest Xia (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia reassigned GERONIMO-5482: - Assignee: Forrest Xia Add test cases for el 2.2 new features into the testsuite.

[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5481: - Attachment: (was: jsp2.2-testsuite.patch) Add test cases for jsp 2.2 new

[jira] Updated: (GERONIMO-5478) JSP 2.2 new configuration element default-content-type under jsp-property-group works incorrectly on tomcat-assembly server.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5478: - Attachment: (was: jsp2.2-testsuite.patch) JSP 2.2 new configuration element

[jira] Resolved: (GERONIMO-5482) Add test cases for el 2.2 new features into the testsuite.

2010-07-29 Thread Forrest Xia (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia resolved GERONIMO-5482. --- Resolution: Fixed Committed this patch to trunk at revision 980368, thanks Guang Zhe for

[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5481: - Attachment: jsp2.2-testsuite.patch Add test cases for jsp 2.2 new features into the

[jira] Resolved: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.

2010-07-29 Thread Forrest Xia (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia resolved GERONIMO-5481. --- Resolution: Fixed Committed this patch to trunk at revision 980371, thanks Guang Zhe!

[jira] Assigned: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.

2010-07-29 Thread Forrest Xia (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia reassigned GERONIMO-5481: - Assignee: Forrest Xia Add test cases for jsp 2.2 new features into the testsuite.

[jira] Updated: (GERONIMO-5478) JSP 2.2 new configuration element default-content-type under jsp-property-group works incorrectly on tomcat-assembly server.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5478: - Patch Info: (was: [Patch Available]) Description: default-content-type is said

[BUILD] trunk: Failed for Revision: 980341

2010-07-29 Thread gawor
Geronimo Revision: 980341 built with tests included See the full build-0300.log file at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/build-0300.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729 [INFO] BUILD

[jira] Updated: (GERONIMO-5479) EL 2.2 new feature: method invocation with parameters works incorrectly when the parameter is Integer.

2010-07-29 Thread Guang Zhe Wang (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guang Zhe Wang updated GERONIMO-5479: - Environment: OS: Windows XP SP3, JDK: sun-jdk-1.6.0_18 Description: I create a

Compilation error in OpenEJB :: Builder

2010-07-29 Thread Vamsavardhana Reddy
I am getting a compilation failure in OpenEJB Builder module. Anyone else seeing this error? I am at svn rev 980390. Error message given below... [ERROR] BUILD FAILURE [INFO] [INFO] Compilation failure

Re: [VOTE] External tomcat-parent-6.0.29.0

2010-07-29 Thread Donald Woods
+1 Was able to build the tag and the jars looked like they have the required License/Notice files. -Donald On 7/23/10 7:28 AM, Delos wrote: This voting is for mavenized tomcat 6.0.29. Following what we did to tomcat 6.0.20, we are using a forked copy of tomcat derived from the tomcat 6.0.29

[jira] Updated: (GERONIMO-5481) Add test cases for jsp 2.2 new features into the testsuite.

2010-07-29 Thread Wang Guang Zhe (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wang Guang Zhe updated GERONIMO-5481: - Description: The new feature tested in this patch includes: configuration element

Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java

2010-07-29 Thread Jarek Gawor
The end result with the old code was that less Permission objects were created which made things easier to debug and it's a bit better from performance point of view. Jarek On Thu, Jul 29, 2010 at 3:06 AM, Ivan xhh...@gmail.com wrote: Yes, I have considered this while I did the changes, the

[BUILD] trunk: Failed for Revision: 980434

2010-07-29 Thread gawor
Geronimo Revision: 980434 built with tests included See the full build-0900.log file at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/build-0900.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729 [INFO] BUILD

[jira] Commented: (GERONIMO-5480) Web security does not work on Equinox

2010-07-29 Thread Jarek Gawor (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893651#action_12893651 ] Jarek Gawor commented on GERONIMO-5480: --- Just to provide some more background on

[BUILD] branches/2.2: Failed for Revision: 980139

2010-07-29 Thread gawor
Geronimo Revision: 980139 built with tests included See the full build-1400.log file at http://people.apache.org/builds/geronimo/server/binaries/2.2/20100728/build-1400.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/2.2/20100728 [INFO] BUILD

[BUILD] trunk: Failed for Revision: 980542

2010-07-29 Thread gawor
Geronimo Revision: 980542 built with tests included See the full build-1500.log file at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/build-1500.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729 [INFO] BUILD

[jira] Commented: (GERONIMO-5480) Web security does not work on Equinox

2010-07-29 Thread Jarek Gawor (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12893823#action_12893823 ] Jarek Gawor commented on GERONIMO-5480: --- Btw, as far as I can tell the

Re: svn commit: r980317 - /geronimo/server/trunk/plugins/j2ee/geronimo-web/src/main/java/org/apache/geronimo/web/security/URLPattern.java

2010-07-29 Thread Ivan
Could you please show me any details for it ? I would like to get this lesson learn. Thanks ! 2010/7/29 Jarek Gawor jga...@gmail.com The end result with the old code was that less Permission objects were created which made things easier to debug and it's a bit better from performance point of

[jira] Updated: (GERONIMO-5259) Annoying access denied security exceptions for oenwebbeans while java2 security is enabled.

2010-07-29 Thread YING WANG (JIRA)
[ https://issues.apache.org/jira/browse/GERONIMO-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YING WANG updated GERONIMO-5259: Attachment: AnnotationLiteral.path2 Please help review. anonymous class is used to avoid TCK

Re: [VOTE] External tomcat-parent-6.0.29.0

2010-07-29 Thread Delos
Thanks, Donald! 2010/7/29 Donald Woods dwo...@apache.org +1 Was able to build the tag and the jars looked like they have the required License/Notice files. -Donald On 7/23/10 7:28 AM, Delos wrote: This voting is for mavenized tomcat 6.0.29. Following what we did to tomcat 6.0.20, we

Re: [VOTE] maven-plugins 1.1 for Geronimo Eclipse Plugins

2010-07-29 Thread Delos
We need to release the maven plugin to fix JIRA GERONIMODEVTOOLS-658https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-658. Could PMC members take a look at this? 2010/7/29 Delos dait...@gmail.com my own +1. Is there anyone can take a look at this? 2010/7/27 Delos dait...@gmail.com Hi

[BUILD] trunk: Failed for Revision: 980625

2010-07-29 Thread gawor
Geronimo Revision: 980625 built with tests included See the full build-2100.log file at http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729/build-2100.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/trunk/20100729 [INFO] BUILD

[BUILD] branches/2.2: Failed for Revision: 980522

2010-07-29 Thread gawor
Geronimo Revision: 980522 built with tests included See the full build-1400.log file at http://people.apache.org/builds/geronimo/server/binaries/2.2/20100729/build-1400.log Download the binaries from http://people.apache.org/builds/geronimo/server/binaries/2.2/20100729 [INFO] BUILD

Re: [VOTE] External tomcat-parent-6.0.29.0

2010-07-29 Thread Shawn Jiang
All tomcat related TCK passed. Here is my +1 On Fri, Jul 30, 2010 at 10:16 AM, Delos dait...@gmail.com wrote: Thanks, Donald! 2010/7/29 Donald Woods dwo...@apache.org +1 Was able to build the tag and the jars looked like they have the required License/Notice files. -Donald On 7/23/10

Re: [VOTE] External tomcat-parent-6.0.29.0

2010-07-29 Thread Ivan
+1 2010/7/30 Shawn Jiang genspr...@gmail.com All tomcat related TCK passed. Here is my +1 On Fri, Jul 30, 2010 at 10:16 AM, Delos dait...@gmail.com wrote: Thanks, Donald! 2010/7/29 Donald Woods dwo...@apache.org +1 Was able to build the tag and the jars looked like they have the

[jira] Created: (GERONIMO-5486) Add testsuite for Interceptors 1.1 in Java EE 6

2010-07-29 Thread LiWenQin (JIRA)
Add testsuite for Interceptors 1.1 in Java EE 6 --- Key: GERONIMO-5486 URL: https://issues.apache.org/jira/browse/GERONIMO-5486 Project: Geronimo Issue Type: Task Security Level: public

Re: [VOTE] External tomcat-parent-6.0.29.0

2010-07-29 Thread Rex Wang
build successfully and signature/checksum looks good. +1 -Rex 2010/7/23 Delos dait...@gmail.com This voting is for mavenized tomcat 6.0.29. Following what we did to tomcat 6.0.20, we are using a forked copy of tomcat derived from the tomcat 6.0.29 release, built with maven, with maven