[GitHub] rmannibucau commented on issue #1: fix NPE when No issuer for kid (no mapping and/or default issuer)

2018-04-28 Thread GitBox
rmannibucau commented on issue #1: fix NPE when No issuer for kid (no mapping and/or default issuer) URL: https://github.com/apache/geronimo-jwt-auth/pull/1#issuecomment-385185691 Thanks for checking! This is an automated

[GitHub] rdebusscher closed pull request #1: fix NPE when No issuer for kid (no mapping and/or default issuer)

2018-04-28 Thread GitBox
rdebusscher closed pull request #1: fix NPE when No issuer for kid (no mapping and/or default issuer) URL: https://github.com/apache/geronimo-jwt-auth/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rdebusscher commented on issue #1: fix NPE when No issuer for kid (no mapping and/or default issuer)

2018-04-28 Thread GitBox
rdebusscher commented on issue #1: fix NPE when No issuer for kid (no mapping and/or default issuer) URL: https://github.com/apache/geronimo-jwt-auth/pull/1#issuecomment-385178400 issue already solved by supporting multiple default issuers as done in

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

2018-06-03 Thread GitBox
rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568355 ## File path: geronimo-jwt-auth-impl/src/test/resources/tck.xml ## @@ -40,8 +40,6 @@

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

2018-06-03 Thread GitBox
rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568355 ## File path: geronimo-jwt-auth-impl/src/test/resources/tck.xml ## @@ -40,8 +40,6 @@

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

2018-06-03 Thread GitBox
rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568348 ## File path:

[GitHub] asfgit closed pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

2018-06-04 Thread GitBox
asfgit closed pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jeanouii opened a new pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

2018-06-02 Thread GitBox
jeanouii opened a new pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

2018-06-02 Thread GitBox
rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568348 ## File path:

[GitHub] rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things

2018-06-02 Thread GitBox
rmannibucau commented on a change in pull request #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#discussion_r192568355 ## File path: geronimo-jwt-auth-impl/src/test/resources/tck.xml ## @@ -40,8 +40,6 @@

[GitHub] jeanouii commented on issue #2: Upgrade to Eclipse Microprofile 1.1 and minor things

2018-06-02 Thread GitBox
jeanouii commented on issue #2: Upgrade to Eclipse Microprofile 1.1 and minor things URL: https://github.com/apache/geronimo-jwt-auth/pull/2#issuecomment-394116291 Right. I’ll remove the toString too Le samedi 2 juin 2018, Romain Manni-Bucau a écrit : > *@rmannibucau*

[GitHub] jeanouii closed pull request #1: Remove JCS mentions from the project

2018-06-05 Thread GitBox
jeanouii closed pull request #1: Remove JCS mentions from the project URL: https://github.com/apache/geronimo-jcache-simple/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] jeanouii opened a new pull request #1: Remove JCS mentions from the project

2018-06-05 Thread GitBox
jeanouii opened a new pull request #1: Remove JCS mentions from the project URL: https://github.com/apache/geronimo-jcache-simple/pull/1 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] rdebusscher opened a new pull request #1: fix NPE when No issuer for kid (no mapping and/or default issuer)

2018-04-25 Thread GitBox
rdebusscher opened a new pull request #1: fix NPE when No issuer for kid (no mapping and/or default issuer) URL: https://github.com/apache/geronimo-jwt-auth/pull/1 This is an automated message from the Apache Git Service.

[GitHub] diuis opened a new pull request #1: jdk9+ compilation

2018-07-27 Thread GitBox
diuis opened a new pull request #1: jdk9+ compilation URL: https://github.com/apache/geronimo-openapi/pull/1 Enabled java 9+ compilation (with the introduction of activation api at runtime scope). Removed already defined maven plugin versions (some was outdated). Updated

[GitHub] diuis opened a new pull request #2: fix for the empty ref attribute of RequestBody annotation

2018-08-01 Thread GitBox
diuis opened a new pull request #2: fix for the empty ref attribute of RequestBody annotation URL: https://github.com/apache/geronimo-openapi/pull/2 When a jax-rs method parameter is annotated in this way, without the ref attribute: ``` public AssetViewModel

[GitHub] diuis commented on issue #2: fix for the empty ref attribute of RequestBody annotation

2018-08-01 Thread GitBox
diuis commented on issue #2: fix for the empty ref attribute of RequestBody annotation URL: https://github.com/apache/geronimo-openapi/pull/2#issuecomment-409651754 @rmannibucau please take a look at this pr This is an

[GitHub] rmannibucau commented on issue #2: fix for the empty ref attribute of RequestBody annotation

2018-08-01 Thread GitBox
rmannibucau commented on issue #2: fix for the empty ref attribute of RequestBody annotation URL: https://github.com/apache/geronimo-openapi/pull/2#issuecomment-409700017 Hi @diuis Do you mind adding a test? Updated a oot of these issues earlier today and wonder if it was missed.

[GitHub] diuis commented on issue #2: fix for the empty ref attribute of RequestBody annotation

2018-08-02 Thread GitBox
diuis commented on issue #2: fix for the empty ref attribute of RequestBody annotation URL: https://github.com/apache/geronimo-openapi/pull/2#issuecomment-409866560 Hi @rmannibucau , your abd695bed67d082146148c55b5a295749f113afa commit fixed the RequestBody empty ref bug: ``` if

[GitHub] diuis closed pull request #2: fix for the empty ref attribute of RequestBody annotation

2018-08-02 Thread GitBox
diuis closed pull request #2: fix for the empty ref attribute of RequestBody annotation URL: https://github.com/apache/geronimo-openapi/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rmannibucau commented on a change in pull request #1: jdk9+ compilation

2018-08-02 Thread GitBox
rmannibucau commented on a change in pull request #1: jdk9+ compilation URL: https://github.com/apache/geronimo-openapi/pull/1#discussion_r205850019 ## File path: pom.xml ## @@ -169,6 +170,13 @@ true + +javax.activation +

[GitHub] radcortez closed pull request #1: Fix issue with ClassConverter loading Class when Class is not in the same Classloader.

2018-08-10 Thread GitBox
radcortez closed pull request #1: Fix issue with ClassConverter loading Class when Class is not in the same Classloader. URL: https://github.com/apache/geronimo-config/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] rmannibucau commented on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rmannibucau commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414912784 If you scan the target/classes folder+check mvn deps, you are able (theorically for now since I dont know if a plugin does it) to generate

[GitHub] rotty3000 commented on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rotty3000 commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414804419 If you wish to change to the maven-bundle-plugin we can do it, I just like the bnd plugin more personally, but that's not a worthy issue to block over.

[GitHub] rmannibucau edited a comment on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rmannibucau edited a comment on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414806123 Here is how i see it: most of imports, service loader stuff, versions, etc is generable so we should reduce our maintenance by generating it. Not

[GitHub] rotty3000 opened a new pull request #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rotty3000 opened a new pull request #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5 Signed-off-by: Raymond Auge This is an automated message from the Apache Git Service. To respond to the

[GitHub] rmannibucau commented on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rmannibucau commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414806123 Here is how i see it: most of imports, service loader stuff, versions, etc is generable so we should reduce our maintenance by generating it. Not sure

[GitHub] rotty3000 commented on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rotty3000 commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414808157 for the versions, sure this was just showing the mechanics, not the final PR, certainly I planned to unify the data from mvn. For the spi

[GitHub] rotty3000 commented on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rotty3000 commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414806748 so I am more clear, are you talking about the versions that you see in the bnd file? This

[GitHub] rotty3000 commented on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rotty3000 commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414808932 OH I remembered the nice thing about the bnd-maven-plugin is that we don't have to use `bundle` :( it just uses normal packaging `jar`.

[GitHub] rotty3000 commented on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rotty3000 commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414820686 updated using `maven-bundle-plugin` and some mvn properties. This is an automated message

[GitHub] rmannibucau commented on issue #5: [MP-Config] osgi support

2018-08-21 Thread GitBox
rmannibucau commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-414807157 Yes, spec ones are extractible from mvn, but also all the spi registration etc is doable with static analyzis

[GitHub] rotty3000 edited a comment on issue #5: [MP-Config] osgi support

2018-08-22 Thread GitBox
rotty3000 edited a comment on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-415051435 There's one part of this that could be made much more trivial if we change the compile dependencies to point to the upcoming geronimo specs. These

[GitHub] rmannibucau commented on issue #5: [MP-Config] osgi support

2018-08-22 Thread GitBox
rmannibucau commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-415051773 makes sense :+1: This is an automated message from the Apache Git Service. To

[GitHub] rotty3000 commented on issue #5: [MP-Config] osgi support

2018-08-22 Thread GitBox
rotty3000 commented on issue #5: [MP-Config] osgi support URL: https://github.com/apache/geronimo-config/pull/5#issuecomment-415051435 There's one part of this that could be made much more trivial if we change the compile dependencies to point to the upcoming geronimo specs. These will

[GitHub] rotty3000 commented on issue #1: reproduce simplified failing TCK test

2018-08-30 Thread GitBox
rotty3000 commented on issue #1: reproduce simplified failing TCK test URL: https://github.com/apache/geronimo-metrics/pull/1#issuecomment-417464878 I'm not really expecting this for merge. I'm more looking for help to resolve the failing test. Maybe someone can fetch the branch and debug

[GitHub] rotty3000 opened a new pull request #1: reproduce simplified failing TCK test

2018-08-30 Thread GitBox
rotty3000 opened a new pull request #1: reproduce simplified failing TCK test URL: https://github.com/apache/geronimo-metrics/pull/1 I'm having an issue with this TCK test so I replicated it without the container. But I'm not sure what's going wrong. I think the algorithm might be off.

[GitHub] rotty3000 commented on issue #1: reproduce simplified failing TCK test

2018-08-31 Thread GitBox
rotty3000 commented on issue #1: reproduce simplified failing TCK test URL: https://github.com/apache/geronimo-metrics/pull/1#issuecomment-417671342 ok right, I think this test is specifically checking that. This is an

[GitHub] jgallimore opened a new pull request #3: Additional principal tests to highlight potential OWB issue

2018-11-02 Thread GitBox
jgallimore opened a new pull request #3: Additional principal tests to highlight potential OWB issue URL: https://github.com/apache/geronimo-jwt-auth/pull/3 Adds an additional test to ensure different requests with different tokens with different upn claims are correctly injected.

[GitHub] rotty3000 commented on issue #1: reproduce simplified failing TCK test

2018-08-31 Thread GitBox
rotty3000 commented on issue #1: reproduce simplified failing TCK test URL: https://github.com/apache/geronimo-metrics/pull/1#issuecomment-417678990 .. wish I had the knowledge to implement that. I think it's the only failing thing in this upgrade :(

[GitHub] rmannibucau commented on issue #3: add integration-test for maven-plugin, update some versions

2019-01-18 Thread GitBox
rmannibucau commented on issue #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3#issuecomment-455532866 @deki I'm fine like that but thought I would ask you if you want to unmarshall the json to check some of its shape

[GitHub] rmannibucau commented on issue #3: add integration-test for maven-plugin, update some versions

2019-01-18 Thread GitBox
rmannibucau commented on issue #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3#issuecomment-455499337 @deki Hmm, i dont see where is the test validating the output of the invoker?

[GitHub] deki opened a new pull request #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-18 Thread GitBox
deki opened a new pull request #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rmannibucau commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-18 Thread GitBox
rmannibucau commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6#issuecomment-455533794 @deki small unit test please :angel: ? (no need to use CDI if you don't want, a plain se test of the processor is more

[GitHub] deki commented on issue #3: add integration-test for maven-plugin, update some versions

2019-01-18 Thread GitBox
deki commented on issue #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3#issuecomment-455491054 @rmannibucau I've just resolved conflicts, would be great if you could merge it.

[GitHub] deki commented on issue #3: add integration-test for maven-plugin, update some versions

2019-01-18 Thread GitBox
deki commented on issue #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3#issuecomment-455531354 @rmannibucau of course, you are right. I've added a script for that.

[GitHub] deki commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-20 Thread GitBox
deki commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6#issuecomment-455863010 I cannot run unittests from IDE: ``` java.lang.ClassCastException: Cannot cast sun.misc.Launcher$AppClassLoader to

[GitHub] asfgit merged pull request #3: add integration-test for maven-plugin, update some versions

2019-01-20 Thread GitBox
asfgit merged pull request #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rmannibucau commented on issue #3: add integration-test for maven-plugin, update some versions

2019-01-20 Thread GitBox
rmannibucau commented on issue #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3#issuecomment-455849587 Oki, created GERONIMO-6684 and GERONIMO-6685 for this PR and applied it.

[GitHub] rmannibucau commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-20 Thread GitBox
rmannibucau commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6#issuecomment-455868959 @deki while tck run yes (as the name implies it shouldnt even exist ;)). You can also not use arquillian at all which is

[GitHub] deki commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-20 Thread GitBox
deki commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6#issuecomment-455865486 I've added a testcase. Will extend that with other PRs along with the fixes for missing stuff. Regarding

[GitHub] deki commented on issue #3: add integration-test for maven-plugin, update some versions

2019-01-19 Thread GitBox
deki commented on issue #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3#issuecomment-455778387 @rmannibucau yeah that's easy by using a validator. ``` com.reprezen.kaizen.oasparser.OpenApi3Parser parser = new

[GitHub] deki opened a new pull request #8: WIP: [GERONIMO-6689] use default for default responses

2019-01-21 Thread GitBox
deki opened a new pull request #8: WIP: [GERONIMO-6689] use default for default responses URL: https://github.com/apache/geronimo-openapi/pull/8 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rmannibucau commented on issue #8: [WIP] [GERONIMO-6689] use default for default responses

2019-01-21 Thread GitBox
rmannibucau commented on issue #8: [WIP] [GERONIMO-6689] use default for default responses URL: https://github.com/apache/geronimo-openapi/pull/8#issuecomment-456028828 Applied but I kept the "put" to keep the http status

[GitHub] asfgit merged pull request #8: [WIP] [GERONIMO-6689] use default for default responses

2019-01-21 Thread GitBox
asfgit merged pull request #8: [WIP] [GERONIMO-6689] use default for default responses URL: https://github.com/apache/geronimo-openapi/pull/8 This is an automated message from the Apache Git Service. To respond to the

[GitHub] deki commented on issue #8: [WIP] [GERONIMO-6689] use default for default responses

2019-01-21 Thread GitBox
deki commented on issue #8: [WIP] [GERONIMO-6689] use default for default responses URL: https://github.com/apache/geronimo-openapi/pull/8#issuecomment-456062329 Thanks for merging, but I don't think this is correct. Please see my comment in JIRA:

[GitHub] rmannibucau commented on issue #8: [WIP] [GERONIMO-6689] use default for default responses

2019-01-21 Thread GitBox
rmannibucau commented on issue #8: [WIP] [GERONIMO-6689] use default for default responses URL: https://github.com/apache/geronimo-openapi/pull/8#issuecomment-456077746 Commented as well, think we are fine this way to not break consumers. Anything against that in the spec?

[GitHub] rmannibucau commented on issue #3: Additional principal tests to highlight potential OWB issue

2019-01-22 Thread GitBox
rmannibucau commented on issue #3: Additional principal tests to highlight potential OWB issue URL: https://github.com/apache/geronimo-jwt-auth/pull/3#issuecomment-456322216 Hey Jon, what's the status of that PR? think it is "solved", no?

[GitHub] jgallimore commented on issue #3: Additional principal tests to highlight potential OWB issue

2019-01-22 Thread GitBox
jgallimore commented on issue #3: Additional principal tests to highlight potential OWB issue URL: https://github.com/apache/geronimo-jwt-auth/pull/3#issuecomment-456328057 I'm ok to close. Thanks for your help. This is an

[GitHub] jgallimore closed pull request #3: Additional principal tests to highlight potential OWB issue

2019-01-22 Thread GitBox
jgallimore closed pull request #3: Additional principal tests to highlight potential OWB issue URL: https://github.com/apache/geronimo-jwt-auth/pull/3 This is an automated message from the Apache Git Service. To respond to

[GitHub] deki commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-20 Thread GitBox
deki commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6#issuecomment-455975449 Ok added a check as seperate PR This is an automated message

[GitHub] deki opened a new pull request #7: fix ClassCastException when running tests from IntelliJ IDEA

2019-01-20 Thread GitBox
deki opened a new pull request #7: fix ClassCastException when running tests from IntelliJ IDEA URL: https://github.com/apache/geronimo-openapi/pull/7 As discussed in #6 this is fix to run tests from IntelliJ IDEA. Currently it's not possible to run any tests, even if Arquillian or TCK

[GitHub] asfgit merged pull request #7: fix ClassCastException when running tests from IntelliJ IDEA

2019-01-20 Thread GitBox
asfgit merged pull request #7: fix ClassCastException when running tests from IntelliJ IDEA URL: https://github.com/apache/geronimo-openapi/pull/7 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rmannibucau commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-20 Thread GitBox
rmannibucau commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6#issuecomment-455979091 Applied, :+1: This is an automated message from the

[GitHub] asfgit merged pull request #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-20 Thread GitBox
asfgit merged pull request #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rmannibucau commented on issue #1: jdk9+ compilation

2019-01-21 Thread GitBox
rmannibucau commented on issue #1: jdk9+ compilation URL: https://github.com/apache/geronimo-openapi/pull/1#issuecomment-455980836 FYI cxf 3.3.0 will not require activation/jaxb so should be fine when we'll upgrade meecrowave with cxf 3.3.0

[GitHub] rmannibucau commented on issue #5: Use JAX-RS 2.1 annotations

2019-01-21 Thread GitBox
rmannibucau commented on issue #5: Use JAX-RS 2.1 annotations URL: https://github.com/apache/geronimo-openapi/pull/5#issuecomment-455983512 Hi @opeti, thanks for the patch. I wonder what triggers this patch? Keeping the impl working with JAX-RS 2.0 is nice for now IMHO (jaxrs is

[GitHub] rmannibucau commented on issue #5: Use JAX-RS 2.1 annotations

2019-01-22 Thread GitBox
rmannibucau commented on issue #5: Use JAX-RS 2.1 annotations URL: https://github.com/apache/geronimo-openapi/pull/5#issuecomment-456581322 Hmm the fallback was using @HttpMethod to grab verb extension, did you check if the api was missing it or it was a bug in that area in the annotation

[GitHub] rmannibucau commented on issue #10: GERONIMO-6690 - OpenAPI StringIndexOutOfBoundsException when @Path parent has only "/".

2019-01-23 Thread GitBox
rmannibucau commented on issue #10: GERONIMO-6690 - OpenAPI StringIndexOutOfBoundsException when @Path parent has only "/". URL: https://github.com/apache/geronimo-openapi/pull/10#issuecomment-456842102 @radcortez oops, just pushed almost the same fix since you didnt affect yourself in

[GitHub] radcortez commented on issue #10: GERONIMO-6690 - OpenAPI StringIndexOutOfBoundsException when @Path parent has only "/".

2019-01-23 Thread GitBox
radcortez commented on issue #10: GERONIMO-6690 - OpenAPI StringIndexOutOfBoundsException when @Path parent has only "/". URL: https://github.com/apache/geronimo-openapi/pull/10#issuecomment-456843737 @rmannibucau No worries. Unfortunately, I don't seem to have permissions to assign

[GitHub] radcortez closed pull request #10: GERONIMO-6690 - OpenAPI StringIndexOutOfBoundsException when @Path parent has only "/".

2019-01-23 Thread GitBox
radcortez closed pull request #10: GERONIMO-6690 - OpenAPI StringIndexOutOfBoundsException when @Path parent has only "/". URL: https://github.com/apache/geronimo-openapi/pull/10 This is an automated message from the Apache

[GitHub] rmannibucau commented on issue #3: add integration-test for maven-plugin, update some versions

2019-01-19 Thread GitBox
rmannibucau commented on issue #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3#issuecomment-455808498 Was more thinking reusing our own code, potentially with a validate new service if you feel it can be reusable ;) -

[GitHub] deki commented on issue #3: add integration-test for maven-plugin, update some versions

2019-01-19 Thread GitBox
deki commented on issue #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3#issuecomment-455810868 Well good ideas for the future, I suggest to merge this one and enhance it later as I'd like to focus on improving other

[GitHub] deki commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In

2019-01-19 Thread GitBox
deki commented on issue #6: [GERONIMO-6683] fixed missing mapping for Parameter.In URL: https://github.com/apache/geronimo-openapi/pull/6#issuecomment-455810912 I'll create a test. This is an automated message from the

[GitHub] deki opened a new pull request #9: update apache parent to 21

2019-01-23 Thread GitBox
deki opened a new pull request #9: update apache parent to 21 URL: https://github.com/apache/geronimo-openapi/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] deki opened a new pull request #3: add integration-test for maven-plugin, update some versions

2018-12-21 Thread GitBox
deki opened a new pull request #3: add integration-test for maven-plugin, update some versions URL: https://github.com/apache/geronimo-openapi/pull/3 This is an automated message from the Apache Git Service. To respond to

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-29 Thread GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442826327 > It will change the return type from Metric to Object and won't work for other methods that are using it. I'm pretty

[GitHub] ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-29 Thread GitBox
ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442816821 I actually now get it, but adding map there doesn't work: return ofNullable(metricRegistry.getMetrics().get(name))

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-29 Thread GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442837720 To be concrete, here is the proposal: diff --git

[GitHub] ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-29 Thread GitBox
ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442818000 When you say a server or an endpoint are not necessary, how would you do it?

[GitHub] rmannibucau commented on issue #1: reproduce simplified failing TCK test

2018-11-29 Thread GitBox
rmannibucau commented on issue #1: reproduce simplified failing TCK test URL: https://github.com/apache/geronimo-metrics/pull/1#issuecomment-442836211 @rotty3000 hello Raymond, think we fixed that, can you confirm when you have a few sec?

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - application/json doesn't return correct payload

2018-11-30 Thread GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - application/json doesn't return correct payload URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-443199512 Applied, thanks a lot Ivan This is an automated

[GitHub] asfgit closed pull request #2: GERONIMO-6658 - application/json doesn't return correct payload

2018-11-30 Thread GitBox
asfgit closed pull request #2: GERONIMO-6658 - application/json doesn't return correct payload URL: https://github.com/apache/geronimo-metrics/pull/2 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-23 Thread GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-441321577 Point was more the null check can is already done later so a map(this::map) is likely a better fix and would work for other usages

[GitHub] ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-23 Thread GitBox
ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-441299764 @rmannibucau it doesn't handle it properly. Gauge needs to go through map() method to get the gauge value. singleEntry prepares it

[GitHub] ivanjunckes opened a new pull request #2: WIP - Fix bug with gauge json

2018-11-22 Thread GitBox
ivanjunckes opened a new pull request #2: WIP - Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2 This is WIP as the TCK on TomEE is broken. So I can't be sure if the PR is a 100% ok. This is an

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-22 Thread GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-441120104 If it helps singleEntry was supposed handling it properly This is an

[GitHub] rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-28 Thread GitBox
rmannibucau commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442598808 If you look the code of singleEntry (what you changed) you will see it just misses a map on the metric otherwise it is exactly the

[GitHub] ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-28 Thread GitBox
ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442591418 I am not sure I get your reply @rmannibucau, I added some tests. Can you review them? Also, if you have an example of

[GitHub] ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json

2018-11-28 Thread GitBox
ivanjunckes commented on issue #2: GERONIMO-6658 - WIP Fix bug with gauge json URL: https://github.com/apache/geronimo-metrics/pull/2#issuecomment-442656310 I will have a look tomorrow, no need to do it for me. This is an

[GitHub] opeti opened a new pull request #5: Use JAX-RS 2.1 annotations

2019-01-07 Thread GitBox
opeti opened a new pull request #5: Use JAX-RS 2.1 annotations URL: https://github.com/apache/geronimo-openapi/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] ivanjunckes opened a new pull request #4: GERONIMO-6670 - fixing text/html issue and tests (snake dependency wa…

2019-01-04 Thread GitBox
ivanjunckes opened a new pull request #4: GERONIMO-6670 - fixing text/html issue and tests (snake dependency wa… URL: https://github.com/apache/geronimo-openapi/pull/4 …s not there for testing purposes) This is an automated

[GitHub] cesarhernandezgt commented on issue #4: GERONIMO-6670 - fixing text/html issue and tests (snake dependency wa…

2019-01-04 Thread GitBox
cesarhernandezgt commented on issue #4: GERONIMO-6670 - fixing text/html issue and tests (snake dependency wa… URL: https://github.com/apache/geronimo-openapi/pull/4#issuecomment-451559048 +1 build successfully locally. This

[GitHub] rmannibucau commented on issue #4: GERONIMO-6670 - fixing text/html issue and tests (snake dependency wa…

2019-01-04 Thread GitBox
rmannibucau commented on issue #4: GERONIMO-6670 - fixing text/html issue and tests (snake dependency wa… URL: https://github.com/apache/geronimo-openapi/pull/4#issuecomment-451571369 It should be good on master. However I will take the opportunity to put there some notes for later

[GitHub] struberg commented on issue #1: add a full configuraiton file for geronimo opentracing

2018-09-12 Thread GitBox
struberg commented on issue #1: add a full configuraiton file for geronimo opentracing URL: https://github.com/apache/geronimo-microprofile/pull/1#issuecomment-420672935 +1 for the PR This is an automated message from the

[GitHub] akhabali opened a new pull request #1: add a full configuraiton file for geronimo opentracing

2018-09-12 Thread GitBox
akhabali opened a new pull request #1: add a full configuraiton file for geronimo opentracing URL: https://github.com/apache/geronimo-microprofile/pull/1 This is an automated message from the Apache Git Service. To respond

[GitHub] opeti commented on issue #5: Use JAX-RS 2.1 annotations

2019-01-22 Thread GitBox
opeti commented on issue #5: Use JAX-RS 2.1 annotations URL: https://github.com/apache/geronimo-openapi/pull/5#issuecomment-456514084 Hello! Well, I'm using PATCH operations in my api and since I use Resteasy and not Apache CXF, I was not able to generate OpenAPI documentation

[GitHub] [geronimo-openapi] reta opened a new pull request #15: The AnnotationProcessor should consider '@APIResponses' annotation

2019-04-07 Thread GitBox
reta opened a new pull request #15: The AnnotationProcessor should consider '@APIResponses' annotation URL: https://github.com/apache/geronimo-openapi/pull/15 The Issue --- The `AnnotationProcessor` only considers `@APIResponse` annotation whereas the `@APIResponses` allows to

[GitHub] [geronimo-openapi] reta opened a new pull request #14: The AnnotationProcessor should be able to deduct the parameter name from JAX-RS annotations

2019-04-07 Thread GitBox
reta opened a new pull request #14: The AnnotationProcessor should be able to deduct the parameter name from JAX-RS annotations URL: https://github.com/apache/geronimo-openapi/pull/14 The Issue --- Often the `@Parameter` annotation is used to augment the JAX-RS annotations with the

[GitHub] [geronimo-openapi] rmannibucau commented on a change in pull request #14: The AnnotationProcessor should be able to deduct the parameter name from JAX-RS annotations

2019-04-07 Thread GitBox
rmannibucau commented on a change in pull request #14: The AnnotationProcessor should be able to deduct the parameter name from JAX-RS annotations URL: https://github.com/apache/geronimo-openapi/pull/14#discussion_r272884304 ## File path:

  1   2   3   4   5   6   >