[jira] Commented: (GERONIMO-2402) Redeployment fails after third iteration.

2006-12-07 Thread Rakesh Midha (JIRA)
[ 
http://issues.apache.org/jira/browse/GERONIMO-2402?page=comments#action_12456716
 ] 

Rakesh Midha commented on GERONIMO-2402:



You were right about (modules != null) ... is redundant.

thanks for closing Vamsi

 Redeployment fails after third iteration.
 -

 Key: GERONIMO-2402
 URL: http://issues.apache.org/jira/browse/GERONIMO-2402
 Project: Geronimo
  Issue Type: Bug
  Security Level: public(Regular issues) 
  Components: deployment
Affects Versions: 1.1, 1.1.1
 Environment: JDK 1.4.2_08, Windows/XP  Pro, Version 2002 SP/2
Reporter: Fran Varin
 Assigned To: Vamsavardhana Reddy
Priority: Critical
 Fix For: 1.2, 1.1.2, 2.0-M1

 Attachments: hotdeployupdate.patch


 Here is a modified copy of the test case that reproduces the bug. In its 
 original state there were some screen shots included for clarity sake. 
 However, it is not possible to include those here. The applicaiton that was 
 used in concert with this test case was an extremely simply project that just 
 included one JSP. There was no geronimo-web.xml used in the project and it 
 was deployed in exploded form. 
 Step 1 - Launch Geronimo
 ? For this test I used the 1.1.1-RC3 Version. 
 ? I am pointing to Java SE v1.4.2_08
 ? The standard startup.bat was used to start the server with no 
 modification.
 ? The application does not contain a Geronimo-web.xml descriptor. 
 ? Below are all of the message on the console after the Geronimo started. 
 Note that the application was deployed
 Booting Geronimo Kernel (in Java 1.4.1_02)...
 Module  1/20 geronimo/rmi-naming/1.1.1-rc3/car  started in   .265s
 Module  2/20 geronimo/j2ee-server/1.1.1-rc3/car started in   .563s
 Module  3/20 geronimo/j2ee-security/1.1.1-rc3/car   started in   .547s
 Module  4/20 geronimo/axis/1.1.1-rc3/carstarted in   .078s
 Module  5/20 geronimo/openejb/1.1.1-rc3/car started in   .313s
 Module  6/20 geronimo/system-database/1.1.1-rc3/car started in  1.750s
 Module  7/20 geronimo/activemq-broker/1.1.1-rc3/car started in  1.188s
 Module  8/20 geronimo/activemq/1.1.1-rc3/carstarted in   .390s
 Module  9/20 geronimo/tomcat/1.1.1-rc3/car  started in  2.015s
 Module 10/20 geronimo/geronimo-gbean-deployer/1.1.1-rc3/car started in   .297s
 Module 11/20 geronimo/j2ee-deployer/1.1.1-rc3/car   started in   .234s
 Module 12/20 geronimo/openejb-deployer/1.1.1-rc3/carstarted in   .266s
 Module 13/20 geronimo/client-deployer/1.1.1-rc3/car started in   .047s
 Module 14/20 geronimo/axis-deployer/1.1.1-rc3/car   started in   .078s
 Module 15/20 geronimo/sharedlib/1.1.1-rc3/car   started in   .016s
 Module 16/20 geronimo/tomcat-deployer/1.1.1-rc3/car started in   .093s
 Module 17/20 geronimo/welcome-tomcat/1.1.1-rc3/car  started in   .266s
 Module 18/20 geronimo/webconsole-tomcat/1.1.1-rc3/car   started in  4.297s
 Module 19/20 geronimo/remote-deploy-tomcat/1.1.1-rc3/carstarted in   .234s
 Module 20/20 geronimo/hot-deployer/1.1.1-rc3/carstarted in   .343s
 Startup completed in 16 seconds
   Listening on Ports:
 1099 0.0.0.0 RMI Naming
 1527 0.0.0.0 Derby Connector
 4201 0.0.0.0 ActiveIO Connector EJB
 4242 0.0.0.0 Remote Login Listener
 8009 0.0.0.0 Tomcat Connector AJP
 8080 0.0.0.0 Tomcat Connector HTTP
 8443 0.0.0.0 Tomcat Connector HTTPS
  0.0.0.0 JMX Remoting Connector
61616 0.0.0.0 ActiveMQ Message Broker Connector
   Started Application Modules:
 EAR: geronimo/webconsole-tomcat/1.1.1-rc3/car
 RAR: geronimo/activemq/1.1.1-rc3/car
 WAR: geronimo/remote-deploy-tomcat/1.1.1-rc3/car
 WAR: geronimo/welcome-tomcat/1.1.1-rc3/car
   Web Applications:
 http://RI150WS311:8080/
 http://RI150WS311:8080/console
 http://RI150WS311:8080/console-standard
 http://RI150WS311:8080/remote-deploy
 Geronimo Application Server started
 11:15:15,111 INFO  [Hot Deployer] Deploying Test.war
 11:15:15,423 WARN  [TomcatModuleBuilder] Web application . does not contain a 
 WEB-INF/geronimo-web.xml deployment plan.  This may or may not be a problem, 
 depending on whether you have things like resource references that need to be 
 resolved.  You can also give the deployer a separate deployment plan file on 
 the command line.
 Deployed default/Test/1158074115142/war @
 http://RI150WS311:8080/Test
 Examine the deploy directory. Note that it contains the application as 
 deployed. 
 Examine the repository\default directory. Note that it contains what I 
 refer to as the actually running deployed application. 
 If I were to expand this folder I would find that the WAR file has been 
 deployed here and 

[jira] Commented: (GERONIMO-2402) Redeployment fails after third iteration.

2006-12-06 Thread Vamsavardhana Reddy (JIRA)
[ 
http://issues.apache.org/jira/browse/GERONIMO-2402?page=comments#action_12456085
 ] 

Vamsavardhana Reddy commented on GERONIMO-2402:
---

Rakesh,  in the patch you submitted i see the following:
{code}
+if (modules != null) {
+if (modules.length == 1) {
+return modules[0].getModuleID();
+} else {
+return ;
+}
+} else if (modules != null) { //distribute completed but not start or 
something like that
+return ;
+} else {
+return null;
+}
{code}

else if (modules != null) ...  is redundant.  Can you recheck your patch.

 Redeployment fails after third iteration.
 -

 Key: GERONIMO-2402
 URL: http://issues.apache.org/jira/browse/GERONIMO-2402
 Project: Geronimo
  Issue Type: Bug
  Security Level: public(Regular issues) 
  Components: deployment
Affects Versions: 1.1, 1.1.1
 Environment: JDK 1.4.2_08, Windows/XP  Pro, Version 2002 SP/2
Reporter: Fran Varin
Priority: Critical
 Fix For: 1.2

 Attachments: hotdeployupdate.patch


 Here is a modified copy of the test case that reproduces the bug. In its 
 original state there were some screen shots included for clarity sake. 
 However, it is not possible to include those here. The applicaiton that was 
 used in concert with this test case was an extremely simply project that just 
 included one JSP. There was no geronimo-web.xml used in the project and it 
 was deployed in exploded form. 
 Step 1 - Launch Geronimo
 ? For this test I used the 1.1.1-RC3 Version. 
 ? I am pointing to Java SE v1.4.2_08
 ? The standard startup.bat was used to start the server with no 
 modification.
 ? The application does not contain a Geronimo-web.xml descriptor. 
 ? Below are all of the message on the console after the Geronimo started. 
 Note that the application was deployed
 Booting Geronimo Kernel (in Java 1.4.1_02)...
 Module  1/20 geronimo/rmi-naming/1.1.1-rc3/car  started in   .265s
 Module  2/20 geronimo/j2ee-server/1.1.1-rc3/car started in   .563s
 Module  3/20 geronimo/j2ee-security/1.1.1-rc3/car   started in   .547s
 Module  4/20 geronimo/axis/1.1.1-rc3/carstarted in   .078s
 Module  5/20 geronimo/openejb/1.1.1-rc3/car started in   .313s
 Module  6/20 geronimo/system-database/1.1.1-rc3/car started in  1.750s
 Module  7/20 geronimo/activemq-broker/1.1.1-rc3/car started in  1.188s
 Module  8/20 geronimo/activemq/1.1.1-rc3/carstarted in   .390s
 Module  9/20 geronimo/tomcat/1.1.1-rc3/car  started in  2.015s
 Module 10/20 geronimo/geronimo-gbean-deployer/1.1.1-rc3/car started in   .297s
 Module 11/20 geronimo/j2ee-deployer/1.1.1-rc3/car   started in   .234s
 Module 12/20 geronimo/openejb-deployer/1.1.1-rc3/carstarted in   .266s
 Module 13/20 geronimo/client-deployer/1.1.1-rc3/car started in   .047s
 Module 14/20 geronimo/axis-deployer/1.1.1-rc3/car   started in   .078s
 Module 15/20 geronimo/sharedlib/1.1.1-rc3/car   started in   .016s
 Module 16/20 geronimo/tomcat-deployer/1.1.1-rc3/car started in   .093s
 Module 17/20 geronimo/welcome-tomcat/1.1.1-rc3/car  started in   .266s
 Module 18/20 geronimo/webconsole-tomcat/1.1.1-rc3/car   started in  4.297s
 Module 19/20 geronimo/remote-deploy-tomcat/1.1.1-rc3/carstarted in   .234s
 Module 20/20 geronimo/hot-deployer/1.1.1-rc3/carstarted in   .343s
 Startup completed in 16 seconds
   Listening on Ports:
 1099 0.0.0.0 RMI Naming
 1527 0.0.0.0 Derby Connector
 4201 0.0.0.0 ActiveIO Connector EJB
 4242 0.0.0.0 Remote Login Listener
 8009 0.0.0.0 Tomcat Connector AJP
 8080 0.0.0.0 Tomcat Connector HTTP
 8443 0.0.0.0 Tomcat Connector HTTPS
  0.0.0.0 JMX Remoting Connector
61616 0.0.0.0 ActiveMQ Message Broker Connector
   Started Application Modules:
 EAR: geronimo/webconsole-tomcat/1.1.1-rc3/car
 RAR: geronimo/activemq/1.1.1-rc3/car
 WAR: geronimo/remote-deploy-tomcat/1.1.1-rc3/car
 WAR: geronimo/welcome-tomcat/1.1.1-rc3/car
   Web Applications:
 http://RI150WS311:8080/
 http://RI150WS311:8080/console
 http://RI150WS311:8080/console-standard
 http://RI150WS311:8080/remote-deploy
 Geronimo Application Server started
 11:15:15,111 INFO  [Hot Deployer] Deploying Test.war
 11:15:15,423 WARN  [TomcatModuleBuilder] Web application . does not contain a 
 WEB-INF/geronimo-web.xml deployment plan.  This may or may not be a problem, 
 depending on whether you have things like resource references that need to be 
 resolved.  You can also give the deployer a separate deployment plan file on 
 the command line.
 Deployed 

[jira] Commented: (GERONIMO-2402) Redeployment fails after third iteration.

2006-12-06 Thread Vamsavardhana Reddy (JIRA)
[ 
http://issues.apache.org/jira/browse/GERONIMO-2402?page=comments#action_12456122
 ] 

Vamsavardhana Reddy commented on GERONIMO-2402:
---

I have tried the fix on branches\1.1 (not 1.2) , excluding the redundant else 
if (modules != null)... part.  The redeployment part after each file updation 
seems to work properly except that server tries to redeploy the app at each 
restart (I guess this is to addressed by GERONIMO-2584).

 Redeployment fails after third iteration.
 -

 Key: GERONIMO-2402
 URL: http://issues.apache.org/jira/browse/GERONIMO-2402
 Project: Geronimo
  Issue Type: Bug
  Security Level: public(Regular issues) 
  Components: deployment
Affects Versions: 1.1, 1.1.1
 Environment: JDK 1.4.2_08, Windows/XP  Pro, Version 2002 SP/2
Reporter: Fran Varin
Priority: Critical
 Fix For: 1.2

 Attachments: hotdeployupdate.patch


 Here is a modified copy of the test case that reproduces the bug. In its 
 original state there were some screen shots included for clarity sake. 
 However, it is not possible to include those here. The applicaiton that was 
 used in concert with this test case was an extremely simply project that just 
 included one JSP. There was no geronimo-web.xml used in the project and it 
 was deployed in exploded form. 
 Step 1 - Launch Geronimo
 ? For this test I used the 1.1.1-RC3 Version. 
 ? I am pointing to Java SE v1.4.2_08
 ? The standard startup.bat was used to start the server with no 
 modification.
 ? The application does not contain a Geronimo-web.xml descriptor. 
 ? Below are all of the message on the console after the Geronimo started. 
 Note that the application was deployed
 Booting Geronimo Kernel (in Java 1.4.1_02)...
 Module  1/20 geronimo/rmi-naming/1.1.1-rc3/car  started in   .265s
 Module  2/20 geronimo/j2ee-server/1.1.1-rc3/car started in   .563s
 Module  3/20 geronimo/j2ee-security/1.1.1-rc3/car   started in   .547s
 Module  4/20 geronimo/axis/1.1.1-rc3/carstarted in   .078s
 Module  5/20 geronimo/openejb/1.1.1-rc3/car started in   .313s
 Module  6/20 geronimo/system-database/1.1.1-rc3/car started in  1.750s
 Module  7/20 geronimo/activemq-broker/1.1.1-rc3/car started in  1.188s
 Module  8/20 geronimo/activemq/1.1.1-rc3/carstarted in   .390s
 Module  9/20 geronimo/tomcat/1.1.1-rc3/car  started in  2.015s
 Module 10/20 geronimo/geronimo-gbean-deployer/1.1.1-rc3/car started in   .297s
 Module 11/20 geronimo/j2ee-deployer/1.1.1-rc3/car   started in   .234s
 Module 12/20 geronimo/openejb-deployer/1.1.1-rc3/carstarted in   .266s
 Module 13/20 geronimo/client-deployer/1.1.1-rc3/car started in   .047s
 Module 14/20 geronimo/axis-deployer/1.1.1-rc3/car   started in   .078s
 Module 15/20 geronimo/sharedlib/1.1.1-rc3/car   started in   .016s
 Module 16/20 geronimo/tomcat-deployer/1.1.1-rc3/car started in   .093s
 Module 17/20 geronimo/welcome-tomcat/1.1.1-rc3/car  started in   .266s
 Module 18/20 geronimo/webconsole-tomcat/1.1.1-rc3/car   started in  4.297s
 Module 19/20 geronimo/remote-deploy-tomcat/1.1.1-rc3/carstarted in   .234s
 Module 20/20 geronimo/hot-deployer/1.1.1-rc3/carstarted in   .343s
 Startup completed in 16 seconds
   Listening on Ports:
 1099 0.0.0.0 RMI Naming
 1527 0.0.0.0 Derby Connector
 4201 0.0.0.0 ActiveIO Connector EJB
 4242 0.0.0.0 Remote Login Listener
 8009 0.0.0.0 Tomcat Connector AJP
 8080 0.0.0.0 Tomcat Connector HTTP
 8443 0.0.0.0 Tomcat Connector HTTPS
  0.0.0.0 JMX Remoting Connector
61616 0.0.0.0 ActiveMQ Message Broker Connector
   Started Application Modules:
 EAR: geronimo/webconsole-tomcat/1.1.1-rc3/car
 RAR: geronimo/activemq/1.1.1-rc3/car
 WAR: geronimo/remote-deploy-tomcat/1.1.1-rc3/car
 WAR: geronimo/welcome-tomcat/1.1.1-rc3/car
   Web Applications:
 http://RI150WS311:8080/
 http://RI150WS311:8080/console
 http://RI150WS311:8080/console-standard
 http://RI150WS311:8080/remote-deploy
 Geronimo Application Server started
 11:15:15,111 INFO  [Hot Deployer] Deploying Test.war
 11:15:15,423 WARN  [TomcatModuleBuilder] Web application . does not contain a 
 WEB-INF/geronimo-web.xml deployment plan.  This may or may not be a problem, 
 depending on whether you have things like resource references that need to be 
 resolved.  You can also give the deployer a separate deployment plan file on 
 the command line.
 Deployed default/Test/1158074115142/war @
 http://RI150WS311:8080/Test
 Examine the deploy directory. Note that it contains the application as 
 deployed. 
 Examine the repository\default directory. Note that it contains