Re: [patch] $ACTIVEMQ_OPTS ignored in "activemq" startup script

[Adrian Co]

Hi Brad, I have committed your fixed. Thanks for the heads up! Much appreciated. :-) Regards, Adrian Brad Fritz wrote: I tried to submit this as a JIRA issue but wasn't able to login after creating an account and receiving a confirmation. :-/ Anyhow, there are two typos in assembly/src/release/bin/activemq that prevent the default value for $ACTIVEMQ_OPTS from being overridden. Th trivial patch attached adds the missing dollar sign and changes "-n" (test for non-zero length) to "-z" (test for zero length) so that $ACTIVEMQ_OPTS gets set to the default only if it's not already set. Patch is against SVN trunk. --Brad Index: assembly/src/release/bin/activemq =================================================================== --- assembly/src/release/bin/activemq (revision 358408) +++ assembly/src/release/bin/activemq (working copy) @@ -114,7 +114,7 @@ fi -if [ -n "ACTIVEMQ_OPTS" ] ; then +if [ -z "$ACTIVEMQ_OPTS" ] ; then ACTIVEMQ_OPTS="-Xmx512M -Dderby.system.home=../data -Dderby.storage.fileSyncTransactionLog=true" fi