Re: XALAN : Re: svn commit: r483346 - in /geronimo/server/trunk: applications/console/geronimo-console-standard/src/main/webapp/WEB-INF/classes/login-modules.properties assemblies/geronimo-boilerplate

2006-12-09 Thread Tim McConnell
HI Vamsi, I'm not sure that comments in the commit would really help since the svk smerge only looks at the actual files. What I would suggest is that I attach the synchronization patch to a JIRA and ask that it be reviewed before it gets committed, and allow a day or two for review. Would that

Re: XALAN : Re: svn commit: r483346 - in /geronimo/server/trunk: applications/console/geronimo-console-standard/src/main/webapp/WEB-INF/classes/login-modules.properties assemblies/geronimo-boilerplate

2006-12-08 Thread Vamsavardhana Reddy
In the commits to branch\1.2 may be we should indicate in the comment that the commit is meant for branch only. Will that help prevent those being merged into trunk using SVK? --vamsi On 12/8/06, anita kulshreshtha <[EMAIL PROTECTED]> wrote: hmm... This change was only meant for the branch

Re: XALAN : Re: svn commit: r483346 - in /geronimo/server/trunk: applications/console/geronimo-console-standard/src/main/webapp/WEB-INF/classes/login-modules.properties assemblies/geronimo-boilerplate

2006-12-08 Thread anita kulshreshtha
XmlParserApis were also removed in rev 483063. If there was no other change made, it might be easier to revert 483346. Otherwise I will redo this work tomorrow morning (EST). Thanks Anita --- "Christopher M. Cardona" <[EMAIL PROTECTED]> wrote: > I haven't used SVK before so maybe others can a

Re: XALAN : Re: svn commit: r483346 - in /geronimo/server/trunk: applications/console/geronimo-console-standard/src/main/webapp/WEB-INF/classes/login-modules.properties assemblies/geronimo-boilerplate

2006-12-08 Thread Christopher M. Cardona
I haven't used SVK before so maybe others can answer. AFAIK this is the first patch that was applied. Reading your comment on G-2594 you saying xmlParserApis and xalan is not necessary in trunk so do we need to revert this? Thanks, chris anita kulshreshtha wrote: hmm... This change was o

Re: XALAN : Re: svn commit: r483346 - in /geronimo/server/trunk: applications/console/geronimo-console-standard/src/main/webapp/WEB-INF/classes/login-modules.properties assemblies/geronimo-boilerplate

2006-12-08 Thread anita kulshreshtha
hmm... This change was only meant for the branch. I wonder what else was synched up.. Is there a way to say that a certain change is meant for a branch only, and should not be merged to the trunk? Thanks Anita --- "Christopher M. Cardona" <[EMAIL PROTECTED]> wrote: > Anita, > > This change

Re: XALAN : Re: svn commit: r483346 - in /geronimo/server/trunk: applications/console/geronimo-console-standard/src/main/webapp/WEB-INF/classes/login-modules.properties assemblies/geronimo-boilerplate

2006-12-08 Thread Christopher M. Cardona
Anita, This change was made in branches/1.2 and so trunk is being synched up. Best wishes, chris anita kulshreshtha wrote: Chris, This commit added xalan to the assembly. Is it intentional? Thanks Anita --- [EMAIL PROTECTED] wrote: Author: ccardona Date: Wed Dec 6 21:14:16 2006 New

XALAN : Re: svn commit: r483346 - in /geronimo/server/trunk: applications/console/geronimo-console-standard/src/main/webapp/WEB-INF/classes/login-modules.properties assemblies/geronimo-boilerplate-min

2006-12-08 Thread anita kulshreshtha
Chris, This commit added xalan to the assembly. Is it intentional? Thanks Anita --- [EMAIL PROTECTED] wrote: > Author: ccardona > Date: Wed Dec 6 21:14:16 2006 > New Revision: 483346 > > URL: http://svn.apache.org/viewvc?view=rev&rev=483346 > Log: > GERONIMO-2633 : SVK synchronization patc