Re: svn commit: r565599 - in /geronimo/server/trunk: applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/ applications/console/geronimo-console-standard/

2007-08-14 Thread David Jencks
On Aug 13, 2007, at 9:33 PM, Kevan Miller wrote: I'd also make the following changes. Comments? The Test updates are optional, but may as well clean those up. I agree with all of these except the CallerIdentityPasswordCredentialLoginModule. I think there are two choices: 1. throw a

Re: svn commit: r565599 - in /geronimo/server/trunk: applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/ applications/console/geronimo-console-standard/

2007-08-14 Thread Vamsavardhana Reddy
Verified the fix to check for possible regression of GERONIMO-2266 and GERONIMO-2267. No regression. Vamsi On 8/14/07, David Jencks [EMAIL PROTECTED] wrote: On Aug 13, 2007, at 9:33 PM, Kevan Miller wrote: I'd also make the following changes. Comments? The Test updates are optional,

Re: svn commit: r565599 - in /geronimo/server/trunk: applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/ applications/console/geronimo-console-standard/

2007-08-14 Thread Kevan Miller
On Aug 14, 2007, at 2:29 AM, David Jencks wrote: On Aug 13, 2007, at 9:33 PM, Kevan Miller wrote: I'd also make the following changes. Comments? The Test updates are optional, but may as well clean those up. I agree with all of these except the

Re: svn commit: r565599 - in /geronimo/server/trunk: applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/ applications/console/geronimo-console-standard/

2007-08-13 Thread Kevan Miller
I'd also make the following changes. Comments? The Test updates are optional, but may as well clean those up. --kevan coltrane:~/geronimo/server/trunk kevan$ svn diff Index: testsuite/enterprise-testsuite/sec-tests/sec-ejb/src/main/java/ org/apache/geronimo/itest/TestLoginModule.java