Re: svn commit: r725699 - in /geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin: geronimo.bat geronimo.sh

2008-12-11 Thread David Jencks
I believe apache policy is that patch commit messages need to include mention of the contributor. It would probably be a good idea to edit the commit messages to include that, e.g. ... Thanks to Jack Cai thanks david jenkcs On Dec 11, 2008, at 6:31 AM, ga...@apache.org wrote: Author:

Re: svn commit: r725699 - in /geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin: geronimo.bat geronimo.sh

2008-12-11 Thread David Jencks
Umm, next time maybe I'll look at all the commits before jumping the gun obviously you already fixed this. sorry :-( david jencks On Dec 11, 2008, at 9:49 AM, David Jencks wrote: I believe apache policy is that patch commit messages need to include mention of the contributor. It would

Re: svn commit: r725699 - in /geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin: geronimo.bat geronimo.sh

2008-12-11 Thread Kevan Miller
On Dec 11, 2008, at 12:49 PM, David Jencks wrote: I believe apache policy is that patch commit messages need to include mention of the contributor. It would probably be a good idea to edit the commit messages to include that, e.g. ... Thanks to Jack Cai Pretty sure that Jarek had