[
https://issues.apache.org/jira/browse/GIRAPH-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13403818#comment-13403818
]
Alessandro Presta commented on GIRAPH-141:
--
Eli, we agree on the definition of
[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta updated GIRAPH-221:
-
Attachment: GIRAPH-221.patch
Here's a first iteration (pun intended).
Hi all,
Kind of a silly concern, but nevertheless:
IntelliJ IDEA does a great job at optimizing imports for you. While doing so,
it also insists in reorganizing them following some logic.
Since it's not nice to have a patch dirtied by imports reordering every time a
different person touches a
Alessandro Presta created GIRAPH-224:
Summary: Server-side combiner
Key: GIRAPH-224
URL: https://issues.apache.org/jira/browse/GIRAPH-224
Project: Giraph
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/GIRAPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404015#comment-13404015
]
Maja Kabiljo commented on GIRAPH-211:
-
I'm not sure what am I supposed to do here. My
[
https://issues.apache.org/jira/browse/GIRAPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404104#comment-13404104
]
Eugene Koontz commented on GIRAPH-211:
--
I'm happy to help Maja or take over this JIRA
[
https://issues.apache.org/jira/browse/GIRAPH-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404113#comment-13404113
]
Eugene Koontz commented on GIRAPH-211:
--
I should mention that Zookeeper supports both
[
https://issues.apache.org/jira/browse/GIRAPH-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan updated GIRAPH-223:
---
Summary: Need to put Giraph jar on classpath, post-GIRAPH-205. (was:
GIRAPH-205 needs to put new
[
https://issues.apache.org/jira/browse/GIRAPH-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jakob Homan updated GIRAPH-205:
---
Assignee: Roman Shaposhnik (was: Eli Reisman)
Move Giraph jar to root level of tar.gz
[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta updated GIRAPH-221:
-
Attachment: (was: GIRAPH-221.patch)
Make iteration over edges more explicit
[
https://issues.apache.org/jira/browse/GIRAPH-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Presta updated GIRAPH-221:
-
Attachment: GIRAPH-221-1.patch
Small nit: getEdgesIterator() instead of
[
https://issues.apache.org/jira/browse/GIRAPH-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13404192#comment-13404192
]
Eugene Koontz commented on GIRAPH-212:
--
Will set patch available once I figure out
[
https://issues.apache.org/jira/browse/GIRAPH-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eli Reisman updated GIRAPH-225:
---
Attachment: GIRAPH-225-1.patch
Guava version in POM.XML is really old. Updated to version 12.0
It's not silly at all. I suggest that we add some checkstyle rules for
enforcing our convention as well.
http://checkstyle.sourceforge.net/config_imports.html
I like AvoidStarImport, RedundantImport, UnusedImports, and (most
related to this question) ImportOrder.
Any thoughts?
Avery
On
It's not silly at all. I suggest that we add some checkstyle rules for
enforcing our convention as well.
http://checkstyle.sourceforge.net/config_imports.html
I like AvoidStarImport, RedundantImport, UnusedImports, and (most
related to this question) ImportOrder.
Any thoughts?
Avery
On
My thought is that after reviewing a lot of patches, I honestly don't
care about the imports... If your IDE can do something sensible with
them, that's great. But they have no effect on the code or add any
extra effort to the code reviews.
On Fri, Jun 29, 2012 at 10:34 PM, Avery Ching
16 matches
Mail list logo