[jira] [Commented] (GIRAPH-527) readVertexInputSplit is always reporting 0 vertices and 0 edges

2013-04-05 Thread Eli Reisman (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623389#comment-13623389 ] Eli Reisman commented on GIRAPH-527: Nice catch Maja!

[jira] [Updated] (GIRAPH-564) Input/Output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-564: --- Summary: Input/Output formats and readers/writers should implement

[jira] [Updated] (GIRAPH-564) Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-564: --- Summary: Input/output formats and readers/writers should implement

Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10297/ --- Review request for giraph. Description --- All input/output formats and

[jira] [Updated] (GIRAPH-564) Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching updated GIRAPH-564: --- Attachment: GIRAPH-564.patch Here's the patch and the reviewboard.

[jira] [Commented] (GIRAPH-527) readVertexInputSplit is always reporting 0 vertices and 0 edges

2013-04-05 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623478#comment-13623478 ] Nitay Joffe commented on GIRAPH-527: I'll get a fix up for this soon.

[jira] [Commented] (GIRAPH-604) Clean up benchmarks

2013-04-05 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623689#comment-13623689 ] Maja Kabiljo commented on GIRAPH-604: - Thanks Eli, committing. Clean

Re: Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10297/#review18711 --- My idea was actually to make the base classes (VertexReader etc)

Re: Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching
On April 5, 2013, 6:17 p.m., Alessandro Presta wrote: My idea was actually to make the base classes (VertexReader etc) default-configurable, exactly to avoid the code duplication seen here. They will have to be turned from interfaces to abstract base classes (hopefully we don't have

Re: Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Alessandro Presta
On April 5, 2013, 6:17 p.m., Alessandro Presta wrote: My idea was actually to make the base classes (VertexReader etc) default-configurable, exactly to avoid the code duplication seen here. They will have to be turned from interfaces to abstract base classes (hopefully we don't have

Re: Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching
On April 5, 2013, 6:17 p.m., Alessandro Presta wrote: My idea was actually to make the base classes (VertexReader etc) default-configurable, exactly to avoid the code duplication seen here. They will have to be turned from interfaces to abstract base classes (hopefully we don't have

Re: Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Alessandro Presta
On April 5, 2013, 6:17 p.m., Alessandro Presta wrote: My idea was actually to make the base classes (VertexReader etc) default-configurable, exactly to avoid the code duplication seen here. They will have to be turned from interfaces to abstract base classes (hopefully we don't have

Re: Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching
On April 5, 2013, 6:17 p.m., Alessandro Presta wrote: My idea was actually to make the base classes (VertexReader etc) default-configurable, exactly to avoid the code duplication seen here. They will have to be turned from interfaces to abstract base classes (hopefully we don't have

Re: Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10297/ --- (Updated April 5, 2013, 9:19 p.m.) Review request for giraph. Changes

Re: Review Request: Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10297/#review18734 --- Ship it! +1 - Alessandro Presta On April 5, 2013, 9:19 p.m.,

[jira] [Resolved] (GIRAPH-564) Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avery Ching resolved GIRAPH-564. Resolution: Fixed Thanks for the helpful review [~apresta]. Committed.

[jira] [Created] (GIRAPH-606) Configure classes by default when possible

2013-04-05 Thread Alessandro Presta (JIRA)
Alessandro Presta created GIRAPH-606: Summary: Configure classes by default when possible Key: GIRAPH-606 URL: https://issues.apache.org/jira/browse/GIRAPH-606 Project: Giraph Issue

Review Request: GIRAPH-606: Configure classes by default when possible

2013-04-05 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10320/ --- Review request for giraph. Description --- Now that

[jira] [Updated] (GIRAPH-606) Configure classes by default when possible

2013-04-05 Thread Alessandro Presta (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Presta updated GIRAPH-606: - Attachment: GIRAPH-606.patch https://reviews.apache.org/r/10320/

[jira] [Created] (GIRAPH-607) bump hive IO dep

2013-04-05 Thread Nitay Joffe (JIRA)
Nitay Joffe created GIRAPH-607: -- Summary: bump hive IO dep Key: GIRAPH-607 URL: https://issues.apache.org/jira/browse/GIRAPH-607 Project: Giraph Issue Type: Bug Reporter: Nitay

[jira] [Updated] (GIRAPH-607) bump hive IO dep

2013-04-05 Thread Nitay Joffe (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated GIRAPH-607: --- Attachment: GIRAPH-607.patch bump hive IO dep Key:

[jira] [Commented] (GIRAPH-607) bump hive IO dep

2013-04-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624239#comment-13624239 ] Hudson commented on GIRAPH-607: --- Integrated in Giraph-trunk-Commit #884 (See

[jira] [Commented] (GIRAPH-564) Input/output formats and readers/writers should implement ImmutableClassesGiraphConfigurable

2013-04-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624240#comment-13624240 ] Hudson commented on GIRAPH-564: --- Integrated in Giraph-trunk-Commit #884 (See

Re: Review Request: GIRAPH-606: Configure classes by default when possible

2013-04-05 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10320/#review18748 --- Ship it! +1 Looks good. - Avery Ching On April 5, 2013, 10:45

Re: Review Request: GIRAPH-606: Configure classes by default when possible

2013-04-05 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10320/#review18749 --- Ship it! +1 Looks good. - Avery Ching On April 5, 2013, 10:45