[GitHub] giraph pull request #93: GIRAPH-1211: Make retrying to send network requests...

2018-11-06 Thread dlogothetis
Github user dlogothetis commented on a diff in the pull request:

https://github.com/apache/giraph/pull/93#discussion_r231388167
  
--- Diff: 
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
@@ -1006,18 +1013,21 @@ public boolean apply(RequestInfo requestInfo) {
 return writeFuture != null && (!writeFuture.channel().isActive() ||
 (writeFuture.isDone() && !writeFuture.isSuccess()));
   }
-}, networkRequestsResentForConnectionFailure);
+}, networkRequestsResentForConnectionFailure, true);
   }
 
   /**
* Resend requests which satisfy predicate
*  @param shouldResendRequestPredicate Predicate to use to check whether
* request should be resent
* @param counter Counter to increment for every resent network request
+   * @param resendProblematicRequest Whether to resend problematic request 
or
+   *fail th job if such request is found
--- End diff --

```suggestion
   *fail the job if such request is found
```


---


[jira] [Commented] (GIRAPH-1211) Make retrying to send network requests after timeout optional

2018-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/GIRAPH-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677723#comment-16677723
 ] 

ASF GitHub Bot commented on GIRAPH-1211:


Github user dlogothetis commented on a diff in the pull request:

https://github.com/apache/giraph/pull/93#discussion_r231388167
  
--- Diff: 
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
@@ -1006,18 +1013,21 @@ public boolean apply(RequestInfo requestInfo) {
 return writeFuture != null && (!writeFuture.channel().isActive() ||
 (writeFuture.isDone() && !writeFuture.isSuccess()));
   }
-}, networkRequestsResentForConnectionFailure);
+}, networkRequestsResentForConnectionFailure, true);
   }
 
   /**
* Resend requests which satisfy predicate
*  @param shouldResendRequestPredicate Predicate to use to check whether
* request should be resent
* @param counter Counter to increment for every resent network request
+   * @param resendProblematicRequest Whether to resend problematic request 
or
+   *fail th job if such request is found
--- End diff --

```suggestion
   *fail the job if such request is found
```


> Make retrying to send network requests after timeout optional
> -
>
> Key: GIRAPH-1211
> URL: https://issues.apache.org/jira/browse/GIRAPH-1211
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Major
>
> Using counters added in GIRAPH-1205 we were able to confirm that resending 
> network requests after timeout almost never succeeds, so add an option to 
> fail early instead of keep trying to resend these network requests 
> indefinitely.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] giraph pull request #93: GIRAPH-1211: Make retrying to send network requests...

2018-11-06 Thread dlogothetis
Github user dlogothetis commented on a diff in the pull request:

https://github.com/apache/giraph/pull/93#discussion_r231387974
  
--- Diff: 
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java ---
@@ -690,6 +690,12 @@
   new IntConfOption("giraph.maxRequestMilliseconds", 
MINUTES.toMillis(10),
   "Milliseconds for a request to complete (or else resend)");
 
+  /** Milliseconds for a request to complete (or else resend) */
--- End diff --

Comment seems inaccurate.


---


[GitHub] giraph pull request #93: GIRAPH-1211: Make retrying to send network requests...

2018-11-06 Thread majakabiljo
GitHub user majakabiljo opened a pull request:

https://github.com/apache/giraph/pull/93

GIRAPH-1211: Make retrying to send network requests after timeout optional

Summary: Using counters added in GIRAPH-1205 we were able to confirm that 
resending network requests after timeout almost never succeeds, so add an 
option to fail early instead of keep trying to resend these network requests 
indefinitely.

Test Plan: Made response not being sent for a specific request id, verified 
that with keeping default value for this new option we kept trying to resend 
the request, and when making it false the job failed when request timeout was 
noticed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/majakabiljo/giraph giraph-1211

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/giraph/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #93


commit 1ce1a8e50565cf7adb4d5ebce872620949f3f906
Author: Maja Kabiljo 
Date:   2018-11-07T04:50:28Z

GIRAPH-1211: Make retrying to send network requests after timeout optional

Summary: Using counters added in GIRAPH-1205 we were able to confirm that 
resending network requests after timeout almost never succeeds, so add an 
option to fail early instead of keep trying to resend these network requests 
indefinitely.

Test Plan: Made response not being sent for a specific request id, verified 
that with keeping default value for this new option we kept trying to resend 
the request, and when making it false the job failed when request timeout was 
noticed.




---


[jira] [Commented] (GIRAPH-1211) Make retrying to send network requests after timeout optional

2018-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/GIRAPH-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677679#comment-16677679
 ] 

ASF GitHub Bot commented on GIRAPH-1211:


GitHub user majakabiljo opened a pull request:

https://github.com/apache/giraph/pull/93

GIRAPH-1211: Make retrying to send network requests after timeout optional

Summary: Using counters added in GIRAPH-1205 we were able to confirm that 
resending network requests after timeout almost never succeeds, so add an 
option to fail early instead of keep trying to resend these network requests 
indefinitely.

Test Plan: Made response not being sent for a specific request id, verified 
that with keeping default value for this new option we kept trying to resend 
the request, and when making it false the job failed when request timeout was 
noticed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/majakabiljo/giraph giraph-1211

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/giraph/pull/93.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #93


commit 1ce1a8e50565cf7adb4d5ebce872620949f3f906
Author: Maja Kabiljo 
Date:   2018-11-07T04:50:28Z

GIRAPH-1211: Make retrying to send network requests after timeout optional

Summary: Using counters added in GIRAPH-1205 we were able to confirm that 
resending network requests after timeout almost never succeeds, so add an 
option to fail early instead of keep trying to resend these network requests 
indefinitely.

Test Plan: Made response not being sent for a specific request id, verified 
that with keeping default value for this new option we kept trying to resend 
the request, and when making it false the job failed when request timeout was 
noticed.




> Make retrying to send network requests after timeout optional
> -
>
> Key: GIRAPH-1211
> URL: https://issues.apache.org/jira/browse/GIRAPH-1211
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Maja Kabiljo
>Assignee: Maja Kabiljo
>Priority: Major
>
> Using counters added in GIRAPH-1205 we were able to confirm that resending 
> network requests after timeout almost never succeeds, so add an option to 
> fail early instead of keep trying to resend these network requests 
> indefinitely.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GIRAPH-1211) Make retrying to send network requests after timeout optional

2018-11-06 Thread Maja Kabiljo (JIRA)
Maja Kabiljo created GIRAPH-1211:


 Summary: Make retrying to send network requests after timeout 
optional
 Key: GIRAPH-1211
 URL: https://issues.apache.org/jira/browse/GIRAPH-1211
 Project: Giraph
  Issue Type: New Feature
Reporter: Maja Kabiljo
Assignee: Maja Kabiljo


Using counters added in GIRAPH-1205 we were able to confirm that resending 
network requests after timeout almost never succeeds, so add an option to fail 
early instead of keep trying to resend these network requests indefinitely.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)