Github user dlogothetis commented on the issue:
https://github.com/apache/giraph/pull/96
Can you also add a couple of comments about how this was tested?
---
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/96#discussion_r239255770
--- Diff:
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
@@ -1147,8 +1158,11 @@ private void
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/93#discussion_r231388167
--- Diff:
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
@@ -1006,18 +1013,21 @@ public boolean apply(RequestInfo
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/93#discussion_r231387974
--- Diff:
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java ---
@@ -690,6 +690,12 @@
new IntConfOption
GitHub user dlogothetis opened a pull request:
https://github.com/apache/giraph/pull/92
Deprecate some Hadoop profiles
Tests
- mvn -Phadoop_2 clean install
- mvn -Phadoop_1 clean install
- mvn -Phadoop_facebook clean install
- Ran set of jobs
You can merge this pull
GitHub user dlogothetis opened a pull request:
https://github.com/apache/giraph/pull/91
Remove the use of atomic counter in LongByteMappingStore
I don't see any particular value in this keeping this counter, which incurs
high overhead is it is accessed on every entry
Github user dlogothetis closed the pull request at:
https://github.com/apache/giraph/pull/89
---
GitHub user dlogothetis opened a pull request:
https://github.com/apache/giraph/pull/90
Upgrade to Java 8
Set Java 8 as the minimum requirement.
Tests
- mvn clean install
- Ran a number of jobs
You can merge this pull request into a Git repository by running
GitHub user dlogothetis opened a pull request:
https://github.com/apache/giraph/pull/89
Fix in HadoopKryo to support higher java versions
The code inside HadoopKryo parses the java.version property in a way that
expects a single digit minor java version, e.g. 1.9, which won't work
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/87#discussion_r226026086
--- Diff:
giraph-core/src/main/java/org/apache/giraph/edge/ByteArrayEdges.java ---
@@ -94,6 +94,9 @@ public void add(Edge edge) {
} catch
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/87#discussion_r225302450
--- Diff:
giraph-core/src/main/java/org/apache/giraph/edge/ByteArrayEdges.java ---
@@ -94,6 +94,9 @@ public void add(Edge edge) {
} catch
Github user dlogothetis commented on the issue:
https://github.com/apache/giraph/pull/87
@aanchal204, did we try to reproduce this and verify the exception is
caught?
---
GitHub user dlogothetis opened a pull request:
https://github.com/apache/giraph/pull/84
Fix BspServiceMaster bug
Occasionally, BspServiceMaster fails to detect that a worker finished a
superstep (e.g. input superstep, or a compute supestep). As a result, the job
may get stuck
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/84#discussion_r218507979
--- Diff:
giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java ---
@@ -1379,9 +1379,15 @@ private boolean barrierOnWorkerList(String
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/84#discussion_r218556285
--- Diff:
giraph-core/src/main/java/org/apache/giraph/master/BspServiceMaster.java ---
@@ -1379,9 +1379,15 @@ private boolean barrierOnWorkerList(String
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/83#discussion_r218552959
--- Diff:
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
@@ -966,22 +991,23 @@ public boolean apply(RequestInfo requestInfo
16 matches
Mail list logo
