[jira] [Commented] (GIRAPH-1168) Instantiate OutEdges through Factory class

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349528#comment-16349528
 ] 

Hudson commented on GIRAPH-1168:


FAILURE: Integrated in Jenkins build Giraph-trunk-Commit #1725 (See 
[https://builds.apache.org/job/Giraph-trunk-Commit/1725/])
GIRAPH-1168 (majakabiljo: 
[http://git-wip-us.apache.org/repos/asf?p=giraph.git=commit=1f959d076ed7f29c3f8a5c6e99cbfcc62c1058d9])
* (edit) giraph-core/src/main/java/org/apache/giraph/conf/GiraphConstants.java
* (add) 
giraph-core/src/main/java/org/apache/giraph/factories/DefaultInputOutEdgesFactory.java
* (edit) 
giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java
* (add) 
giraph-core/src/main/java/org/apache/giraph/factories/DefaultOutEdgesFactory.java
* (add) 
giraph-core/src/main/java/org/apache/giraph/factories/OutEdgesFactory.java


> Instantiate OutEdges through Factory class
> --
>
> Key: GIRAPH-1168
> URL: https://issues.apache.org/jira/browse/GIRAPH-1168
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Dionysios Logothetis
>Priority: Major
>
> Sometimes the instantiation of an OutEdges implementation might have large 
> overhead, e.g. if it access the configuration.  Instead of creating it 
> directly, introduce a factory class that can be instantiated once. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GIRAPH-1168) Instantiate OutEdges through Factory class

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349412#comment-16349412
 ] 

ASF GitHub Bot commented on GIRAPH-1168:


Github user asfgit closed the pull request at:

https://github.com/apache/giraph/pull/57


> Instantiate OutEdges through Factory class
> --
>
> Key: GIRAPH-1168
> URL: https://issues.apache.org/jira/browse/GIRAPH-1168
> Project: Giraph
>  Issue Type: New Feature
>Reporter: Dionysios Logothetis
>Priority: Major
>
> Sometimes the instantiation of an OutEdges implementation might have large 
> overhead, e.g. if it access the configuration.  Instead of creating it 
> directly, introduce a factory class that can be instantiated once. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (GIRAPH-1168) Instantiate OutEdges through Factory class

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GIRAPH-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347079#comment-16347079
 ] 

ASF GitHub Bot commented on GIRAPH-1168:


GitHub user dlogothetis opened a pull request:

https://github.com/apache/giraph/pull/57

Outedges factory

Sometimes the instantiation of an OutEdges implementation might have large 
overhead, e.g. if it access the configuration.  Instead of creating it 
directly, introduce a factory class that can be instantiated once. 

https://issues.apache.org/jira/browse/GIRAPH-1168

Testing:
- mvn clean install
- internal unit tests & snapshot tests
- run with large job with custom OutEdges factory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dlogothetis/giraph outedges_factory

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/giraph/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit 9a8b0e33b58525e7fcab99ddbf80d1cb1767250a
Author: Dionysios Logothetis 
Date:   2018-01-31T00:12:39Z

Create OutEdges instances through factory class

commit 684010024a57e463ca88d3c0e189ca7d5c7b46fc
Author: Dionysios Logothetis 
Date:   2018-01-31T16:08:33Z

Add factory for input OutEdges




> Instantiate OutEdges through Factory class
> --
>
> Key: GIRAPH-1168
> URL: https://issues.apache.org/jira/browse/GIRAPH-1168
> Project: Giraph
>  Issue Type: Improvement
>Reporter: Dionysios Logothetis
>Priority: Major
>
> Sometimes the instantiation of an OutEdges implementation might have large 
> overhead, e.g. if it access the configuration.  Instead of creating it 
> directly, introduce a factory class that can be instantiated once. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)