autumnust commented on a change in pull request #2991:
URL: https://github.com/apache/incubator-gobblin/pull/2991#discussion_r459135019
##########
File path:
gobblin-utility/src/main/java/org/apache/gobblin/util/PropertiesUtils.java
##########
@@ -20,14 +20,17 @@
import java.io.IOException;
import java.io.StringReader;
import java.io.StringWriter;
+import java.util.Comparator;
import java.util.Map;
import java.util.Properties;
+import java.util.stream.Collectors;
import org.apache.commons.lang3.StringUtils;
import com.google.common.base.Optional;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableMap;
+import com.typesafe.config.Config;
Review comment:
is this being used?
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java
##########
@@ -122,8 +122,7 @@ public static void submitJobToQueue(
static void waitJobInitialization(
HelixManager helixManager,
String workFlowName,
- String jobName,
- long timeoutMillis) throws Exception {
Review comment:
why removing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
