zxcware opened a new pull request #2583: [GOBBLIN-716] Add lineage in FileBasedSource URL: https://github.com/apache/incubator-gobblin/pull/2583 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. - https://issues.apache.org/jira/browse/GOBBLIN-716 ### Description - [x] Here are some details about my PR: - Add lineage in `FileBasedSource` - By default, `FileBasedSource` marks dataset level source lineage - A `PartitionedFileSourceBase` marks partition level source lineage - Fix destinations overwritten in `LineageInfo.putDestination(List<Descriptor> descriptors, int branchId, State state)`. Multiple calls should append given descriptors ### Tests - [x] My PR adds the following unit tests: - `FileBasedSourceTest.testLineageInfo` covers source lineage info is set properly in `AvroFileSource` and a `PartitionedFileSourceBase` - `RegexBasedPartitionedRetrieverTest.testSnapshotRege` tests `FileInfo` object gets the correct partition name - `LineageEventTest.testMultiPuts` covers descriptors are appended not overwritten ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
