[jira] [Work logged] (GOBBLIN-725) add a mysql based job-status store
[ https://issues.apache.org/jira/browse/GOBBLIN-725?focusedWorklogId=224026=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224026 ] ASF GitHub Bot logged work on GOBBLIN-725: -- Author: ASF GitHub Bot Created on: 06/Apr/19 08:26 Start Date: 06/Apr/19 08:26 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2592: [GOBBLIN-725] add a mysql based job status retriever URL: https://github.com/apache/incubator-gobblin/pull/2592#discussion_r272788508 ## File path: gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java ## @@ -135,32 +135,6 @@ public FsJobStatusRetriever(Config config) { } } - /** - * - * @param jobState instance of {@link State} - * @return deserialize {@link State} into a {@link JobStatus}. - */ - private JobStatus getJobStatus(State jobState) { Review comment: did u mean to remove this method? its still being used in same class. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 224026) Time Spent: 20m (was: 10m) > add a mysql based job-status store > -- > > Key: GOBBLIN-725 > URL: https://issues.apache.org/jira/browse/GOBBLIN-725 > Project: Apache Gobblin > Issue Type: Improvement >Reporter: Arjun Singh Bora >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2592: [GOBBLIN-725] add a mysql based job status retriever
jhsenjaliya commented on a change in pull request #2592: [GOBBLIN-725] add a mysql based job status retriever URL: https://github.com/apache/incubator-gobblin/pull/2592#discussion_r272788508 ## File path: gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java ## @@ -135,32 +135,6 @@ public FsJobStatusRetriever(Config config) { } } - /** - * - * @param jobState instance of {@link State} - * @return deserialize {@link State} into a {@link JobStatus}. - */ - private JobStatus getJobStatus(State jobState) { Review comment: did u mean to remove this method? its still being used in same class. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services