[jira] [Work logged] (GOBBLIN-880) Bump CouchbaseWriter Couchbase SDK version + write docs + cert based auth + enable TTL + dnsSrv
[ https://issues.apache.org/jira/browse/GOBBLIN-880?focusedWorklogId=313455=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313455 ] ASF GitHub Bot logged work on GOBBLIN-880: -- Author: ASF GitHub Bot Created on: 17/Sep/19 03:25 Start Date: 17/Sep/19 03:25 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2734: GOBBLIN-880 Bump CouchbaseWriter Couchbase SDK version + write docs +… URL: https://github.com/apache/incubator-gobblin/pull/2734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 313455) Remaining Estimate: 167h 20m (was: 167.5h) Time Spent: 40m (was: 0.5h) > Bump CouchbaseWriter Couchbase SDK version + write docs + cert based auth + > enable TTL + dnsSrv > --- > > Key: GOBBLIN-880 > URL: https://issues.apache.org/jira/browse/GOBBLIN-880 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-couchbase >Reporter: Michael A Menarguez >Assignee: Shirshanka Das >Priority: Major > Labels: Couchbase > Fix For: 0.15.0 > > Original Estimate: 168h > Time Spent: 40m > Remaining Estimate: 167h 20m > > h1. h1. CURRENT ISSUES > Currently CouchbaseWriter.java lacks the ability to do the following: > # Use certificate based authentication > # Set document expiry (TTL) > ** based on write time > ** based on an offset specified field contained in the record's data (JSON) > ** (WILL NOT ADRESS) set expiry based on a field contained in the record's > data > # Set DNS SRV for bootstrap host discovery setting > # Missing documentation on CouchbaseWriter usage > # Testing does not bring in CouchbaseMock correctly and causes problems > while bumping com.couchbase.client:java-client > h1. h1. PROPOSED SOLUTIONS > # Add logic to connect using certificate based auth to the buckets (Will > need to bump com.couchbase.client:java-client to a newer version like 2.7.6) > and associated configs > # TTL implementation > ## Add configs to allow setting a TTL (documentTTL) and also specify the > timeunits (documentTTLUnits) of these settings > ## Add logic to specify the path to key to the field containing the source > timestamp (documentTTLOriginField) and its units (documentTTLOriginUnits) to > disambiguate between UNIX (sec) timestamps and other formats like timestamps > in milliseconds. > ## N/A but logic would be similar to (2) > # Add missing dnsSrv config > # Write proper documentation > # Bring in CouchbaseMock from Gradle and adapt existing unit tests. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Resolved] (GOBBLIN-880) Bump CouchbaseWriter Couchbase SDK version + write docs + cert based auth + enable TTL + dnsSrv
[ https://issues.apache.org/jira/browse/GOBBLIN-880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hung Tran resolved GOBBLIN-880. --- Fix Version/s: 0.15.0 Resolution: Fixed Issue resolved by pull request #2734 [https://github.com/apache/incubator-gobblin/pull/2734] > Bump CouchbaseWriter Couchbase SDK version + write docs + cert based auth + > enable TTL + dnsSrv > --- > > Key: GOBBLIN-880 > URL: https://issues.apache.org/jira/browse/GOBBLIN-880 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-couchbase >Reporter: Michael A Menarguez >Assignee: Shirshanka Das >Priority: Major > Labels: Couchbase > Fix For: 0.15.0 > > Original Estimate: 168h > Time Spent: 40m > Remaining Estimate: 167h 20m > > h1. h1. CURRENT ISSUES > Currently CouchbaseWriter.java lacks the ability to do the following: > # Use certificate based authentication > # Set document expiry (TTL) > ** based on write time > ** based on an offset specified field contained in the record's data (JSON) > ** (WILL NOT ADRESS) set expiry based on a field contained in the record's > data > # Set DNS SRV for bootstrap host discovery setting > # Missing documentation on CouchbaseWriter usage > # Testing does not bring in CouchbaseMock correctly and causes problems > while bumping com.couchbase.client:java-client > h1. h1. PROPOSED SOLUTIONS > # Add logic to connect using certificate based auth to the buckets (Will > need to bump com.couchbase.client:java-client to a newer version like 2.7.6) > and associated configs > # TTL implementation > ## Add configs to allow setting a TTL (documentTTL) and also specify the > timeunits (documentTTLUnits) of these settings > ## Add logic to specify the path to key to the field containing the source > timestamp (documentTTLOriginField) and its units (documentTTLOriginUnits) to > disambiguate between UNIX (sec) timestamps and other formats like timestamps > in milliseconds. > ## N/A but logic would be similar to (2) > # Add missing dnsSrv config > # Write proper documentation > # Bring in CouchbaseMock from Gradle and adapt existing unit tests. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [incubator-gobblin] asfgit closed pull request #2734: GOBBLIN-880 Bump CouchbaseWriter Couchbase SDK version + write docs +…
asfgit closed pull request #2734: GOBBLIN-880 Bump CouchbaseWriter Couchbase SDK version + write docs +… URL: https://github.com/apache/incubator-gobblin/pull/2734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-gobblin] yukuai518 commented on issue #2734: GOBBLIN-880 Bump CouchbaseWriter Couchbase SDK version + write docs +…
yukuai518 commented on issue #2734: GOBBLIN-880 Bump CouchbaseWriter Couchbase SDK version + write docs +… URL: https://github.com/apache/incubator-gobblin/pull/2734#issuecomment-531989224 Thanks @menarguez! The PR looks backward compatible and the documentation for couchbase is pretty nice. Could you provide us more context why you want to bump the SDK version? Is the expiration feature require the version bump, or the test facilities needs that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-880) Bump CouchbaseWriter Couchbase SDK version + write docs + cert based auth + enable TTL + dnsSrv
[ https://issues.apache.org/jira/browse/GOBBLIN-880?focusedWorklogId=313343=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313343 ] ASF GitHub Bot logged work on GOBBLIN-880: -- Author: ASF GitHub Bot Created on: 16/Sep/19 22:55 Start Date: 16/Sep/19 22:55 Worklog Time Spent: 10m Work Description: yukuai518 commented on issue #2734: GOBBLIN-880 Bump CouchbaseWriter Couchbase SDK version + write docs +… URL: https://github.com/apache/incubator-gobblin/pull/2734#issuecomment-531989224 Thanks @menarguez! The PR looks backward compatible and the documentation for couchbase is pretty nice. Could you provide us more context why you want to bump the SDK version? Is the expiration feature require the version bump, or the test facilities needs that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 313343) Remaining Estimate: 167.5h (was: 167h 40m) Time Spent: 0.5h (was: 20m) > Bump CouchbaseWriter Couchbase SDK version + write docs + cert based auth + > enable TTL + dnsSrv > --- > > Key: GOBBLIN-880 > URL: https://issues.apache.org/jira/browse/GOBBLIN-880 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-couchbase >Reporter: Michael A Menarguez >Assignee: Shirshanka Das >Priority: Major > Labels: Couchbase > Original Estimate: 168h > Time Spent: 0.5h > Remaining Estimate: 167.5h > > h1. h1. CURRENT ISSUES > Currently CouchbaseWriter.java lacks the ability to do the following: > # Use certificate based authentication > # Set document expiry (TTL) > ** based on write time > ** based on an offset specified field contained in the record's data (JSON) > ** (WILL NOT ADRESS) set expiry based on a field contained in the record's > data > # Set DNS SRV for bootstrap host discovery setting > # Missing documentation on CouchbaseWriter usage > # Testing does not bring in CouchbaseMock correctly and causes problems > while bumping com.couchbase.client:java-client > h1. h1. PROPOSED SOLUTIONS > # Add logic to connect using certificate based auth to the buckets (Will > need to bump com.couchbase.client:java-client to a newer version like 2.7.6) > and associated configs > # TTL implementation > ## Add configs to allow setting a TTL (documentTTL) and also specify the > timeunits (documentTTLUnits) of these settings > ## Add logic to specify the path to key to the field containing the source > timestamp (documentTTLOriginField) and its units (documentTTLOriginUnits) to > disambiguate between UNIX (sec) timestamps and other formats like timestamps > in milliseconds. > ## N/A but logic would be similar to (2) > # Add missing dnsSrv config > # Write proper documentation > # Bring in CouchbaseMock from Gradle and adapt existing unit tests. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [incubator-gobblin] asfgit closed pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode
asfgit closed pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode URL: https://github.com/apache/incubator-gobblin/pull/2729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode
codecov-io edited a comment on issue #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode URL: https://github.com/apache/incubator-gobblin/pull/2729#issuecomment-529597441 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=h1) Report > Merging [#2729](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/a409908079df873ba0d5a465df3e682be0e0085d?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `70.42%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2729 +/- ## + Coverage 44.99% 45.08% +0.08% - Complexity 8742 8759 +17 Files 1884 1886 +2 Lines 7029570377 +82 Branches 7715 7718 +3 + Hits 3162931726 +97 + Misses3573535709 -26 - Partials 2931 2942 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...apache/gobblin/cluster/ContainerHealthMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ29udGFpbmVySGVhbHRoTWV0cmljcy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../apache/gobblin/cluster/GobblinClusterManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNYW5hZ2VyLmphdmE=) | `53.91% <0%> (-0.51%)` | `27 <0> (ø)` | | | [...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/gobblin/yarn/GobblinApplicationMaster.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbkFwcGxpY2F0aW9uTWFzdGVyLmphdmE=) | `18.84% <100%> (+2.42%)` | `3 <0> (ø)` | :arrow_down: | | [...n/java/org/apache/gobblin/yarn/YarnHelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkhlbGl4VXRpbHMuamF2YQ==) | `20% <100%> (+2.75%)` | `3 <1> (+1)` | :arrow_up: | | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `64.35% <50%> (-0.91%)` | `28 <1> (-1)` | | | [...gobblin/cluster/ContainerHealthMetricsService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ29udGFpbmVySGVhbHRoTWV0cmljc1NlcnZpY2UuamF2YQ==) | `78.57% <78.57%> (ø)` | `5 <5> (?)` | | | ... and [18 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? =
[jira] [Work logged] (GOBBLIN-875) Emit container health metrics when running in cluster mode
[ https://issues.apache.org/jira/browse/GOBBLIN-875?focusedWorklogId=313307=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313307 ] ASF GitHub Bot logged work on GOBBLIN-875: -- Author: ASF GitHub Bot Created on: 16/Sep/19 21:30 Start Date: 16/Sep/19 21:30 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode URL: https://github.com/apache/incubator-gobblin/pull/2729#issuecomment-529597441 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=h1) Report > Merging [#2729](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/a409908079df873ba0d5a465df3e682be0e0085d?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `70.42%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#2729 +/- ## + Coverage 44.99% 45.08% +0.08% - Complexity 8742 8759 +17 Files 1884 1886 +2 Lines 7029570377 +82 Branches 7715 7718 +3 + Hits 3162931726 +97 + Misses3573535709 -26 - Partials 2931 2942 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2729?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...che/gobblin/yarn/GobblinYarnConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...apache/gobblin/cluster/ContainerHealthMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ29udGFpbmVySGVhbHRoTWV0cmljcy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [.../apache/gobblin/cluster/GobblinClusterManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNYW5hZ2VyLmphdmE=) | `53.91% <0%> (-0.51%)` | `27 <0> (ø)` | | | [...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/gobblin/aws/GobblinAWSTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1hd3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYXdzL0dvYmJsaW5BV1NUYXNrUnVubmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/gobblin/yarn/GobblinApplicationMaster.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbkFwcGxpY2F0aW9uTWFzdGVyLmphdmE=) | `18.84% <100%> (+2.42%)` | `3 <0> (ø)` | :arrow_down: | | [...n/java/org/apache/gobblin/yarn/YarnHelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFybkhlbGl4VXRpbHMuamF2YQ==) | `20% <100%> (+2.75%)` | `3 <1> (+1)` | :arrow_up: | | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `64.35% <50%> (-0.91%)` | `28 <1> (-1)` | | | [...gobblin/cluster/ContainerHealthMetricsService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2729/diff?src=pr=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvQ29udGFpbmVySGVhbHRoTWV0cmljc1NlcnZpY2UuamF2YQ==) | `78.57% <78.57%>
[jira] [Work logged] (GOBBLIN-875) Emit container health metrics when running in cluster mode
[ https://issues.apache.org/jira/browse/GOBBLIN-875?focusedWorklogId=313297=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313297 ] ASF GitHub Bot logged work on GOBBLIN-875: -- Author: ASF GitHub Bot Created on: 16/Sep/19 20:54 Start Date: 16/Sep/19 20:54 Worklog Time Spent: 10m Work Description: sv2000 commented on pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r324880686 ## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/ContainerHealthMetricsService.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.cluster; + +import java.lang.management.ManagementFactory; +import java.lang.management.MemoryMXBean; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicLong; + +import com.google.common.util.concurrent.AbstractScheduledService; +import com.google.common.util.concurrent.AtomicDouble; +import com.sun.management.OperatingSystemMXBean; +import com.typesafe.config.Config; + +import org.apache.gobblin.metrics.ContextAwareGauge; +import org.apache.gobblin.metrics.RootMetricContext; +import org.apache.gobblin.util.ConfigUtils; + + +/** + * A utility class that periodically emits system level metrics that report the health of the container. + * Reported metrics include CPU/Memory usage of the JVM, system load, file descriptors used etc. Review comment: Fixed the javadoc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 313297) Time Spent: 2h 40m (was: 2.5h) > Emit container health metrics when running in cluster mode > -- > > Key: GOBBLIN-875 > URL: https://issues.apache.org/jira/browse/GOBBLIN-875 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-cluster >Affects Versions: 0.15.0 >Reporter: Sudarshan Vasudevan >Assignee: Hung Tran >Priority: Major > Fix For: 0.15.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > This task implements a service that emits CPU/Memory health metrics from the > JVM when running in the cluster mode. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode
sv2000 commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r324880686 ## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/ContainerHealthMetricsService.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.cluster; + +import java.lang.management.ManagementFactory; +import java.lang.management.MemoryMXBean; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicLong; + +import com.google.common.util.concurrent.AbstractScheduledService; +import com.google.common.util.concurrent.AtomicDouble; +import com.sun.management.OperatingSystemMXBean; +import com.typesafe.config.Config; + +import org.apache.gobblin.metrics.ContextAwareGauge; +import org.apache.gobblin.metrics.RootMetricContext; +import org.apache.gobblin.util.ConfigUtils; + + +/** + * A utility class that periodically emits system level metrics that report the health of the container. + * Reported metrics include CPU/Memory usage of the JVM, system load, file descriptors used etc. Review comment: Fixed the javadoc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work logged] (GOBBLIN-875) Emit container health metrics when running in cluster mode
[ https://issues.apache.org/jira/browse/GOBBLIN-875?focusedWorklogId=313294=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-313294 ] ASF GitHub Bot logged work on GOBBLIN-875: -- Author: ASF GitHub Bot Created on: 16/Sep/19 20:48 Start Date: 16/Sep/19 20:48 Worklog Time Spent: 10m Work Description: autumnust commented on pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r324775801 ## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/ContainerHealthMetricsService.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.cluster; + +import java.lang.management.ManagementFactory; +import java.lang.management.MemoryMXBean; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicLong; + +import com.google.common.util.concurrent.AbstractScheduledService; +import com.google.common.util.concurrent.AtomicDouble; +import com.sun.management.OperatingSystemMXBean; +import com.typesafe.config.Config; + +import org.apache.gobblin.metrics.ContextAwareGauge; +import org.apache.gobblin.metrics.RootMetricContext; +import org.apache.gobblin.util.ConfigUtils; + + +/** + * A utility class that periodically emits system level metrics that report the health of the container. + * Reported metrics include CPU/Memory usage of the JVM, system load, file descriptors used etc. Review comment: Which parameters are concerning with file descriptors? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 313294) Time Spent: 2.5h (was: 2h 20m) > Emit container health metrics when running in cluster mode > -- > > Key: GOBBLIN-875 > URL: https://issues.apache.org/jira/browse/GOBBLIN-875 > Project: Apache Gobblin > Issue Type: Improvement > Components: gobblin-cluster >Affects Versions: 0.15.0 >Reporter: Sudarshan Vasudevan >Assignee: Hung Tran >Priority: Major > Fix For: 0.15.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > This task implements a service that emits CPU/Memory health metrics from the > JVM when running in the cluster mode. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode
autumnust commented on a change in pull request #2729: GOBBLIN-875: Emit container health metrics when running in cluster mode URL: https://github.com/apache/incubator-gobblin/pull/2729#discussion_r324775801 ## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/ContainerHealthMetricsService.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + *http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.cluster; + +import java.lang.management.ManagementFactory; +import java.lang.management.MemoryMXBean; +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicLong; + +import com.google.common.util.concurrent.AbstractScheduledService; +import com.google.common.util.concurrent.AtomicDouble; +import com.sun.management.OperatingSystemMXBean; +import com.typesafe.config.Config; + +import org.apache.gobblin.metrics.ContextAwareGauge; +import org.apache.gobblin.metrics.RootMetricContext; +import org.apache.gobblin.util.ConfigUtils; + + +/** + * A utility class that periodically emits system level metrics that report the health of the container. + * Reported metrics include CPU/Memory usage of the JVM, system load, file descriptors used etc. Review comment: Which parameters are concerning with file descriptors? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
