jhsenjaliya commented on a change in pull request #2592: [GOBBLIN-725] add a mysql based job status retriever URL: https://github.com/apache/incubator-gobblin/pull/2592#discussion_r272788508
########## File path: gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/FsJobStatusRetriever.java ########## @@ -135,32 +135,6 @@ public FsJobStatusRetriever(Config config) { } } - /** - * - * @param jobState instance of {@link State} - * @return deserialize {@link State} into a {@link JobStatus}. - */ - private JobStatus getJobStatus(State jobState) { Review comment: did u mean to remove this method? its still being used in same class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services