arjun4084346 opened a new pull request #2561: [GOBBLIN-689] catch unchecked exceptions in KafkaSource URL: https://github.com/apache/incubator-gobblin/pull/2561 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! @htran1 please review ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description - [x] Here are some details about my PR, including screenshots (if applicable): workunit creation failures are not catching unchecked exception as of now. this may lead to adding a partition to map `partitionsToBeProcessed` but without adding it to list `workUnits` which is used to pack workunits into multiWorkUnits. this results in not running ingestion for some partitions and next run will not find high watermarks for those partition which in turn result in using earliestOffset and thus possible data loss. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: changes are trivial ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
