[GitHub] htran1 commented on a change in pull request #2556: GOBBLIN-684: Ensure buffered messages are flushed before close() in K…

2019-02-19 Thread GitBox
htran1 commented on a change in pull request #2556: GOBBLIN-684: Ensure buffered messages are flushed before close() in K… URL: https://github.com/apache/incubator-gobblin/pull/2556#discussion_r258348552 ## File path: gobblin-modules/gobblin-kafka-08/src/main/java/org/apache/gobbli

[GitHub] htran1 commented on a change in pull request #2556: GOBBLIN-684: Ensure buffered messages are flushed before close() in K…

2019-02-18 Thread GitBox
htran1 commented on a change in pull request #2556: GOBBLIN-684: Ensure buffered messages are flushed before close() in K… URL: https://github.com/apache/incubator-gobblin/pull/2556#discussion_r257847795 ## File path: gobblin-modules/gobblin-kafka-08/src/main/java/org/apache/gobbli

[GitHub] htran1 commented on a change in pull request #2556: GOBBLIN-684: Ensure buffered messages are flushed before close() in K…

2019-02-18 Thread GitBox
htran1 commented on a change in pull request #2556: GOBBLIN-684: Ensure buffered messages are flushed before close() in K… URL: https://github.com/apache/incubator-gobblin/pull/2556#discussion_r257845882 ## File path: gobblin-modules/gobblin-kafka-08/src/main/java/org/apache/gobbli