[ 
https://issues.apache.org/jira/browse/GORA-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867925#comment-13867925
 ] 

Renato Javier MarroquĂ­n Mogrovejo commented on GORA-94:
-------------------------------------------------------

Hi [~alparslan.avci]! 

First of all, thank you very much for your contributions! They are awesome! (:
Just one thing about your patch, even though I think these changes are already 
committed. You said that for not facing the NPEs you set the values to its 
default value, so users will always have to set the fields with at least some 
value i.e. if the users forget to set these values they will get the NPE, am I 
understanding this correctly? if so, then we should try fixing the possibility 
of the users not having to specify a default value if it is null. Do you know 
what I mean?

> Upgrade to Apache Avro 1.7.x
> ----------------------------
>
>                 Key: GORA-94
>                 URL: https://issues.apache.org/jira/browse/GORA-94
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: build process, storage
>    Affects Versions: 0.2
>            Reporter: Lewis John McGibbney
>            Assignee: Ed Kohlwey
>             Fix For: 0.4
>
>         Attachments: GORA-94-v2.patch, GORA-94-v3.patch, GORA-94-v4.patch, 
> GORA-94.patch, GORA-94v10.patch, GORA-94v6.diff, GORA-94v7.patch, 
> GORA-94v8.patch, GORA-94v9.patch, GORA_94v5.patch
>
>
> I am not sure what this involves as of yet but I have a small feeling that 
> it's going to be some reasonably major work...  



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to