Re: [GSoC 2018] Ignite backend - Status

Hi Carlos, This is great work..!!! I have gone through your code and added some comments. Please have a look at them and let me know if you need further clarifications. Regards, Nishadi On Sun, Jul 8, 2018 at 1:04 AM Lewis John Mcgibbney < lewis.mcgibb...@gmail.com> wrote: > Hi Carlos, I’ll

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202534472 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544458#comment-16544458 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544455#comment-16544455 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202533866 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544454#comment-16544454 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202533833 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202521431 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/package-info.java --- @@ -0,0 +1,20 @@ +/** --- End diff -- Shall we make sure

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202522061 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202522672 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteParameters.java --- @@ -0,0 +1,139 @@ +/* + * Copyright 2018 The Apache

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544437#comment-16544437 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202521891 --- Diff: gora-ignite/src/examples/java/.gitignore --- @@ -0,0 +1,15 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202522015 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1658#comment-1658 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1650#comment-1650 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1653#comment-1653 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202522577 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteParameters.java --- @@ -0,0 +1,139 @@ +/* + * Copyright 2018 The Apache

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544439#comment-16544439 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1657#comment-1657 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1651#comment-1651 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1652#comment-1652 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202521966 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1655#comment-1655 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1654#comment-1654 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202522595 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteParameters.java --- @@ -0,0 +1,139 @@ +/* + * Copyright 2018 The Apache

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202521872 --- Diff: nbactions.xml --- @@ -0,0 +1,13 @@ + --- End diff -- I think this NetBeans related file can be removed. ---

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202522746 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202521701 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/utils/IgniteSQLBuilder.java --- @@ -0,0 +1,238 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1656#comment-1656 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request: