[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

2018-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546752#comment-16546752 ] ASF GitHub Bot commented on GORA-535: - Github user nishadi commented on a diff in the pull request:

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-17 Thread nishadi
Github user nishadi commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r203057892 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

Re: [GSoC 2018] Ignite backend - Status

2018-07-17 Thread Alfonso Nishikawa
@Lewis, @Nishadi, wow you did a very thorough review, congrats =) I was liking your comments, but I guess is better just to say I subscribe all your coments (except one, but already commented :) Loooking forward those changes. Carlos, cheer up! :) Thanks! Regards, Alfonso 2018-07-15 7:05

[jira] [Commented] (GORA-535) Add a data store for Apache Ignite

2018-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GORA-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546189#comment-16546189 ] ASF GitHub Bot commented on GORA-535: - Github user alfonsonishikawa commented on a diff in the pull

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-17 Thread alfonsonishikawa
Github user alfonsonishikawa commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202935976 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache

Re: [GSoC 2018] Redis Store Update

2018-07-17 Thread Alfonso Nishikawa
Hi, Talat! ​Sorry for the delay answering Cheer up! And thanks for the work :) Regards, Alfonso