[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-08-21 Thread carlosrmng
Github user carlosrmng commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r211491705 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteParameters.java --- @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache

[GitHub] gora issue #134: GORA-535 Add a data store for Apache Ignite

2018-07-18 Thread carlosrmng
Github user carlosrmng commented on the issue: https://github.com/apache/gora/pull/134 Hi @lewismc @nishadi @alfonsonishikawa Thanks for your feedback I will start working on the issues. ---

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-07 Thread carlosrmng
GitHub user carlosrmng opened a pull request: https://github.com/apache/gora/pull/134 GORA-535 Add a data store for Apache Ignite This PR adds the Apache Ignite data store to Gora. Some issues with this PR: -All DataStoreTestBase tests are passing. -Documentation

[GitHub] gora issue #133: GORA-536: Avoid calling Class#newInstance

2018-05-13 Thread carlosrmng
Github user carlosrmng commented on the issue: https://github.com/apache/gora/pull/133 Hi @lewismc I found multiple classes and interfaces that define their own newInstance() method which are not directly affected by the issue. I used my IDE's 'find usages' feature to search

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

2018-05-12 Thread carlosrmng
Github user carlosrmng commented on the issue: https://github.com/apache/gora/pull/132 Is this okay for merge? ---

[GitHub] gora pull request #133: GORA-536: Avoid calling Class#newInstance

2018-05-12 Thread carlosrmng
GitHub user carlosrmng opened a pull request: https://github.com/apache/gora/pull/133 GORA-536: Avoid calling Class#newInstance When using reflexion use `getDeclaredConstructor().newInstance()` instead of `Class::newInstance` because it may throw undeclared checked exceptions. You

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

2018-03-27 Thread carlosrmng
Github user carlosrmng commented on the issue: https://github.com/apache/gora/pull/132 Thanks for your support, I will start working in some tests and documentation. ---

[GitHub] gora pull request #132: Gora-444 : Add #size() to Result API

2018-03-22 Thread carlosrmng
GitHub user carlosrmng opened a pull request: https://github.com/apache/gora/pull/132 Gora-444 : Add #size() to Result API This PR adds #size() to Result API, it implements size() for existing backends. The complete disscusion can be found in [GORA-444](https://issues.apache.org