[GitHub] gora pull request #140: GORA-548 Apache Flink support for Gora

2018-11-29 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/140#discussion_r237628912 --- Diff: gora-core/pom.xml --- @@ -171,6 +187,12 @@ hadoop-minicluster test + --- End diff -- Why

[GitHub] gora issue #136: GORA-534 Upgrade HBase to 2.1.1

2018-11-28 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/136 Tested locally and everything passes @alfonsonishikawa any comments? ---

[GitHub] gora issue #138: GORA-543 Upgrade Apache parent POM to version 21

2018-11-28 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/138 +1 ---

[GitHub] gora issue #134: GORA-535 Add a data store for Apache Ignite

2018-10-04 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/134 np @djkevincr I just wanted to make sure we got it there as well :) Excellent job on this one folks.. really. ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543455 --- Diff: gora-pig/src/test/examples/README.txt --- @@ -0,0 +1,9 @@ + --- End diff -- Can you make this an .md file? ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542930 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/ResourceFieldSchemaWithIndex.java --- @@ -0,0 +1,31 @@ +package org.apache.gora.pig; --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222540948 --- Diff: gora-compiler/src/main/java/org/apache/gora/compiler/GoraCompiler.java --- @@ -86,6 +88,31 @@ public static void compileSchema(File[] srcFiles, File

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541609 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java --- @@ -251,6 +254,70 @@ D getDataStore( Class dataStoreClass, Class keyClass

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542624 --- Diff: gora-pig/pom.xml --- @@ -0,0 +1,180 @@ + --- End diff -- License header. ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222540708 --- Diff: bin/compile-examples.sh --- @@ -36,8 +36,57 @@ DIR=$GORA_HOME/$MODULE/src/examples/avro/ OUTDIR=$GORA_HOME/$MODULE/src/examples/java

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543677 --- Diff: pom.xml --- @@ -757,9 +758,9 @@ gora-maven-plugin gora-mongodb gora-solr +gora-aerospike --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542669 --- Diff: gora-pig/pom.xml --- @@ -0,0 +1,180 @@ + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; +xmlns

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541705 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java --- @@ -412,7 +484,7 @@ public static String getMappingFile(Properties

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541077 --- Diff: gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm --- @@ -180,6 +180,11 @@ public class ${this.mangle($schema.getName

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543835 --- Diff: pom.xml --- @@ -1546,6 +1553,40 @@ ${orientqb.version} + + + org.apache.pig

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543728 --- Diff: pom.xml --- @@ -832,6 +833,12 @@ 1.0.1 2.5 + +0.16.0 +1.11-8 --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542415 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -734,14 +756,13 @@ private void setField(T persistent, Field field, List

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543239 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/mapreduce/PigGoraOutputFormat.java --- @@ -0,0 +1,86 @@ +package org.apache.gora.pig.mapreduce

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543267 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/udf/MapMerge.java --- @@ -0,0 +1,33 @@ +package org.apache.gora.pig.udf; --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541967 --- Diff: gora-core/src/main/java/org/apache/gora/store/DataStoreMetadataFactory.java --- @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542504 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseTableMetadata.java --- @@ -0,0 +1,27 @@ +package org.apache.gora.hbase.store

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541246 --- Diff: gora-core/src/examples/java/org/apache/gora/examples/generated/package-info.java --- @@ -1,20 +0,0 @@ -/** --- End diff -- Why

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542987 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/StorageConfiguration.java --- @@ -0,0 +1,140 @@ +package org.apache.gora.pig; --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542461 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStoreMetadataAnalyzer.java --- @@ -0,0 +1,75 @@ +package org.apache.gora.hbase.store

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542089 --- Diff: gora-goraci/src/main/java/org/apache/gora/goraci/generated/package-info.java --- @@ -1,21 +0,0 @@ -/** --- End diff -- Why remove? ---

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222541419 --- Diff: gora-core/src/main/java/org/apache/gora/persistency/Persistent.java --- @@ -113,4 +118,13 @@ * @return a new instance of the object

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543383 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/util/PersistentUtils.java --- @@ -0,0 +1,147 @@ +package org.apache.gora.pig.util; --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543248 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/udf/MapDeleteElements.java --- @@ -0,0 +1,67 @@ +package org.apache.gora.pig.udf; --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222542231 --- Diff: gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java --- @@ -80,15 +81,20 @@ * DataStore for HBase. Thread safe

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543177 --- Diff: gora-pig/src/main/java/org/apache/gora/pig/mapreduce/PigGoraOutputFormat.java --- @@ -0,0 +1,86 @@ +package org.apache.gora.pig.mapreduce

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543621 --- Diff: gora-pig/src/test/resources/gora.properties --- @@ -0,0 +1,4 @@ +gora.datastore.default=org.apache.gora.hbase.store.HBaseStore --- End diff

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543479 --- Diff: gora-pig/src/test/examples/example.pig --- @@ -0,0 +1,4 @@ +set job.name 'GoraStorage test' ; --- End diff -- License header

[GitHub] gora pull request #135: Goraexplorer needed changes

2018-10-03 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/135#discussion_r222543584 --- Diff: gora-pig/src/test/examples/example.pig --- @@ -0,0 +1,4 @@ +set job.name 'GoraStorage test' ; +register gora/*.jar ; +webpage = LOAD

[GitHub] gora issue #134: GORA-535 Add a data store for Apache Ignite

2018-10-03 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/134 @djkevincr @carlosrmng is this ready to merge? ---

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526802 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526754 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteMappingBuilder.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526790 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526771 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteMappingBuilder.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526799 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526796 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526747 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/utils/IgniteSQLBuilder.java --- @@ -0,0 +1,238 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526805 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526769 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteMappingBuilder.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202526785 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202523585 --- Diff: nbactions.xml --- @@ -0,0 +1,13 @@ + --- End diff -- Add Apache License header. ---

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202523567 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202523513 --- Diff: gora-ignite/pom.xml --- @@ -0,0 +1,182 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-ins

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202523561 --- Diff: gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java --- @@ -0,0 +1,578 @@ +/** + * Licensed to the Apache Software

[GitHub] gora pull request #134: GORA-535 Add a data store for Apache Ignite

2018-07-14 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/134#discussion_r202523485 --- Diff: gora-ignite/pom.xml --- @@ -0,0 +1,182 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-ins

[GitHub] gora issue #133: GORA-536: Avoid calling Class#newInstance

2018-05-13 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/133 +1 @djkevincr please merge ---

[GitHub] gora issue #133: GORA-536: Avoid calling Class#newInstance

2018-05-13 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/133 Hi @carlosrmng when grepping for presence of ```newInstance()```, I get many more hits ``` lmcgibbn@LMC-056430 /usr/local/gora(GORA-266) $ grep -lr "newInstance()" . ./gora-ac

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

2018-05-02 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/132 +1 ---

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

2018-04-03 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/130 +1 ---

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

2018-04-02 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/130 @alfonsonishikawa can you commit to master? ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

2018-03-27 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/132 Yep tests would be great. IMHO, as this is something we want to test for every Datastore, I suggest it be implemented within [DataStoreTestUtil.java](https://github.com/apache/gora/blob/master/gora

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

2018-03-25 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/132 I am +1 for committing this. @carlosrmng it would be great if we could add tests to [DataStoreTestBase.java](https://github.com/apache/gora/blob/master/gora-core/src/test/java/org/apache/gora/store

[GitHub] gora pull request #131: GORA-266 Lucene datastore for Gora

2018-03-23 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/131#discussion_r176891528 --- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java --- @@ -434,7 +432,7 @@ public static void writeBoolArray(DataOutput out, boolean

[GitHub] gora issue #130: GORA-530: Removed redundant logging on several try/catch

2018-03-23 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/130 @alfonsonishikawa @renato2099 I think this looks good. Tidies up Exception handling quite nicely. ---

[GitHub] gora issue #132: Gora-444 : Add #size() to Result API

2018-03-23 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/132 @carlosrmng great 👍 Can you please format 2 space indents the same as the other source code? Thanks ---

[GitHub] gora pull request #131: GORA-266 Lucene datastore for Gora

2018-03-22 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/131#discussion_r176596674 --- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java --- @@ -434,7 +432,7 @@ public static void writeBoolArray(DataOutput out, boolean

[GitHub] gora issue #131: GORA-266 Lucene datastore for Gora

2018-03-15 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/131 Thanks @renato2099 where are the comments? I don't see them. ---

[GitHub] gora pull request #131: GORA-266 Lucene datastore for Gora

2018-03-14 Thread lewismc
GitHub user lewismc opened a pull request: https://github.com/apache/gora/pull/131 GORA-266 Lucene datastore for Gora This PR updates the patch at https://issues.apache.org/jira/browse/GORA-266 and also upgrades the Lucene API's to match with 6.2.1 which is currently where

[GitHub] gora issue #127: GORA-530 : Reinstated exception throwing in DataStore and Q...

2018-02-26 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/127 I @alfonsonishikawa I think we should go ahead and merge this into master branch. It been sitting for long enough. +1 ---

[GitHub] gora issue #129: GORA-531 Upgrade Hbase version to 1.2.6

2018-02-13 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/129 +1 ---

[GitHub] gora issue #128: GORA-528 Upgrade Spark version to 2.2.1

2018-02-13 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/128 +1 ---

[GitHub] gora issue #125: GORA-529 Remove org/apache/gora/avro/mapreduce/FsInput.java

2018-01-15 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/125 I literally was just looking through the code and saw the comment. I then went over to the Avro source and basically undertook a diff of the Class and methods. ---

[GitHub] gora issue #126: Setting dirty with value -1 (11111111b) instead of -128(100...

2018-01-11 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/126 +1 LGTM ---

[GitHub] gora issue #126: Setting dirty with value -1 (11111111b) instead of -128(100...

2018-01-10 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/126 Any test? ---

[GitHub] gora pull request #125: GORA-529 Remove org/apache/gora/avro/mapreduce/FsInp...

2017-12-29 Thread lewismc
GitHub user lewismc opened a pull request: https://github.com/apache/gora/pull/125 GORA-529 Remove org/apache/gora/avro/mapreduce/FsInput.java This issue addresses https://issues.apache.org/jira/browse/GORA-529 You can merge this pull request into a Git repository by running

[GitHub] gora issue #94: Fixed issue GORA-503

2017-12-16 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/94 Any comments folks? ---

[GitHub] gora issue #123: Fix validation for persistentSchema in avro serialization

2017-09-21 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/123 Hi @madhawa-gunasekara can you please open a JIRA issue for this and then reference it here? Thank you ---

[GitHub] gora issue #122: Add Nishadi Kirielle as an Apache Gora developer

2017-09-16 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/122 +1 This is a trivial change so no need for a Jira issue. ---

[GitHub] gora issue #112: GORA-513 Add initial OrientDB datastore impl.

2017-09-05 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/112 ack > Sorry about the delays. absolutely no problems at all... the patch looks very good. ---

[GitHub] gora issue #112: GORA-513 Add initial OrientDB datastore impl.

2017-09-05 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/112 Hi @djkevincr I would like to move towards pushing a release candidate for Gora 0.8 soon. Having this module included in the release would be excellent. ---

[GitHub] gora issue #121: GORA-525: Add Java Doc

2017-09-05 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/121 Thank you @madhawa-gunasekara I've merged this alongside a bunch of other documentation such that we can move on with stabilizing Javadoc generation. There is still some more work to do, I will keep

[GitHub] gora issue #117: GORA-520 Add support to retrieve partitions in aerospike mo...

2017-08-14 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/117 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] gora issue #110: [WIP] GORA-497 : Rewrite Cassandra data store

2017-08-05 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/110 @madhawa-gunasekara what is the status of this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] gora issue #111: GORA-502 Implement Aerospike Data Store

2017-07-27 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/111 Can you guys possibly upgrade aerospike-client to most recent? http://search.maven.org/#artifactdetails|com.aerospike|aerospike-client|4.0.6|jar --- If your project is set up for it, you can

[GitHub] gora issue #112: GORA-513 Add initial OrientDB datastore impl.

2017-07-27 Thread lewismc
Github user lewismc commented on the issue: https://github.com/apache/gora/pull/112 Would be nice to get this into Gora @djkevincr We could potentially make a release in the near future. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] gora pull request #111: [WIP] GORA-502 Implement Aerospike Data Store

2017-07-26 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/111#discussion_r129631962 --- Diff: gora-aerospike/pom.xml --- @@ -71,6 +71,14 @@ +org.apache.maven.plugins +maven-surefire

[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store

2017-07-25 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r129359618 --- Diff: gora-cassandra-cql/src/examples/avro/cassandraKey.json --- @@ -0,0 +1,21 @@ +{ + "type": "record", + &

[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store

2017-06-23 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123814653 --- Diff: gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStoreWithNativeSerialization.java --- @@ -26,15 +26,20 @@ public

[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store

2017-06-23 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123814041 --- Diff: gora-cassandra-cql/pom.xml --- @@ -144,12 +144,28 @@ slf4j-log4j12

[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store

2017-06-23 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123814516 --- Diff: gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java --- @@ -148,7 +156,7 @@ public void

[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store

2017-06-23 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123813981 --- Diff: gora-cassandra-cql/pom.xml --- @@ -49,7 +49,7 @@ -17.0 +18.0 --- End diff -- Please

[GitHub] gora pull request #110: [WIP] GORA-497 : Rewrite Cassandra data store

2017-06-22 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r123556881 --- Diff: gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraQueryFactory.java --- @@ -0,0 +1,4 @@ +package

[GitHub] gora pull request #111: [WIP] GORA-502 Implement Aerospike Data Store

2017-06-20 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/111#discussion_r122997087 --- Diff: gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikeMappingBuilder.java --- @@ -0,0 +1,255 @@ +/** + * Licensed

[GitHub] gora pull request #111: [WIP] GORA-502 Implement Aerospike Data Store

2017-06-20 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/111#discussion_r122998610 --- Diff: pom.xml --- @@ -932,6 +934,11 @@ ${project.version} test-jar + +org.apache.gora

[GitHub] gora pull request #111: [WIP] GORA-502 Implement Aerospike Data Store

2017-06-20 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/111#discussion_r122998877 --- Diff: gora-aerospike/pom.xml --- @@ -0,0 +1,147 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLS

[GitHub] gora pull request #111: [WIP] GORA-502 Implement Aerospike Data Store

2017-06-20 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/111#discussion_r122997020 --- Diff: gora-aerospike/src/main/java/org/apache/gora/aerospike/store/AerospikeMappingBuilder.java --- @@ -0,0 +1,255 @@ +/** + * Licensed

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122811939 --- Diff: gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java --- @@ -0,0 +1,157 @@ +/* + * Licensed

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122808313 --- Diff: gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java --- @@ -0,0 +1,516 @@ +/* + * Licensed to the Apache

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122809055 --- Diff: gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java --- @@ -0,0 +1,516 @@ +/* + * Licensed to the Apache

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122809493 --- Diff: gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java --- @@ -0,0 +1,516 @@ +/* + * Licensed to the Apache

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122811683 --- Diff: gora-cassandra-cql/src/test/conf/gora.properties --- @@ -0,0 +1,30 @@ +# --- End diff -- Please make sure that all configuration

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122811392 --- Diff: gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/Constants.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122807843 --- Diff: gora-cassandra-cql/pom.xml --- @@ -0,0 +1,230 @@ + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122808040 --- Diff: gora-cassandra-cql/pom.xml --- @@ -0,0 +1,230 @@ + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122808264 --- Diff: gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java --- @@ -0,0 +1,516 @@ +/* + * Licensed to the Apache

[GitHub] gora pull request #110: Initial commit gora cassandra cql

2017-06-19 Thread lewismc
Github user lewismc commented on a diff in the pull request: https://github.com/apache/gora/pull/110#discussion_r122812132 --- Diff: gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStore.java --- @@ -0,0 +1,92 @@ +/** + * Licensed

  1   2   3   4   >