[GitHub] gora pull request: GORA-433 Non-Final Public Static Fields Should ...

2015-09-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/gora/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] gora pull request: GORA-433 Non-Final Public Static Fields Should ...

2015-09-03 Thread kamaci
GitHub user kamaci opened a pull request: https://github.com/apache/gora/pull/37 GORA-433 Non-Final Public Static Fields Should Be Final Non-final public static fields can be changed by external classes (by a malicious code or accidentally). You can merge this pull request into a

[GitHub] gora pull request: GORA-433 Non-Final Public Static Fields Should ...

2015-09-03 Thread lewismc
Github user lewismc commented on the pull request: https://github.com/apache/gora/pull/37#issuecomment-137548950 Does this only effect solr-store? Is this the entire PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] gora pull request: GORA-433 Non-Final Public Static Fields Should ...

2015-09-03 Thread kamaci
Github user kamaci commented on the pull request: https://github.com/apache/gora/pull/37#issuecomment-137561837 I've updated PR. These changes don't break anything (also passes tests as well). --- If your project is set up for it, you can reply to this email and have your reply